Commit graph

219 commits

Author SHA1 Message Date
Lorenz Kästle
de6e3c45f3 check_icmp: Apply clang-format again 2024-10-30 17:12:19 +01:00
Lorenz Kästle
3f1db8dc3a Merge branch 'master' into cleanup/check_icmp 2024-10-30 17:07:04 +01:00
RincewindsHat
aa1f9c5011 check_icmp: clang-format 2024-10-16 00:11:39 +02:00
RincewindsHat
cd4d59fbd4 check_dhcp: Declare internal variables static 2024-10-15 16:09:09 +02:00
RincewindsHat
a0e2266c75 check_dhcp: Update copyright 2024-10-15 16:01:27 +02:00
RincewindsHat
3934457c2a check_dhcp: clang-format 2024-10-15 16:00:07 +02:00
RincewindsHat
c0694cc6b5 check_icmp: Update copyright 2024-10-15 11:56:41 +02:00
RincewindsHat
780909f980 check_icmp: Properly mark function with void input 2024-10-15 11:55:27 +02:00
RincewindsHat
85f2e32e27 check_icmp: Declare internal variables static 2024-10-15 11:55:08 +02:00
RincewindsHat
0caa47a50b check_icmp: clang-format 2024-10-15 11:44:28 +02:00
Sven Nierlein
0488426c7e check_icmp: keep performance data order in case of none-reachable hosts
For responding hosts nothing changes:

    ./check_icmp -H 10.0.0.1
    OK - 10.0.0.1 rta 0.336ms lost 0%|rta=0.336ms;200.000;500.000;0; rtmax=0.471ms;;;; rtmin=0.000ms;;;; pl=0%;40;80;0;100

In case the host is down, the performance data now contain 'U' according to:
https://www.monitoring-plugins.org/doc/guidelines.html#AEN201

Old:
    ./check_icmp -H 10.0.0.99
    CRITICAL - 10.0.0.99: Host unreachable @ 10.0.1.138. rta nan, lost 100%|pl=100%;40;80;0;100

Old:
    ./check_icmp -H 10.0.0.99
    CRITICAL - 10.0.0.99: Host unreachable @ 10.0.1.138. rta nan, lost 100%|rta=U;;;; rtmax=U;;;; rtmin=U;;;; pl=100%;40;80;0;100

This confuses some performance graphing tools, ex.: pnp.

Signed-off-by: Sven Nierlein <sven@consol.de>
2024-03-01 09:03:17 +01:00
RincewindsHat
8fe3fc7829 check_dhcp: Make implicit conversion explicit to dismiss warning 2023-12-29 00:59:58 +01:00
Eric Knibbe
f25648d6bb
Prevent -lcrypto from showing up in Makefile dependencies 2023-12-06 11:40:18 -05:00
RincewindsHat
79e2f52094 Fix for -Wunused-but-set-variable 2023-10-16 00:59:30 +02:00
Lorenz Kästle
b6d3acf5e3 Merge branch 'master' into check_dhcp_rogue_detection 2023-10-13 19:09:29 +02:00
RincewindsHat
f5074ac7f0 Fix spelling stuff 2023-10-13 01:29:31 +02:00
RincewindsHat
0de0daccec Add some more comments about the MOS score 2023-10-13 01:25:22 +02:00
RincewindsHat
eb6c83a650 Even more code formatting and cleanup 2023-10-09 14:03:36 +02:00
RincewindsHat
9da06d5625 Do some more formatting 2023-10-09 01:57:37 +02:00
RincewindsHat
c568ad207c Remove preprocessor macro 2023-10-09 01:31:52 +02:00
RincewindsHat
f7df88dac3 Do some code formatting 2023-10-09 01:18:04 +02:00
RincewindsHat
b6fea24c3d More consequent booleans 2023-10-09 01:17:44 +02:00
RincewindsHat
6a4b9927cb fix unused variables compiler warning 2023-10-08 22:50:17 +02:00
RincewindsHat
b053278b18 fix sign compare compiler warnings 2023-10-08 22:49:45 +02:00
RincewindsHat
9426b9a338 Initialise threshold variables properly 2023-10-08 22:48:39 +02:00
RincewindsHat
da59856f99 Fix typo 2023-10-07 22:43:44 +02:00
RincewindsHat
b81847cb5f Refactor new threshold parser 2023-10-07 11:49:27 +02:00
RincewindsHat
19dc003936 Do some actual error checking on the threshold parser 2023-10-07 11:48:57 +02:00
RincewindsHat
9faa417aeb Remove useless return after crash 2023-10-06 16:05:01 +02:00
RincewindsHat
aba1ef97f3 Change function type of get_thresholds to better reflect the options and describe it in general 2023-10-06 16:04:43 +02:00
RincewindsHat
d54588eaf0 Update comment 2023-10-06 15:19:33 +02:00
RincewindsHat
6d7d9a87aa Refactor get_threshold2 to be barely understandable 2023-10-06 15:08:52 +02:00
Danijel Tasov
1ad7e163fa check malloc 2023-10-06 10:54:20 +02:00
Danijel Tasov
e365f9f58e do not introduce new ints as bools 2023-10-06 10:54:03 +02:00
datamuc
9280b0eee2
Merge branch 'master' into merge-jitter 2023-10-04 14:02:25 +02:00
Danijel Tasov
dfa5aa4b83 unnecessary space
Signed-off-by: Danijel Tasov <m@rbfh.de>
2023-10-04 11:56:23 +02:00
Danijel Tasov
1f49981982 readability improvements
Signed-off-by: Danijel Tasov <m@rbfh.de>
2023-10-04 11:52:09 +02:00
Danijel Tasov
843c0bfa46 remove sun ifdef
my be readded later with proper comments

Signed-off-by: Danijel Tasov <m@rbfh.de>
2023-10-04 11:45:16 +02:00
Danijel Tasov
4e7eb55079 add some basic tests for the new modes
Signed-off-by: Danijel Tasov <m@rbfh.de>
2023-10-04 11:34:25 +02:00
Danijel Tasov
df57a23e0a update failure regex 2023-10-04 10:39:30 +02:00
Danijel Tasov
6585711b0b fix host count on when checking multiple hosts 2023-10-04 10:22:35 +02:00
Danijel Tasov
396bcf50ce adjust check_icmp tests 2023-10-04 10:21:41 +02:00
Lorenz Kästle
103821efeb Make some booleans nicer 2023-10-03 12:25:48 +02:00
Lorenz Kästle
ec9ed25265 Some code formatting 2023-10-03 12:20:24 +02:00
Lorenz Kästle
2723d48d84 New variable is actually a boolean 2023-10-03 12:14:06 +02:00
Patrick Cervicek
65237fd7a5 check_dhcp.c merged patch from #752
- added dhcp rogue detection
	contributed by Patrick Cervicek (patrick AT cervicek.de)
  - closes #752
2023-10-03 12:13:23 +02:00
RincewindsHat
9f9f5fd9b2 Update copyright 2023-10-01 14:05:59 +02:00
RincewindsHat
f2ed728823 Remove trailing lines 2023-10-01 14:03:44 +02:00
RincewindsHat
11487d161c Comment some endifs to make comprehension easier 2023-10-01 14:03:34 +02:00
RincewindsHat
1aaa238503 Use real booleans 2023-10-01 13:59:00 +02:00