mirror of
https://github.com/monitoring-plugins/monitoring-plugins.git
synced 2026-02-03 18:49:29 -05:00
364ce21b10
Since the state patch introduction, we've been freeing uninitialized memory in lib/utils_base.c::np_cleanup(), which caused coredumps with check_snmp when illegal threshold ranges (for example) were passed, or when we called 'die' without having read any state. This patch fixes it by replacing the malloc() calls in there (all of them, since using malloc() is almost always an error) with calloc(). malloc() either doesn't initialize the memory at all, or taints it with a special marker so it can tell us when we're free()'ing memory that hasn't been initialized. calloc() explicitly initializes the allocated memory to nul bytes, which is a zero-cost operation when we get the memory from the kernel (which alread does that) and almost always desirable everywhere else. Signed-off-by: Andreas Ericsson <ae@op5.se> |
||
|---|---|---|
| .. | ||
| tests | ||
| extra_opts.c | ||
| extra_opts.h | ||
| Makefile.am | ||
| parse_ini.c | ||
| parse_ini.h | ||
| utils_base.c | ||
| utils_base.h | ||
| utils_cmd.c | ||
| utils_cmd.h | ||
| utils_disk.c | ||
| utils_disk.h | ||
| utils_tcp.c | ||
| utils_tcp.h | ||