upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-03-21 18:11:02 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

chore: Make the LoginController strict

Browse source 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
This commit is contained in:
Christoph Wurst 2022-12-15 10:52:28 +01:00
parent 0d6a706bc0
commit 138deec333
No known key found for this signature in database
GPG key ID: CC42AC2A7F0E56D8
2 changed files with 21 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
core/Controller/LoginController.php
View file

@ -1,4 +1,7 @@
<?php
declare(strict_types=1);
/**
* @copyright Copyright (c) 2017, Sandro Lutz <sandro.lutz@temparus.ch>
* @copyright Copyright (c) 2016 Joas Schilling <coding@schilljs.com>
@ -227,7 +230,7 @@ class LoginController extends Controller {
$user = null;
}
$passwordLink = $this->config->getSystemValue('lost_password_link', '');
$passwordLink = $this->config->getSystemValueString('lost_password_link', '');
$this->initialStateService->provideInitialState(
'core',

21
tests/Core/Controller/LoginControllerTest.php
View file

@ -1,4 +1,7 @@
<?php
declare(strict_types=1);
/**
* @author Lukas Reschke <lukas@owncloud.com>
*
@ -337,11 +340,16 @@ class LoginControllerTest extends TestCase {
->method('isLoggedIn')
->willReturn(false);
$this->config
->expects($this->exactly(2))
->expects(self::once())
->method('getSystemValue')
->willReturnMap([
['login_form_autocomplete', true, true],
['lost_password_link', '', false],
]);
$this->config
->expects(self::once())
->method('getSystemValueString')
->willReturnMap([
['lost_password_link', '', ''],
]);
$user = $this->createMock(IUser::class);
$user
@ -386,11 +394,16 @@ class LoginControllerTest extends TestCase {
->method('isLoggedIn')
->willReturn(false);
$this->config
->expects($this->exactly(2))
->expects(self::once())
->method('getSystemValue')
->willReturnMap([
['login_form_autocomplete', true, true],
['lost_password_link', '', false],
]);
$this->config
->expects(self::once())
->method('getSystemValueString')
->willReturnMap([
['lost_password_link', '', ''],
]);
$user = $this->createMock(IUser::class);
$user->expects($this->once())