Merge pull request #57908 from nextcloud/fix/2fa/allow-null-redirect-url-challenge

fix(2fa): allow null redirect URL on 2FA challenge page
2026-02-03 20:41:22 -05:00 · 2026-01-29 15:30:41 +01:00 · 2026-01-29 15:30:41 +01:00 · 2066eb4275
commit 2066eb4275
parent 400fe317e9 a228601ed0
1 changed files with 2 additions and 2 deletions
--- a/core/Controller/TwoFactorChallengeController.php
+++ b/core/Controller/TwoFactorChallengeController.php
@ -72,7 +72,7 @@ class TwoFactorChallengeController extends Controller {
 	#[NoCSRFRequired]
 	#[FrontpageRoute(verb: 'GET', url: '/login/selectchallenge')]
 	#[TwoFactorSetUpDoneRequired]
-	public function selectChallenge(string $redirect_url): StandaloneTemplateResponse {
+	public function selectChallenge(?string $redirect_url = null): StandaloneTemplateResponse {
 		$user = $this->userSession->getUser();
 		$providerSet = $this->twoFactorManager->getProviderSet($user);
 		$allProviders = $providerSet->getProviders();
@ -96,7 +96,7 @@ class TwoFactorChallengeController extends Controller {
 	#[UseSession]
 	#[TwoFactorSetUpDoneRequired]
 	#[FrontpageRoute(verb: 'GET', url: '/login/challenge/{challengeProviderId}')]
-	public function showChallenge(string $challengeProviderId, string $redirect_url): StandaloneTemplateResponse|RedirectResponse {
+	public function showChallenge(string $challengeProviderId, ?string $redirect_url = null): StandaloneTemplateResponse|RedirectResponse {
 		$user = $this->userSession->getUser();
 		$providerSet = $this->twoFactorManager->getProviderSet($user);
 		$provider = $providerSet->getProvider($challengeProviderId);