diff --git a/apps/dav/appinfo/v1/caldav.php b/apps/dav/appinfo/v1/caldav.php index 6cfb712984f..d1c1381be0a 100644 --- a/apps/dav/appinfo/v1/caldav.php +++ b/apps/dav/appinfo/v1/caldav.php @@ -24,6 +24,7 @@ use OCA\DAV\Connector\Sabre\Principal; use OCP\Accounts\IAccountManager; use OCP\App\IAppManager; use OCP\EventDispatcher\IEventDispatcher; +use OCP\IAppConfig; use OCP\ICacheFactory; use OCP\IConfig; use OCP\IDBConnection; @@ -56,7 +57,7 @@ $principalBackend = new Principal( Server::get(ProxyMapper::class), Server::get(KnownUserService::class), Server::get(IConfig::class), - \OC::$server->getL10NFactory(), + Server::get(IL10NFactory::class), 'principals/' ); $db = Server::get(IDBConnection::class); @@ -84,7 +85,7 @@ $calDavBackend = new CalDavBackend( ); $debugging = Server::get(IConfig::class)->getSystemValue('debug', false); -$sendInvitations = Server::get(IConfig::class)->getAppValue('dav', 'sendInvitations', 'yes') === 'yes'; +$sendInvitations = Server::get(IAppConfig::class)->getValueBool('dav', 'sendInvitations', true); // Root nodes $principalCollection = new \Sabre\CalDAV\Principal\Collection($principalBackend); @@ -102,6 +103,7 @@ $nodes = [ $server = new \Sabre\DAV\Server($nodes); $server::$exposeVersion = false; $server->httpRequest->setUrl(Server::get(IRequest::class)->getRequestUri()); +/** @var string $baseuri defined in remote.php */ $server->setBaseUri($baseuri); // Add plugins @@ -126,4 +128,4 @@ $server->addPlugin(Server::get(RateLimitingPlugin::class)); $server->addPlugin(Server::get(CalDavValidatePlugin::class)); // And off we go! -$server->exec(); +$server->start(); diff --git a/apps/dav/appinfo/v1/carddav.php b/apps/dav/appinfo/v1/carddav.php index 415a5c9634a..5fe9f93d8b5 100644 --- a/apps/dav/appinfo/v1/carddav.php +++ b/apps/dav/appinfo/v1/carddav.php @@ -30,6 +30,7 @@ use OCP\IRequest; use OCP\ISession; use OCP\IUserManager; use OCP\IUserSession; +use OCP\L10N\IFactory as IL10nFactory; use OCP\Security\Bruteforce\IThrottler; use OCP\Server; use Psr\Log\LoggerInterface; @@ -53,7 +54,7 @@ $principalBackend = new Principal( Server::get(ProxyMapper::class), Server::get(KnownUserService::class), Server::get(IConfig::class), - \OC::$server->getL10NFactory(), + Server::get(IL10nFactory::class), 'principals/' ); $db = Server::get(IDBConnection::class); @@ -85,9 +86,10 @@ $nodes = [ $server = new \Sabre\DAV\Server($nodes); $server::$exposeVersion = false; $server->httpRequest->setUrl(Server::get(IRequest::class)->getRequestUri()); +/** @var string $baseuri defined in remote.php */ $server->setBaseUri($baseuri); // Add plugins -$server->addPlugin(new MaintenancePlugin(Server::get(IConfig::class), \OC::$server->getL10N('dav'))); +$server->addPlugin(new MaintenancePlugin(Server::get(IConfig::class), \OCP\Server::get(IL10nFactory::class)->get('dav'))); $server->addPlugin(new \Sabre\DAV\Auth\Plugin($authBackend)); $server->addPlugin(new Plugin()); @@ -104,4 +106,4 @@ $server->addPlugin(Server::get(CardDavRateLimitingPlugin::class)); $server->addPlugin(Server::get(CardDavValidatePlugin::class)); // And off we go! -$server->exec(); +$server->start(); diff --git a/apps/dav/appinfo/v1/publicwebdav.php b/apps/dav/appinfo/v1/publicwebdav.php index bc917e5b046..2eaf05ca2d9 100644 --- a/apps/dav/appinfo/v1/publicwebdav.php +++ b/apps/dav/appinfo/v1/publicwebdav.php @@ -14,6 +14,7 @@ use OCA\DAV\Files\Sharing\FilesDropPlugin; use OCA\DAV\Files\Sharing\PublicLinkCheckPlugin; use OCA\DAV\Storage\PublicOwnerWrapper; use OCA\FederatedFileSharing\FederatedShareProvider; +use OCP\App\IAppManager; use OCP\BeforeSabrePubliclyLoadedEvent; use OCP\Constants; use OCP\EventDispatcher\IEventDispatcher; @@ -26,16 +27,19 @@ use OCP\IRequest; use OCP\ISession; use OCP\ITagManager; use OCP\IUserSession; +use OCP\L10N\IFactory as IL10nFactory; use OCP\Security\Bruteforce\IThrottler; use OCP\Server; use Psr\Log\LoggerInterface; // load needed apps $RUNTIME_APPTYPES = ['filesystem', 'authentication', 'logging']; +Server::get(IAppManager::class)->loadApps($RUNTIME_APPTYPES); -OC_App::loadApps($RUNTIME_APPTYPES); - -OC_Util::obEnd(); +// Turn off output buffering to prevent memory problems +while (ob_get_level()) { + ob_end_clean(); +} Server::get(ISession::class)->close(); // Backends @@ -60,7 +64,7 @@ $serverFactory = new ServerFactory( Server::get(IRequest::class), Server::get(IPreview::class), $eventDispatcher, - \OC::$server->getL10N('dav') + Server::get(IL10nFactory::class)->get('dav') ); $requestUri = Server::get(IRequest::class)->getRequestUri(); @@ -68,6 +72,7 @@ $requestUri = Server::get(IRequest::class)->getRequestUri(); $linkCheckPlugin = new PublicLinkCheckPlugin(); $filesDropPlugin = new FilesDropPlugin(); +/** @var string $baseuri defined in public.php */ $server = $serverFactory->createServer( true, $baseuri, @@ -125,4 +130,4 @@ $event = new BeforeSabrePubliclyLoadedEvent($server); $eventDispatcher->dispatchTyped($event); // And off we go! -$server->exec(); +$server->start(); diff --git a/apps/dav/appinfo/v1/webdav.php b/apps/dav/appinfo/v1/webdav.php index 92ff55c850e..5453c0a8bfb 100644 --- a/apps/dav/appinfo/v1/webdav.php +++ b/apps/dav/appinfo/v1/webdav.php @@ -19,6 +19,7 @@ use OCP\IRequest; use OCP\ISession; use OCP\ITagManager; use OCP\IUserSession; +use OCP\L10N\IFactory as IL10nFactory; use OCP\SabrePluginEvent; use OCP\Security\Bruteforce\IThrottler; use OCP\Server; @@ -31,7 +32,9 @@ if (!str_contains(@ini_get('disable_functions'), 'set_time_limit')) { ignore_user_abort(true); // Turn off output buffering to prevent memory problems -\OC_Util::obEnd(); +while (ob_get_level()) { + ob_end_clean(); +} $dispatcher = Server::get(IEventDispatcher::class); @@ -45,7 +48,7 @@ $serverFactory = new ServerFactory( Server::get(IRequest::class), Server::get(IPreview::class), $dispatcher, - \OC::$server->getL10N('dav') + Server::get(IL10nFactory::class)->get('dav') ); // Backends @@ -68,6 +71,7 @@ $authPlugin->addBackend($bearerAuthPlugin); $requestUri = Server::get(IRequest::class)->getRequestUri(); +/** @var string $baseuri defined in remote.php */ $server = $serverFactory->createServer(false, $baseuri, $requestUri, $authPlugin, function () { // use the view for the logged in user return Filesystem::getView(); @@ -80,4 +84,4 @@ $event = new SabrePluginAddEvent($server); $dispatcher->dispatchTyped($event); // And off we go! -$server->exec(); +$server->start(); diff --git a/apps/dav/appinfo/v2/direct.php b/apps/dav/appinfo/v2/direct.php index 78156317029..66fbad52587 100644 --- a/apps/dav/appinfo/v2/direct.php +++ b/apps/dav/appinfo/v2/direct.php @@ -21,12 +21,15 @@ if (!str_contains(@ini_get('disable_functions'), 'set_time_limit')) { ignore_user_abort(true); // Turn off output buffering to prevent memory problems -\OC_Util::obEnd(); +while (ob_get_level()) { + ob_end_clean(); +} $requestUri = Server::get(IRequest::class)->getRequestUri(); /** @var ServerFactory $serverFactory */ $serverFactory = Server::get(ServerFactory::class); +/** @var string $baseuri defined in remote.php */ $server = $serverFactory->createServer( $baseuri, $requestUri, @@ -37,4 +40,4 @@ $server = $serverFactory->createServer( Server::get(IRequest::class) ); -$server->exec(); +$server->start(); diff --git a/apps/dav/appinfo/v2/publicremote.php b/apps/dav/appinfo/v2/publicremote.php index 8d509e636a8..facc4041bcc 100644 --- a/apps/dav/appinfo/v2/publicremote.php +++ b/apps/dav/appinfo/v2/publicremote.php @@ -17,6 +17,7 @@ use OCA\DAV\Storage\PublicShareWrapper; use OCA\DAV\Upload\ChunkingPlugin; use OCA\DAV\Upload\ChunkingV2Plugin; use OCA\FederatedFileSharing\FederatedShareProvider; +use OCP\App\IAppManager; use OCP\BeforeSabrePubliclyLoadedEvent; use OCP\Constants; use OCP\EventDispatcher\IEventDispatcher; @@ -41,8 +42,12 @@ use Sabre\DAV\Exception\NotFound; // load needed apps $RUNTIME_APPTYPES = ['filesystem', 'authentication', 'logging']; -OC_App::loadApps($RUNTIME_APPTYPES); -OC_Util::obEnd(); +Server::get(IAppManager::class)->loadApps($RUNTIME_APPTYPES); + +// Turn off output buffering to prevent memory problems +while (ob_get_level()) { + ob_end_clean(); +} $session = Server::get(ISession::class); $request = Server::get(IRequest::class); diff --git a/apps/dav/appinfo/v2/remote.php b/apps/dav/appinfo/v2/remote.php index 51d26b48a5a..df1c1d27a5a 100644 --- a/apps/dav/appinfo/v2/remote.php +++ b/apps/dav/appinfo/v2/remote.php @@ -15,8 +15,11 @@ if (!str_contains(@ini_get('disable_functions'), 'set_time_limit')) { ignore_user_abort(true); // Turn off output buffering to prevent memory problems -\OC_Util::obEnd(); +while (ob_get_level()) { + ob_end_clean(); +} $request = \OCP\Server::get(IRequest::class); +/** @var string $baseuri defined in remote.php */ $server = new Server($request, $baseuri); $server->exec(); diff --git a/build/psalm-baseline.xml b/build/psalm-baseline.xml index 75ce3d3bde5..d82e06feff5 100644 --- a/build/psalm-baseline.xml +++ b/build/psalm-baseline.xml @@ -82,87 +82,23 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - getPath())]]> - - - - - - - - - - - - - - - - - - - - - - - - - - - - getPath())]]> - - - - - - - - @@ -663,7 +599,6 @@ -