From 7479f8f525c59e725bf627c82887dad1e78968c4 Mon Sep 17 00:00:00 2001
From: Christoph Wurst <christoph@winzerhof-wurst.at>
Date: Fri, 23 Jun 2023 11:06:53 +0200
Subject: [PATCH] fix: BMP image without color info causes array access on
 `false`

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
---
 lib/private/legacy/OC_Image.php | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/private/legacy/OC_Image.php b/lib/private/legacy/OC_Image.php
index bade2a1af37..1e4afeef338 100644
--- a/lib/private/legacy/OC_Image.php
+++ b/lib/private/legacy/OC_Image.php
@@ -931,6 +931,11 @@ class OC_Image implements \OCP\IImage {
 						break;
 					case 8:
 						$color = @unpack('n', $vide . ($data[$p] ?? ''));
+						if ($color === false) {
+							fclose($fh);
+							$this->logger->warning('Invalid 8bit bmp without color', ['app' => 'core']);
+							return false;
+						}
 						$color[1] = isset($palette[$color[1] + 1]) ? $palette[$color[1] + 1] : $palette[1];
 						break;
 					case 4: