upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-29 10:03:32 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 29

chore!(\OCP\Files): remove deprecated static getStorage method

Browse source 
Was deprecated since Nextcloud 14 and is not used anymore.
Removing allows us to clean the OCP psalm baseline.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
This commit is contained in:
Ferdinand Thiessen 2025-05-15 14:11:47 +02:00
parent 07fa9b9311
commit 54eaad76c0
No known key found for this signature in database
GPG key ID: 45FAE7268762B400
4 changed files with 0 additions and 42 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
build/psalm-baseline-ocp.xml
View file

@ -41,9 +41,6 @@
</MissingTemplateParam>
</file>
<file src="lib/public/Files.php">
<FalsableReturnStatement>
<code><![CDATA[\OC_App::getStorage($app)]]></code>
</FalsableReturnStatement>
<UndefinedClass>
<code><![CDATA[\OC]]></code>
</UndefinedClass>

5
build/psalm-baseline.xml
View file

@ -4721,11 +4721,6 @@
<code><![CDATA[IteratorAggregate]]></code>
</MissingTemplateParam>
</file>
<file src="lib/public/Files.php">
<FalsableReturnStatement>
<code><![CDATA[\OC_App::getStorage($app)]]></code>
</FalsableReturnStatement>
</file>
<file src="lib/public/L10N/ILanguageIterator.php">
<MissingTemplateParam>
<code><![CDATA[\Iterator]]></code>

22
lib/private/legacy/OC_App.php
View file

@ -768,28 +768,6 @@ class OC_App {
}
}
/**
* @param string $appId
* @return \OC\Files\View|false
*/
public static function getStorage(string $appId) {
if (\OC::$server->getAppManager()->isEnabledForUser($appId)) { //sanity check
if (\OC::$server->getUserSession()->isLoggedIn()) {
$view = new \OC\Files\View('/' . OC_User::getUser());
if (!$view->file_exists($appId)) {
$view->mkdir($appId);
}
return new \OC\Files\View('/' . OC_User::getUser() . '/' . $appId);
} else {
\OCP\Server::get(LoggerInterface::class)->error('Can\'t get app storage, app ' . $appId . ', user not logged in', ['app' => 'core']);
return false;
}
} else {
\OCP\Server::get(LoggerInterface::class)->error('Can\'t get app storage, app ' . $appId . ' not enabled', ['app' => 'core']);
return false;
}
}
protected static function findBestL10NOption(array $options, string $lang): string {
// only a single option
if (isset($options['@value'])) {

12
lib/public/Files.php
View file

@ -105,16 +105,4 @@ class Files {
public static function buildNotExistingFileName($path, $filename) {
return \OC_Helper::buildNotExistingFileName($path, $filename);
}
/**
* Gets the Storage for an app - creates the needed folder if they are not
* existent
* @param string $app
* @return \OC\Files\View
* @since 5.0.0
* @deprecated 14.0.0 use IAppData instead
*/
public static function getStorage($app) {
return \OC_App::getStorage($app);
}
}