From 575cb92bbb4e7843318c865c0bbfe31ac02cfd11 Mon Sep 17 00:00:00 2001 From: Louis Chemineau Date: Wed, 26 Mar 2025 20:59:11 +0100 Subject: [PATCH] chore: Refactor callForSeenUsers to use getSeenUsers Signed-off-by: Louis Chemineau --- lib/private/User/Manager.php | 28 ++++++---------------------- 1 file changed, 6 insertions(+), 22 deletions(-) diff --git a/lib/private/User/Manager.php b/lib/private/User/Manager.php index 776a4bbe2fc..9ad6c06f22e 100644 --- a/lib/private/User/Manager.php +++ b/lib/private/User/Manager.php @@ -646,30 +646,14 @@ class Manager extends PublicEmitter implements IUserManager { return $result; } - /** - * @param \Closure $callback - * @psalm-param \Closure(\OCP\IUser):?bool $callback - * @since 11.0.0 - */ public function callForSeenUsers(\Closure $callback) { - $limit = 1000; - $offset = 0; - do { - $userIds = $this->getSeenUserIds($limit, $offset); - $offset += $limit; - foreach ($userIds as $userId) { - foreach ($this->backends as $backend) { - if ($backend->userExists($userId)) { - $user = $this->getUserObject($userId, $backend, false); - $return = $callback($user); - if ($return === false) { - return; - } - break; - } - } + $users = $this->getSeenUsers(); + foreach ($users as $user) { + $return = $callback($user); + if ($return === false) { + return; } - } while (count($userIds) >= $limit); + } } /**