upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-27 03:43:40 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

fix(files): do not show convert-file action in view-only shares

Browse source 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
This commit is contained in:
Ferdinand Thiessen 2026-04-22 17:20:52 +02:00 committed by backportbot[bot]
parent f569f79488
commit 5d579993f0
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
apps/files/src/actions/convertAction.ts
View file

@ -7,9 +7,10 @@ import type { IFileAction } from '@nextcloud/files'
import AutoRenewSvg from '@mdi/svg/svg/autorenew.svg?raw'
import { getCapabilities } from '@nextcloud/capabilities'
import { registerFileAction } from '@nextcloud/files'
import { Permission, registerFileAction } from '@nextcloud/files'
import { t } from '@nextcloud/l10n'
import { generateUrl } from '@nextcloud/router'
import { isPublicShare } from '@nextcloud/sharing/public'
import { convertFile, convertFiles } from './convertUtils.ts'
type ConversionsProvider = {
@ -30,7 +31,11 @@ export function registerConvertActions() {
id: `convert-${from}-${to}`,
displayName: () => t('files', 'Save as {displayName}', { displayName }),
iconSvgInline: () => generateIconSvg(to),
enabled: ({ nodes }) => {
enabled: ({ nodes, folder }) => {
if (isPublicShare() && !(folder.permissions & Permission.CREATE)) {
// cannot create the converted file in a public share if we don't have create permissions
return false
}
// Check that all nodes have the same mime type
return nodes.every((node) => from === node.mime)
},