Merge pull request #58793 from nextcloud/validatePreviewMimeType

fix(preview): Validate preview MIME type
2026-03-15 23:23:35 -04:00 · 2026-03-09 17:20:00 +01:00 · 2026-03-09 17:20:00 +01:00 · 92cf64f798
commit 92cf64f798
parent 938b9ba0ac 304c9fbc3b
1 changed files with 7 additions and 2 deletions
--- a/lib/private/Preview/Generator.php
+++ b/lib/private/Preview/Generator.php
@ -543,6 +543,10 @@ class Generator {
 			self::unguardWithSemaphore($sem);
 		}

+		if (!$preview->valid() || $preview->dataMimeType() === null) {
+			throw new \InvalidArgumentException('Preview generation failed: invalid or null MIME type');
+		}
+
 		$previewEntry = new Preview();
 		$previewEntry->generateId();
 		$previewEntry->setFileId($file->getId());
@ -557,12 +561,13 @@ class Generator {
 		$previewEntry->setMimeType($preview->dataMimeType());
 		$previewEntry->setEtag($file->getEtag());
 		$previewEntry->setMtime((new \DateTime())->getTimestamp());
+
 		if ($cacheResult) {
 			$previewEntry = $this->savePreview($previewEntry, $preview);
 			return new PreviewFile($previewEntry, $this->storageFactory, $this->previewMapper);
-		} else {
-			return new InMemoryFile($previewEntry->getName(), $preview->data());
 		}
+
+		return new InMemoryFile($previewEntry->getName(), $preview->data());
 	}

 	/**