upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-22 23:03:00 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 78

Fix similar potential problems with fetchOne loops

Browse source 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
This commit is contained in:
Côme Chilliet 2022-03-08 12:10:52 +01:00 committed by backportbot[bot]
parent 82f9eab30e
commit a737a2561b
4 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
apps/user_ldap/lib/Mapping/AbstractMapping.php
View file

@ -438,14 +438,14 @@ abstract class AbstractMapping {
$picker = $this->dbc->getQueryBuilder();
$picker->select('owncloud_name')
->from($this->getTableName());
$cursor = $picker->execute();
$cursor = $picker->executeQuery();
$result = true;
while ($id = $cursor->fetchOne()) {
while (($id = $cursor->fetchOne()) !== false) {
$preCallback($id);
if ($isUnmapped = $this->unmap($id)) {
$postCallback($id);
}
$result &= $isUnmapped;
$result = $result && $isUnmapped;
}
$cursor->closeCursor();
return $result;

2
apps/user_ldap/lib/Migration/Version1130Date20211102154716.php
View file

@ -259,7 +259,7 @@ class Version1130Date20211102154716 extends SimpleMigrationStep {
$result = $select->executeQuery();
$idList = [];
while ($id = $result->fetchOne()) {
while (($id = $result->fetchOne()) !== false) {
$idList[] = $id;
}
$result->closeCursor();

2
apps/workflowengine/lib/Manager.php
View file

@ -351,7 +351,7 @@ class Manager implements IManager {
$result = $qb->execute();
$this->operationsByScope[$scopeContext->getHash()] = [];
while ($opId = $result->fetchOne()) {
while (($opId = $result->fetchOne()) !== false) {
$this->operationsByScope[$scopeContext->getHash()][] = (int)$opId;
}
$result->closeCursor();

2
apps/workflowengine/lib/Migration/PopulateNewlyIntroducedDatabaseFields.php
View file

@ -57,7 +57,7 @@ class PopulateNewlyIntroducedDatabaseFields implements IRepairStep {
$qb = $this->dbc->getQueryBuilder();
$insertQuery = $qb->insert('flow_operations_scope');
while ($id = $ids->fetchOne()) {
while (($id = $ids->fetchOne()) !== false) {
$insertQuery->values(['operation_id' => $qb->createNamedParameter($id), 'type' => IManager::SCOPE_ADMIN]);
$insertQuery->execute();
}