upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-14 01:21:32 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

perf: remove unneeded sort when listing mail shares

Browse source 
Signed-off-by: Robin Appelman <robin@icewind.nl>
This commit is contained in:
Robin Appelman 2026-05-08 18:11:08 +02:00
parent 6e3914f951
commit b49ef46e72
No known key found for this signature in database
GPG key ID: 42B69D8A64526EFB
1 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
apps/sharebymail/lib/ShareByMailProvider.php
View file

@ -653,8 +653,7 @@ class ShareByMailProvider extends DefaultShareProvider implements IShareProvider
$qb->select('*')
->from('share')
->where($qb->expr()->eq('parent', $qb->createNamedParameter($parent->getId())))
->andWhere($qb->expr()->eq('share_type', $qb->createNamedParameter(IShare::TYPE_EMAIL)))
->orderBy('id');
->andWhere($qb->expr()->eq('share_type', $qb->createNamedParameter(IShare::TYPE_EMAIL)));
$cursor = $qb->executeQuery();
while ($data = $cursor->fetchAssociative()) {
@ -854,7 +853,9 @@ class ShareByMailProvider extends DefaultShareProvider implements IShareProvider
}
$qb->setFirstResult($offset);
$qb->orderBy('id');
if ($offset !== 0 || $limit !== -1) {
$qb->orderBy('id');
}
$cursor = $qb->executeQuery();
$shares = [];
@ -935,8 +936,10 @@ class ShareByMailProvider extends DefaultShareProvider implements IShareProvider
$qb->select('*')
->from('share');
// Order by id
$qb->orderBy('id');
// Order by id only if we need it for limit/offset
if ($offset !== 0 || $limit !== -1) {
$qb->orderBy('id');
}
// Set limit and offset
if ($limit !== -1) {
@ -1176,8 +1179,6 @@ class ShareByMailProvider extends DefaultShareProvider implements IShareProvider
$qb->andWhere($qb->expr()->eq('f.parent', $qb->createNamedParameter($node->getId())));
$qb->orderBy('id');
$cursor = $qb->executeQuery();
$shares = [];
while ($data = $cursor->fetchAssociative()) {