From cba4f1b6166efbfbbc7b040a92eef60213b20fab Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=B4me=20Chilliet?= Date: Tue, 9 Sep 2025 11:03:34 +0200 Subject: [PATCH] fix(tests): Fix PHP warnings in tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Côme Chilliet --- .../DAV/Listener/UserEventsListenerTest.php | 1 + .../unit/Upload/UploadAutoMkcolPluginTest.php | 37 ++++++++++--------- .../tests/Controller/ViewControllerTest.php | 6 +++ 3 files changed, 26 insertions(+), 18 deletions(-) diff --git a/apps/dav/tests/unit/DAV/Listener/UserEventsListenerTest.php b/apps/dav/tests/unit/DAV/Listener/UserEventsListenerTest.php index aa5e419011c..b25340af067 100644 --- a/apps/dav/tests/unit/DAV/Listener/UserEventsListenerTest.php +++ b/apps/dav/tests/unit/DAV/Listener/UserEventsListenerTest.php @@ -34,6 +34,7 @@ class UserEventsListenerTest extends TestCase { private ExampleContactService&MockObject $exampleContactService; private ExampleEventService&MockObject $exampleEventService; private LoggerInterface&MockObject $logger; + private IJobList&MockObject $jobList; private UserEventsListener $userEventsListener; diff --git a/apps/dav/tests/unit/Upload/UploadAutoMkcolPluginTest.php b/apps/dav/tests/unit/Upload/UploadAutoMkcolPluginTest.php index baae839c8da..3ee352ade22 100644 --- a/apps/dav/tests/unit/Upload/UploadAutoMkcolPluginTest.php +++ b/apps/dav/tests/unit/Upload/UploadAutoMkcolPluginTest.php @@ -20,11 +20,29 @@ use Sabre\HTTP\ResponseInterface; use Test\TestCase; class UploadAutoMkcolPluginTest extends TestCase { - private Tree&MockObject $tree; private RequestInterface&MockObject $request; private ResponseInterface&MockObject $response; + private UploadAutoMkcolPlugin $plugin; + + protected function setUp(): void { + parent::setUp(); + + $server = $this->createMock(Server::class); + $this->tree = $this->createMock(Tree::class); + + $server->tree = $this->tree; + $this->plugin = new UploadAutoMkcolPlugin(); + + $this->request = $this->createMock(RequestInterface::class); + $this->response = $this->createMock(ResponseInterface::class); + $server->httpRequest = $this->request; + $server->httpResponse = $this->response; + + $this->plugin->initialize($server); + } + public static function dataMissingHeaderShouldReturnTrue(): Generator { yield 'missing X-NC-WebDAV-Auto-Mkcol header' => [null]; yield 'empty X-NC-WebDAV-Auto-Mkcol header' => ['']; @@ -113,21 +131,4 @@ class UploadAutoMkcolPluginTest extends TestCase { $return = $this->plugin->beforeMethod($this->request, $this->response); self::assertTrue($return); } - - protected function setUp(): void { - parent::setUp(); - - $server = $this->createMock(Server::class); - $this->tree = $this->createMock(Tree::class); - - $server->tree = $this->tree; - $this->plugin = new UploadAutoMkcolPlugin(); - - $this->request = $this->createMock(RequestInterface::class); - $this->response = $this->createMock(ResponseInterface::class); - $server->httpRequest = $this->request; - $server->httpResponse = $this->response; - - $this->plugin->initialize($server); - } } diff --git a/apps/files/tests/Controller/ViewControllerTest.php b/apps/files/tests/Controller/ViewControllerTest.php index e1a62a9336c..ede4c7f7fa3 100644 --- a/apps/files/tests/Controller/ViewControllerTest.php +++ b/apps/files/tests/Controller/ViewControllerTest.php @@ -308,6 +308,12 @@ class ViewControllerTest extends TestCase { } }); + $this->config + ->method('getUserValue') + ->willReturnMap([ + [$this->user->getUID(), 'files', 'files_sorting_configs', '{}', '{}'], + ]); + $this->viewController->index('', '', null); } }