From dc843f6d0a1c363bb5067221b49abc513f1a3653 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?C=C3=B4me=20Chilliet?= Date: Tue, 13 Jan 2026 11:48:36 +0100 Subject: [PATCH] fix: Use strict array search in other shipped apps as well MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Côme Chilliet --- apps/dav/lib/Connector/Sabre/TagsPlugin.php | 2 +- apps/settings/lib/Settings/Personal/PersonalInfo.php | 4 ++-- apps/user_status/lib/Listener/UserLiveStatusListener.php | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/dav/lib/Connector/Sabre/TagsPlugin.php b/apps/dav/lib/Connector/Sabre/TagsPlugin.php index b883673e582..7baf1742d61 100644 --- a/apps/dav/lib/Connector/Sabre/TagsPlugin.php +++ b/apps/dav/lib/Connector/Sabre/TagsPlugin.php @@ -123,7 +123,7 @@ class TagsPlugin extends \Sabre\DAV\ServerPlugin { $isFav = false; $tags = $this->getTags($fileId); if ($tags) { - $favPos = array_search(self::TAG_FAVORITE, $tags); + $favPos = array_search(self::TAG_FAVORITE, $tags, true); if ($favPos !== false) { $isFav = true; unset($tags[$favPos]); diff --git a/apps/settings/lib/Settings/Personal/PersonalInfo.php b/apps/settings/lib/Settings/Personal/PersonalInfo.php index afa9f076e1a..217f447d916 100644 --- a/apps/settings/lib/Settings/Personal/PersonalInfo.php +++ b/apps/settings/lib/Settings/Personal/PersonalInfo.php @@ -242,11 +242,11 @@ class PersonalInfo implements ISettings { $languages = $this->l10nFactory->getLanguages(); // associate the user language with the proper array - $userLangIndex = array_search($userConfLang, array_column($languages['commonLanguages'], 'code')); + $userLangIndex = array_search($userConfLang, array_column($languages['commonLanguages'], 'code'), true); $userLang = $languages['commonLanguages'][$userLangIndex]; // search in the other languages if ($userLangIndex === false) { - $userLangIndex = array_search($userConfLang, array_column($languages['otherLanguages'], 'code')); + $userLangIndex = array_search($userConfLang, array_column($languages['otherLanguages'], 'code'), true); $userLang = $languages['otherLanguages'][$userLangIndex]; } // if user language is not available but set somehow: show the actual code as name diff --git a/apps/user_status/lib/Listener/UserLiveStatusListener.php b/apps/user_status/lib/Listener/UserLiveStatusListener.php index 2db999d3712..cd26bd03976 100644 --- a/apps/user_status/lib/Listener/UserLiveStatusListener.php +++ b/apps/user_status/lib/Listener/UserLiveStatusListener.php @@ -82,7 +82,7 @@ class UserLiveStatusListener implements IEventListener { // If the emitted status is more important than the current status // treat it as outdated and update - if (array_search($event->getStatus(), StatusService::PRIORITY_ORDERED_STATUSES) < array_search($userStatus->getStatus(), StatusService::PRIORITY_ORDERED_STATUSES)) { + if (array_search($event->getStatus(), StatusService::PRIORITY_ORDERED_STATUSES, true) < array_search($userStatus->getStatus(), StatusService::PRIORITY_ORDERED_STATUSES, true)) { $needsUpdate = true; }