upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-03 20:41:22 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 15

chore(openmetrics): add more complete test for controller

Browse source 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
This commit is contained in:
Benjamin Gaussorgues 2026-01-26 11:44:15 +01:00
parent 34fe033ace
commit e81f01e5a0
No known key found for this signature in database
1 changed files with 22 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
tests/Core/Controller/OpenMetricsControllerTest.php
View file

@ -9,6 +9,7 @@ declare(strict_types=1);
namespace Tests\Core\Controller;
use Generator;
use OC\Core\Controller\OpenMetricsController;
use OC\OpenMetrics\ExporterManager;
use OCP\AppFramework\Http\IOutput;
@ -16,6 +17,9 @@ use OCP\AppFramework\Http\Response;
use OCP\AppFramework\Http\StreamTraversableResponse;
use OCP\IConfig;
use OCP\IRequest;
use OCP\OpenMetrics\IMetricFamily;
use OCP\OpenMetrics\Metric;
use OCP\OpenMetrics\MetricType;
use PHPUnit\Framework\MockObject\MockObject;
use Psr\Log\LoggerInterface;
use Test\TestCase;
@ -34,10 +38,23 @@ class OpenMetricsControllerTest extends TestCase {
->willReturn('192.168.1.1');
$this->config = $this->createMock(IConfig::class);
$this->exporterManager = $this->createMock(ExporterManager::class);
$this->exporterManager->method('export')->willReturnCallback([$this, 'getFakeMetrics']);
$this->logger = $this->createMock(LoggerInterface::class);
$this->controller = new OpenMetricsController('core', $this->request, $this->config, $this->exporterManager, $this->logger);
}
public function getFakeMetrics(): Generator {
$metric = $this->createMock(IMetricFamily::class);
$metric->method('type')->willReturn(MetricType::gauge);
$metric->method('unit')->willReturn('fake');
$metric->method('name')->willReturn('fake_count');
$metric->method('help')->willReturn('A fake count used for tests');
$metric->method('metrics')->willReturnCallback(function () {
yield new Metric(42, ['type' => 'used']);
yield new Metric(24, ['type' => 'unused']);
});
yield $metric;
}
public function testGetMetrics(): void {
$output = $this->createMock(IOutput::class);
$fullOutput = '';
@ -54,6 +71,11 @@ class OpenMetricsControllerTest extends TestCase {
$this->assertEquals('200', $response->getStatus());
$this->assertEquals('application/openmetrics-text; version=1.0.0; charset=utf-8', $response->getHeaders()['Content-Type']);
$expected = <<<EXPECTED
# TYPE nextcloud_fake_count gauge
# UNIT nextcloud_fake_count fake
# HELP nextcloud_fake_count A fake count used for tests
nextcloud_fake_count{type="used"} 42
nextcloud_fake_count{type="unused"} 24
# TYPE nextcloud_exporter_run_seconds gauge
# UNIT nextcloud_exporter_run_seconds seconds
# HELP nextcloud_exporter_run_seconds Exporter run time