From f47db8ca3da2f333f68c8495d78d457b944d03cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Tue, 28 Apr 2026 08:50:06 +0200 Subject: [PATCH] refactor: Move initialization of attributes to constructor MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This makes the code more consistent with stable33 and later. Signed-off-by: Daniel Calviño Sánchez --- apps/dav/lib/CardDAV/UserAddressBooks.php | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/apps/dav/lib/CardDAV/UserAddressBooks.php b/apps/dav/lib/CardDAV/UserAddressBooks.php index 4c640af554e..79476c7c168 100644 --- a/apps/dav/lib/CardDAV/UserAddressBooks.php +++ b/apps/dav/lib/CardDAV/UserAddressBooks.php @@ -45,6 +45,9 @@ class UserAddressBooks extends \Sabre\CardDAV\AddressBookHome { private ?IGroupManager $groupManager, ) { parent::__construct($carddavBackend, $principalUri); + + $this->l10n = Util::getL10N('dav'); + $this->config = Server::get(IConfig::class); } /** @@ -53,13 +56,6 @@ class UserAddressBooks extends \Sabre\CardDAV\AddressBookHome { * @return IAddressBook[] */ public function getChildren() { - if ($this->l10n === null) { - $this->l10n = Util::getL10N('dav'); - } - if ($this->config === null) { - $this->config = Server::get(IConfig::class); - } - /** @var string|array $principal */ $principal = $this->principalUri; $addressBooks = $this->carddavBackend->getAddressBooksForUser($this->principalUri);