upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-03-29 05:43:57 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 32
86524 commits 821 branches 1191 tags 6.6 GiB
Commit graph

1345 commits

Author SHA1 Message Date
Côme Chilliet
c88a1d3961
fix: Remove static vars usage in user_ldap 
There are still some left, harder to remove.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2026-03-23 16:48:31 +01:00
Côme Chilliet
1398c598cf
fix: Remove static vars from user_ldap 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2026-03-23 16:34:01 +01:00
Arthur Schiwon
0ace547307
fix(LDAP): do not use count() inside a loop 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2026-03-18 11:34:35 +01:00
Arthur Schiwon
1c01895796
fix(LDAP): use displayname from DB, before reaching out to LDAP 
As we do it with other information of the user, we now use the known value
of a users displayname, and leave the updating to the background job. This
improves performance of user facing actions where the display name is
required and reduces queries to the LDAP server that are typically more
expensive.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2026-03-18 11:34:35 +01:00
Côme Chilliet
77b0d6cbbc
fix: Add missing Attribute and fix parameter type in renewpassword route 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2026-03-17 16:58:34 +01:00
Côme Chilliet
8aedcb4a82
Merge pull request #58652 from nextcloud/automated/noid/rector-changes 
Apply rector changes
 2026-03-05 16:03:50 +01:00
Côme Chilliet
279d5c226e
chore(user_ldap): Adapt code to LDAP constructor change, remove dead code 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2026-03-02 16:34:04 +01:00
nextcloud-command
663018455e refactor: Apply rector changes 
Signed-off-by: GitHub <noreply@github.com>
 2026-03-01 14:43:11 +00:00
Côme Chilliet
60c86848e4
fix: Use proper DI for LDAP class 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2026-02-26 15:21:40 +01:00
Côme Chilliet
c6f56ddbd7
fix(user_ldap): Remove usages of deprecated IServerContainer 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2026-02-26 13:31:26 +01:00
provokateurin
f12cecb684
feat(rector): Enable SafeDeclareStrictTypesRector 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2026-02-09 10:59:31 +01:00
Carl Schwan
65e769a861
refactor: Apply comments 
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
 2026-02-06 13:50:46 +01:00
Carl Schwan
5d0d0c17e5
chore(rector): Run rector on apps, core and tests directory 
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
 2026-02-06 13:23:23 +01:00
Côme Chilliet
af760d174f
feat: Implement new interface in LDAP user backend to reflect permissions 
This will prevent users from editing profile fields if those are
 configured to be sync from LDAP.
I did not include the avatar in this because it has a special handling.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2026-02-03 10:22:26 +01:00
Côme Chilliet
f2a5a8d70e
fix(user_ldap): Fix crash in some code path when a DN is longer that 64 
UserConfig throws in this case.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2026-01-27 14:05:53 +01:00
Côme Chilliet
c1dd559965
fix: Use strict array comparisons in user_ldap 
Otherwise there are issues with string values looking like numbers.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2026-01-13 11:46:57 +01:00
Ferdinand Thiessen
29e31ffdb1
refactor(user_ldap): migrate jQuery UI of password renewal to Vue 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2026-01-12 21:48:13 +01:00
Marcel Müller
f870041943 fix: Make User_Proxy IGetDisplayNameBackend complient 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
 2026-01-09 18:31:55 +01:00
Carl Schwan
1661855f5b
refactor: Make some code a bit more correct 
- Use PHP_FLOAT_EPSILON for float comparaison
- Simplify some getValueBool code

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
 2025-12-11 13:27:50 +01:00
Carl Schwan
2ae9626fec
refactor(user_ldap): Port most of the remaining deprecated IConfig usage 
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
 2025-12-11 13:27:48 +01:00
Carl Schwan
14daf4ca16
refactor(user_ldap): Port User\User to IUserConfig 
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
 2025-12-11 13:27:48 +01:00
Louis Chmn
291ec1e474 fix(user_ldap): Fix activation enforcement when testing the config 
Signed-off-by: Louis Chmn <louis@chmn.me>
 2025-12-04 17:16:21 +00:00
Côme Chilliet
7eefd725db fix(user_ldap): Do not use variables directly in translation strings 
I simply removed translations for exceptions which are never supposed to
 happen apart from API misuse or code bug.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-12-01 10:40:50 +01:00
Louis Chmn
1e17a9fe7a refactor(user_ldap): Migrate to Vue3 
Signed-off-by: Louis Chmn <louis@chmn.me>
 2025-11-25 13:36:23 +01:00
Côme Chilliet
c62166241a chore(user_ldap): Remove ajax endpoints 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Louis Chmn <louis@chmn.me>
 2025-11-21 14:23:58 +01:00
Côme Chilliet
28cef3ed6b fix(ldap): Add OCS route for clearing mapping without using ajax 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Louis Chmn <louis@chmn.me>
 2025-11-21 14:23:58 +01:00
Côme Chilliet
c414a7bdf8 fix: Fix documentation for controllers and update openapi.json 
Also removed save action from WizardController as there is already a
 route in ConfigApiController to save a configuration.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Louis Chmn <louis@chmn.me>
 2025-11-21 14:23:57 +01:00
Côme Chilliet
ac078b6e68 chore: Fix typing in WizardResult 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Louis Chmn <louis@chmn.me>
 2025-11-21 14:23:57 +01:00
Côme Chilliet
9d41d8172b fix(ldap): Fix wizard controller action route 
It seems naming a route parameter $action causes issue, so renamed it to
 $wizardAction.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Louis Chmn <louis@chmn.me>
 2025-11-21 14:23:57 +01:00
Côme Chilliet
a0e5548e49 feat(user_ldap): Add a wizard OCS API 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Louis Chmn <louis@chmn.me>
 2025-11-21 14:23:57 +01:00
Côme Chilliet
36475f2461 fix(user_ldap): Add OCS endpoint for copying configurations 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Louis Chmn <louis@chmn.me>
 2025-11-21 14:23:57 +01:00
Côme Chilliet
e842874a0a fix(user_ldap): Add OCS endpoint for testing configurations 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Louis Chmn <louis@chmn.me>
 2025-11-21 14:23:57 +01:00
Carl Schwan
4d47fdaa85 chore: Run rector with new rules for fetch 
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
 2025-11-18 17:45:57 +01:00
Arthur Schiwon
57cb905580
fix(LDAP): drop hard base checks for now 
The migration path is hard and unexpected. We can follow-up with a soft
setup check instead for a while, but needs to be discussed.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2025-10-29 18:21:45 +01:00
Arthur Schiwon
49f1c3f00e
refactor(LDAP): switch from prepares statement to query builder 
- has the advantage that queries will be reported in the query.log when
  configured

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2025-10-17 11:09:31 +02:00
Arthur Schiwon
155b75027c
feat: locally cache frequently requested LDAP mapping data 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2025-10-17 11:09:31 +02:00
Arthur Schiwon
fbd29bcf7f
fix(LDAP): properly disable are require TLS certificate verification 
- the old approach lead connection issues, as ldap_set_option was called
  too late. Specifically it needs to be called before ldap_connect and set
  globally!
- The old approach also connected it to the ldapTLS configuration, which
  has a misleading naming. It indicates StartTLS usage only, not plain TLS
  connections.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2025-10-09 20:22:37 +02:00
Côme Chilliet
723a3f0b96
fix(ldap): Fix copying and creating LDAP configuration 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-10-06 15:45:23 +02:00
Kate
52aed034b1
Merge pull request #55431 from nextcloud/fix/ocscontroller-usage 2025-10-01 10:43:21 +02:00
Louis Chemineau
87cb225668
refactor(user_ldap): Rewrite setup wizard 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-09-30 22:49:43 +02:00
provokateurin
13e98dce15 fix: Use the correct OCSController 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-09-30 16:51:51 +02:00
Ferdinand Thiessen
660f3f6fd1
refactor: use logical && || instead of weak and or operators 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-09-27 23:02:18 +02:00
Joas Schilling
1d43f6b4a9
Merge pull request #53714 from Mark-PAS/master 
Only attempt $result array access if array not empty.
 2025-07-14 11:25:27 +02:00
Ferdinand Thiessen
5981b7eb51
chore: apply new CSFixer rules 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

# Conflicts:
#	apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
 2025-07-01 16:26:50 +02:00
Mark
b04760af6e Only attempt $result array access if array not empty. 
Signed-off-by: Mark <mark@perkinsadministrationservices.com.au>
 2025-07-01 07:44:20 +09:30
Côme Chilliet
f48e5aa1f3
fix(user_ldap): Switch to OCP\IAppConfig and fix Helper constructor calls 
Using OCP\AppFramework\Services\IAppConfig is not possible because the
 Helper is queried from places outside of the application DI container
(ajax pages, tests, other applications through ILDAPProviderFactory…)

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-06-10 16:08:52 +02:00
Côme Chilliet
bc7309ca1c
fix(user_ldap): Store the list of used configuration prefixed in appconfig 
This avoids getting all keys from appconfig, which was triggering
 loading of lazy configuration on all requests.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-06-10 16:08:45 +02:00
Côme Chilliet
6da579fb1d
fix(user_ldap): Harmonize parameter obfuscation and serialization accross logging methods 
Debug log, profiler and ldap debug log had a different logic for
 sanitizing of parameters, aligning them.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-06-02 11:47:56 +02:00
provokateurin
78a175fc74
refactor: Apply rector refactorings 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-05-14 15:29:02 +02:00
Ferdinand Thiessen
1ae3fa4003
chore: replace leagcy OC_Helper calls with OCP\Util 
- Replace legacy calls with OCP\Util
- Add missing deprecation notices
- Inline implementation in OCP\Util and call it from OC_Helper

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-05-14 10:18:04 +02:00