upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-03 20:41:22 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 25
85584 commits 651 branches 1179 tags 8.1 GiB
Commit graph

230 commits

Author SHA1 Message Date
Daniel Kesselberg
bf5c11a8fa
fix(workflowengine): use constant to render template 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2026-01-27 22:57:24 +01:00
Carl Schwan
11cf69d8ba
fix(psalm): Fix static analysis issues in apps/*/tests 
There are still 1200 more to fix before we can enable static analysis
for the tests.

Signed-off-by: Carl Schwan <carlschwan@kde.org>
 2026-01-16 12:00:51 +01:00
Carl Schwan
7541afae07
refactor(workflowengine): Check if class is correct 
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
 2025-11-26 10:16:35 +01:00
Carl Schwan
4d47fdaa85 chore: Run rector with new rules for fetch 
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
 2025-11-18 17:45:57 +01:00
rakekniven
ee39b5093d chore(l10n): Use numbered placeholders 
Reported in Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2025-11-02 10:09:34 +01:00
Josh
f5039750b3
chore: fix formatting 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2025-09-24 11:29:36 -04:00
Josh
5131897997
fix(workflowenigne): stricter length headler handling 
Fixes #55276 and tidies things up a bit more for future maintenance.

Signed-off-by: Josh <josh.t.richards@gmail.com>
 2025-09-24 11:18:07 -04:00
Carl Schwan
6154bfa823 chore(psalm): Fix most issues with the workflowengine 
This found a real bug where we were catching an Doctrine exception
instead of a OCP\DB\Exception. This will be backported separately.

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
 2025-09-17 09:57:10 +02:00
Carl Schwan
7e1c49ad9d refactor: Port away from IQueryBuilder::execute in apps/ 
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
 2025-09-16 11:35:01 +02:00
Carl Schwan
0e7d5dce1c refactor: Port away from changeColumn 
Replace by the drop-in replacement modifyColumn

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
 2025-09-12 18:05:19 +02:00
Joas Schilling
78dcf3744d
Revert "feat: Implement Directory Check" 
This reverts commit feae8ba16a.
 2025-08-05 11:18:50 +02:00
Robin Windey
feae8ba16a feat: Implement Directory Check 
* Partially implements #27591

Signed-off-by: Robin Windey <ro.windey@gmail.com>
 2025-08-01 09:43:59 +00:00
Ferdinand Thiessen
5981b7eb51
chore: apply new CSFixer rules 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

# Conflicts:
#	apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
 2025-07-01 16:26:50 +02:00
Côme Chilliet
cd3a88805b fix: Remove legacy hacky workaround in OCA\WorkflowEngine\Listener 
It is not needed anymore since OCP\Util::addScript is used directly now,
 and not the function "script" from template functions.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-03-06 15:49:25 +01:00
Côme Chilliet
64863c9d46
chore: Apply new rector configuration to apps folder 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-13 11:46:42 +01:00
provokateurin
f25a71806b
fix(apps): Fix wrong or missing casts 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-23 17:08:29 +02:00
provokateurin
381077028a
refactor(apps): Use constructor property promotion when possible 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-21 12:37:59 +02:00
Git'Fellow
c254855222 chore(db): Correctly apply query types 
fix: psalm

fix: error

fix: add batch

fix: fatal error

fix: add batch

chore: add batch

chore: add batch

fix: psalm

fix: typo

fix: psalm

fix: return bool

fix: revert Manager
 2024-10-17 09:21:07 +02:00
Côme Chilliet
1a4978c4ea
chore: Apply rector configuration to apps folder 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-20 17:51:00 +02:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-19 14:21:20 +02:00
provokateurin
c2fb7a72da
fix(psalm): Fix @throws annotations 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-17 17:18:30 +02:00
Daniel Kesselberg
af6de04e9e
style: update codestyle for coding-standard 1.2.3 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-08-25 19:34:58 +02:00
provokateurin
e64667df37
refactor(workflowengine): Replace security annotations with respective attributes 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-07-27 21:36:15 +02:00
Joas Schilling
a2a0a5afcb
fix(workflows): Fix file systemtag cache 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-07-10 11:55:29 +02:00
Andy Scherzinger
cc1686dba9
chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-05-31 10:38:47 +02:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-02 14:16:21 +02:00
Côme Chilliet
8bcc2d352e chore: Fix missing template parameter for IEventListener 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-01-30 10:57:15 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-11-23 10:36:13 +01:00
Joas Schilling
d8ffbed2c2
fix(workflows): Finish password confirmation 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-11-16 06:25:42 +01:00
Arthur Schiwon
93505b2cdd fix(workflowengine): use andWhere() not second where() 
- an unconditional where() condition is added right before
- fixes also wrongly named methods in the Exception message

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-11-13 14:47:47 +01:00
Joas Schilling
997a1c46fb
fix(workflow): Fix "Call to a member function getUID() on null" with appdata 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-11-13 09:00:40 +01:00
Jonas
7441ce2b11
enh(IMountManager): Add method to get MountPoint from CachedMountInfo 
Signed-off-by: Jonas <jonas@freesources.org>
 2023-10-23 20:50:24 +02:00
Jonas
9193d8be40
fix(isLegitimatedForUserId): Setup mountpoints to check file access 
This fixes workflows on groupfolders, as it will consider access to
files in groupfolders.

It also fixes false positives where access to files was limited by other
means not taken into account before, e.g. access control.

For postDelete events, check for permissions of the parent folder
instead, as the file itself no longer exists.

Fixes: nextcloud/flow_notifications#71

Signed-off-by: Jonas <jonas@freesources.org>
 2023-10-23 20:47:16 +02:00
Côme Chilliet
0a9371f99f
Migrate applications away from deprecated ILogger 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-09-21 11:57:21 +02:00
Côme Chilliet
bfe42de8f8
Merge pull request #38604 from fsamapoor/replace_strpos_calls_in_workflowengine_app 
Refactors "strpos" calls in /apps/workflowengine
 2023-08-07 09:10:43 +02:00
Joas Schilling
aa039c986a
fix(workflowengine): Remove legacy event (deprecated since 17) 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-19 17:37:34 +02:00
Julius Härtl
06d80ba809 fix: Avoid failing with duplicate checks 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-07-12 16:54:13 +02:00
Faraz Samapoor
9d15e6e21d Fixes "PossiblyFalseArgument" notices. 
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
 2023-07-03 13:13:11 +03:30
Faraz Samapoor
5db241b942 Refactors "strpos" calls in /apps/workflowengine to improve code readability. 
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
 2023-07-03 13:13:11 +03:30
jld3103
efb7448cd2
workflowengine: Stop using a service alias for controller 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-06-19 09:43:44 +02:00
Joas Schilling
9ba091b348
fix(workflow): Check tag attribute 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-03-16 08:44:41 +01:00
Joas Schilling
5bc86dd6ac
techdebt(workflowengine): Remove transition event classes 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-03-03 15:33:17 +01:00
Joas Schilling
15fc42966c
Also check the scope when reading operations from the database 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-02-23 06:13:00 +01:00
Joas Schilling
c6700150d5
Validate the scope when validating operations 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-02-23 06:13:00 +01:00
Julius Härtl
aebf654214
perf(workflowengine): Cache query that is performed on every request 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-02-10 14:33:07 +01:00
Robin Appelman
83cc8202b8
remove file exists check from cacheAndReturnMimeType 
the method is only called if the file exists already

a check against storing the fallback mimetype is added as a safety instead

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-12-20 13:28:40 +01:00
Robin Appelman
c5a8246742
use mimetype from cache for workflow if available 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-12-20 13:28:33 +01:00
Côme Chilliet
a0f6a6545b
Use TimedJob from OCP instead of OC 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-05 10:13:34 +01:00
Côme Chilliet
9ba9f9a7dc
Make sure to not pass null to DateTime::createFromFormat 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-14 16:23:50 +01:00
Carl Schwan
d5c23dbb9f Move CappedMemoryCache to OCP 
This is an helpful helper that should be used in more place than just
server and this is already the case with groupfodlers, deck, user_oidc
and more using it, so let's make it public

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-07-14 15:54:31 +02:00