upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-03 20:41:22 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 37
85600 commits 651 branches 1179 tags 8.1 GiB
Commit graph

58 commits

Author SHA1 Message Date
Ferdinand Thiessen
660f3f6fd1
refactor: use logical && || instead of weak and or operators 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-09-27 23:02:18 +02:00
Côme Chilliet
ae4d38eb63
fix: Allow hyphen in appid 
It’s rare but exists for some apps not in the appstore.
Also added unit tests for cleanAppId and fixed small issues with it.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-09-16 17:59:30 +02:00
Côme Chilliet
f5111c0961
chore(tests): Do not mock DependencyAnalyzer in AppManagerTest 
Not ideal to have coupled tests like that but it’s the easiest path
 forward to make sure the tests still covers the same usecase and avoid
 code duplication.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-08-18 17:09:40 +02:00
Côme Chilliet
12edd2b23a
fix: Deduplicate code by using DependencyAnalyzer in the AppManager 
Was a bit more complicated than expected because of a dependency loop,
the L10N factory uses the app manager, thus the AppManager cannot depend
on I10N directly or indirectly in its constructor.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-08-18 17:09:40 +02:00
Côme Chilliet
3cea218750
chore(tests): Use valid application names for tests 
Dash is not allowed in appid, underscore is.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-08-18 17:09:40 +02:00
Ferdinand Thiessen
0ef58c96ab
refactor(Memcache\Factory): move prefix generation to the factory class 
This removes a circular dependency between AppConfig and cache factory.
When a cache in the app config is used.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-08-18 13:24:18 +02:00
Robin Appelman
aa15f9d16d
chore: run rector 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-07-01 22:45:52 +02:00
Maxence Lange
d8fc08d718 feat(lexicon): fix tests 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2025-06-24 12:10:57 -01:00
Robin Appelman
29e39c0a2e
chore: run rector on tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-06-12 18:31:58 +02:00
Côme Chilliet
a2fdeccc31
chore(tests): Adapt AppManager test to the use of searchValues 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-06-05 17:58:54 +02:00
Ferdinand Thiessen
9422b6d6d0
test: adjust library tests for PHPunit deprecations 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-05-28 11:20:15 +02:00
Joas Schilling
720ab52e07
test: Fix tests/lib/App* 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-05-15 08:21:24 +02:00
Côme Chilliet
f758f565d4
fix: Replace getInstalledApps calls with getEnabledApps 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-13 10:19:20 +01:00
Côme Chilliet
a3685551f7
fix: Replace isInstalled calls with isEnabledForAnyone or isEnabledForUser 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-02-13 10:19:19 +01:00
Ferdinand Thiessen
31664b3edd
fix: Correctly return app id and app version for core styles and images 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-24 13:08:31 +01:00
skjnldsv
158299b3d7 fix(profile): make sure the app cannot be disabled as it was in core 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-11-14 10:25:10 +01:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-19 14:21:20 +02:00
Christoph Wurst
49dd79eabb
refactor: Add void return type to PHPUnit test methods 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-09-15 22:32:31 +02:00
Côme Chilliet
7ed583cb8e
chore: Migrate cleanAppId and getAppPath calls to IAppManager from OC_App 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-13 10:08:43 +02:00
provokateurin
70ed08daf1
refactor(AppManager): Deprecated default apps handling 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-09 11:04:36 +02:00
Richard Steinmetz
e42bceac9f
feat: hide caldav server settings if no app uses the caldav backend 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2024-07-16 09:18:33 +02:00
Andy Scherzinger
1f7e2ba599
chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-05-13 17:41:36 +02:00
Côme Chilliet
ac1d868d18
fix: Lazy load IURLGenerator from AppManager to avoid installation crash 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-22 15:50:06 +02:00
Côme Chilliet
a0be3ffdf2
fix: Fix tests following OC_App migrations to IAppManager 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-22 12:21:55 +02:00
Ferdinand Thiessen
c8d7a5acaa fix(AppManager): Allow to query dark **or** bright icon 
The navigation needs the bright icon, while the notifications and activity need a dark icon.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-03-08 09:51:03 +01:00
Ferdinand Thiessen
876e2d6198
feat(AppManager): Provide getAppIcon function 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-03-07 22:40:31 +01:00
Ferdinand Thiessen
927e7fcf67
fix(AppManager): Ensure that app manager can handle empty app keys on the navigation entries 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2023-11-14 20:04:48 +01:00
Ferdinand Thiessen
8d0c7cc5fa
fix: Allow to set custom app order on navigation entries added by closures to NavigationManager 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2023-11-14 20:03:28 +01:00
Ferdinand Thiessen
e9d4036389
feat(theming): Allow to configure default apps and app order in frontend settings 
* Also add API for setting the value using ajax.
* Add cypress tests for app order and defaul apps

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2023-10-20 00:24:17 +02:00
Côme Chilliet
2d28e8110f
Fix and extend tests for AppManager::getDefaultAppForUser 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-09-26 14:59:05 +02:00
Côme Chilliet
f57c12b14e
Fix various deprecation warnings in tests on PHP 8.3 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-08-14 18:13:12 +02:00
Joas Schilling
5bb6a7804f
fix: Move AppManager events to IEventDispatcher 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-27 09:57:51 +02:00
Christoph Wurst
3d1acca1f3
chore(app): Do not clear unused cache key 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-05-30 17:48:20 +02:00
Christopher Ng
4f8e916585 Add label for logo link 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2023-03-29 13:36:45 -07:00
Thomas Citharel
f1751c4428
Introduced app enable/disable/update typed events 
OCP\App\ManagerEvent is depreciated since 22 without a replacement

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2023-03-13 11:52:57 +01:00
szaimen
1d17a0843a set theming app to alwaysEnabled 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-10-17 17:51:39 +02:00
Joas Schilling
df47445c01
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-04-27 14:34:32 +02:00
Daniel Kesselberg
d766d09f01
Add test to ensure that symlinked apps_paths are not resolved 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-04-24 16:19:14 +02:00
Christoph Wurst
afbd9c4e6e
Unify function spacing to PSR2 recommendation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 13:54:22 +02:00
Christoph Wurst
2a529e453a
Use a blank line after the opening tag 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 11:50:14 +02:00
Christoph Wurst
b80ebc9674
Use the short array syntax, everywhere 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-26 16:34:56 +01:00
Christoph Wurst
2ee65f177e
Use the shorter phpunit syntax for mocked return values 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 22:21:27 +01:00
Joas Schilling
3eee359d7f
Allow to force enable apps via CLI 
Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-13 13:06:12 +01:00
Roeland Jago Douma
eb8ca3783c
Viewer should be always enabled 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-12-10 20:06:30 +01:00
Roeland Jago Douma
3a7cf40aaa
Mode to modern phpunit 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-27 15:27:18 +01:00
Roeland Jago Douma
c007ca624f
Make phpunit8 compatible 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-27 13:34:41 +01:00
Roeland Jago Douma
68748d4f85
Some php-cs fixes 
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-22 20:52:10 +01:00
Christoph Wurst
de6940352a Move settings to an app 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2019-09-28 09:39:28 +00:00
Morris Jobke
99f2c82222
Properly inject the logger 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2019-07-16 22:38:14 +02:00
Greta Doci
5898e87e0f Remove deleted groups from app restrictions fixes #15823 
Signed-off-by: Greta Doci <gretadoci@gmail.com>
 2019-06-27 20:17:50 +02:00