upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-03 20:41:22 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 37
85600 commits 651 branches 1179 tags 8.1 GiB
Commit graph

57 commits

Author SHA1 Message Date
Daniel Calviño Sánchez
fbe2023d39 fix: Unify handling of exclude groups in contacts menu and sharing 
If the current user belongs to both one or more groups excluded from
sharing and one or more groups not excluded from sharing the user is
allowed to share. However, in the contacts menu, as soon as the current
user belonged to a group excluded from sharing the user could not search
for local contacts. This has been unified now with the sharing
behaviour, so local contacts can still be searched if the user also
belongs to a group not excluded from sharing (or to no group at all,
which was also allowed before).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2025-12-09 19:16:59 +01:00
Daniel Calviño Sánchez
d59d8db1d6 test: Add unit test for excluded groups in contacts menu 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2025-12-09 19:16:59 +01:00
Daniel Calviño Sánchez
694651de3a test: Adjust unit test name to better reflect its behaviour 
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2025-12-09 19:16:59 +01:00
Robin Appelman
aa15f9d16d
chore: run rector 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-07-01 22:45:52 +02:00
Robin Appelman
3561937816
chore: run rector on tests with new rule 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-06-12 18:38:29 +02:00
Joas Schilling
c24f5fb256
test: Finish migrating tests/Core/ to PHPUnit 10 compatible code 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-05-02 16:47:42 +02:00
Ferdinand Thiessen
84f0fc88cc
feat(contacts): Show time difference for users in different timezones 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-16 18:10:04 +01:00
Christoph Wurst
49dd79eabb
refactor: Add void return type to PHPUnit test methods 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-09-15 22:32:31 +02:00
Andy Scherzinger
1f7e2ba599
chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-05-13 17:41:36 +02:00
Baptiste Fotia
449d28e610 test(php): Fix the unit tests 
I added our context in the unit tests following the advice of Louis.

Link : https://github.com/nextcloud/server/pull/43186#issuecomment-1916571027

Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
 2024-01-31 10:44:40 +01:00
Christoph Wurst
71080a8d20
feat(contactsmenu): Sort by user status 
If user_status is not enabled, fall back to sorting by contact name.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-11-08 21:53:35 +01:00
Christoph Wurst
ac168cf9ff feat(contactsmenu): Show user status 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-10-31 11:52:46 -07:00
Côme Chilliet
f57c12b14e
Fix various deprecation warnings in tests on PHP 8.3 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-08-14 18:13:12 +02:00
Simon L
b38d2daede fix the contacts-menu vcf-contact avatars 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-02-15 23:16:43 +01:00
Côme Chilliet
f5c361cf44
composer run cs:fix 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:45:08 +01:00
Joas Schilling
97e33c2bd4
Fix unit tests of the ActionProviderStore 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-01-04 16:17:43 +01:00
Joas Schilling
8eca26012f
Show local time in avatar menu 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-01-04 11:09:58 +01:00
Côme Chilliet
0d9c1510ca Fix ContactsStoreTests under PHP 8.2 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-10-26 20:03:49 +00:00
Andy Xheli
ae6a7c88a0 Update ContactsStoreTest.php 
Signed-off-by: Andy Xheli <axheli@axtsolutions.com>
 2022-10-03 09:17:27 -05:00
Thomas Citharel
232322fe06
Modernize contacts menu 
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2022-05-12 18:31:59 +02:00
Christopher Ng
1fc0b4320c Add global profile toggle config 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2022-03-18 02:55:12 +00:00
Joas Schilling
7f1dc52a66
Change origin field to appId 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-10-20 14:47:28 +02:00
John Molakvoæ
5e23800a95
Do not remove current user on findOne 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2021-10-20 11:53:45 +02:00
John Molakvoæ
873e8e219c
Add appName to contactsmenu action API 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2021-10-20 11:53:45 +02:00
Christopher Ng
309354852f Profile backend 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2021-10-19 04:59:35 +00:00
Daniel Kesselberg
024881dbd3
Add email addresses to contacts menu 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2021-09-15 16:58:44 +02:00
Joas Schilling
5b53b6f977
Add a setting to restrict returning a full match unless in phonebook or same group 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-10 17:25:57 +01:00
Joas Schilling
236aa194e2
Restrict autocompletion also based on the phonebook known users 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-03-10 17:19:55 +01:00
Roeland Jago Douma
f04a2ce19f Pimp ActionProviderStore 
* Fix paradoxale condition
* Add types
* Move away from ILogger

Makes psalm happy, and thus me happy

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2021-03-04 12:29:49 +01:00
Arthur Schiwon
d8ad4ef6b5
use a consistent default value for sharing.maxAutocompleteResults 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-12-15 11:53:39 +01:00
Morris Jobke
234b510652
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-12 13:55:19 +02:00
Christoph Wurst
caff1023ea
Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Christoph Wurst
2fbad1ed72
Fix (array) indent style to always use one tab 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 10:16:08 +02:00
Roeland Jago Douma
4a292126e5
Merge pull request #20139 from nextcloud/unify-default-value-for-restricting-user-enumeration-with-settings 
Unify default value for restricting user enumeration with settings
 2020-04-04 10:33:04 +02:00
Christoph Wurst
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports 
Remove unused imports
 2020-03-27 17:14:08 +01:00
Christoph Wurst
2ee65f177e
Use the shorter phpunit syntax for mocked return values 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 22:21:27 +01:00
Christoph Wurst
74936c49ea
Remove unused imports 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 22:08:08 +01:00
Daniel Calviño Sánchez
d4f25b01b8 Unify default value for restricting user enumeration with settings 
If the value was never enabled or disabled, the settings show "Restrict
username enumeration to groups" as disabled. However, in some components
it was enabled by default, which caused an inconsistency in the
behaviour with respect to the settings, for example in the contacts
menu.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2020-03-24 14:30:59 +01:00
Julius Härtl
0ef53ebc08 Add tests for ContactsStore filtering 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-03-20 10:43:56 +01:00
Christoph Wurst
87ec729f34
Do not encode contacts menu mailto links 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-01-28 14:57:45 +01:00
Roeland Jago Douma
3a7cf40aaa
Mode to modern phpunit 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-27 15:27:18 +01:00
Roeland Jago Douma
c007ca624f
Make phpunit8 compatible 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-27 13:34:41 +01:00
Roeland Jago Douma
357263a70b
Do not try to autoload built in types 
This avoids calls to the autoloader (or chain of autoloaders) to see if
for example 'principalPrefix' class can be found. While we already know
it is a string.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-06-04 15:13:32 +02:00
Julius Härtl
db17c14f80
Respect sharing enumeration config in contacts menu 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2019-04-18 11:39:49 +02:00
Joas Schilling
bf2be08c9f
Fix risky tests without assertions 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-01-25 11:33:25 +01:00
Joas Schilling
c3424df1f0
Require PHPUnit 6.5 or higher 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2018-01-24 17:23:59 +01:00
Lukas Reschke
705432ca6f
Add filter for shareapi_allow_share_dialog_user_enumeration 
This adjusts the contacts menu to also support searching by email address which is relevant in scenarios where no UID is known such as LDAP, etc.

Furthermore, if `shareapi_allow_share_dialog_user_enumeration` is disabled only results are shown that match the full user ID or email address.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2017-09-15 15:58:04 +02:00
Tobia De Koninck
fa402c74d2
Add tests 
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
 2017-09-15 14:31:40 +02:00
Tobia De Koninck
473a1ecad1
Fix tests 
Signed-off-by: Tobia De Koninck <tobia@ledfan.be>
 2017-09-15 14:31:39 +02:00
Christoph Wurst
b13c741cb3
Do not show an email action for contacts with emtpy email addresses 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2017-05-02 14:12:04 +02:00