upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-03 20:41:22 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 25
57289 commits 651 branches 1179 tags 8.1 GiB
Commit graph

165 commits

Author SHA1 Message Date
Joas Schilling
87255e61a7
fix(workflow): Check tag attribute 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-03-16 08:59:59 +01:00
Joas Schilling
b24a18a857
Also check the scope when reading operations from the database 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-02-23 06:26:44 +01:00
Joas Schilling
9cee3f29da
Validate the scope when validating operations 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-02-23 06:26:43 +01:00
Carl Schwan
e5c54bd8ac
Fix psalm issues 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-17 14:39:31 +01:00
Carl Schwan
33f49b13ed Add helper method in Wrapper 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-14 14:16:09 +00:00
Carl Schwan
27334942ca The storage is not static anymore 
Don't call twice $cache->getId

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-14 14:16:06 +00:00
Carl Schwan
a8539c8084 Optimize FileSystemTags workflow for groupfolder 
In https://github.com/nextcloud/server/pull/28774 we disabled the
caching for the groupfolder application since it worked due to the fact
that in groupfolders, getFileIds could be called with the same $cacheId
and path for actually different groupfolders.

This revert this change and instead add the folderId from the
groupFolder to the cacheId. This solve the issue of the uniqueness of
the cacheId inside GroupFolder. Downside is that we introduce
groupfolder specific implementation inside the server repo.

The seconf optimization is to not consider paths starting with
__groupfolders in executeCheck. This is due to the fact that files in
the groupfolder application call two times executeCheck one time with
the url __groupfolder/<folderId>/<path> and the other time with <path>.
The first time will always return an empty systemTags array while the
second call will return the correct system tags.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-14 14:16:05 +00:00
Joas Schilling
c363479279 Detect mimetype by content only with content 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-10-27 13:47:20 +00:00
Arthur Schiwon
916b2e7164 fixes an undefined index when getAccessList returns an empty array 
- [] is a valid return value that should be honored as having no access

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-10-23 12:53:23 +00:00
Richard Steinmetz
3aa21120bc Do not cache file ids in FileSystemTags inside group folders 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2021-09-14 14:12:39 +00:00
Vincent Petry
0cfbc41ab7
Merge pull request #28382 from nextcloud/backport/28318/stable20 
[stable20] Make "name" column nullable for workflows
 2021-09-13 12:11:16 +02:00
Daniel Kesselberg
7b5ed40da9 Set alias for result of cast column function 
On OCI an expression like to_char(events) end up as $row['to_char(events)'] in the query result.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2021-08-20 13:46:23 +00:00
Vincent Petry
ffe7467187
Make "name" column nullable in workflow operations 
The "name" column is now unused and the code is always inserting an
empty string. While this works with most databases, Oracle complains
because an empty string is equivalent to null.

To fix this, the column definition is changed to allow null values now.

Also added some logging in case of database exceptions, because without
this nothing would be logged to detect the above problem.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2021-08-12 14:11:11 +02:00
Arthur Schiwon
b432a9f5da consider local external storages, too 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-12-18 10:48:46 +00:00
Arthur Schiwon
c0c88e3bd8 enables the file name check also to match name of mountpoints 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-12-18 10:48:42 +00:00
Morris Jobke
1181058d18 Only execute plain mimetype check for directories and do the fallback only for non-directories 
Ref #23096

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-12-02 20:02:27 +00:00
Joas Schilling
61f1c12fb1
Merge pull request #24333 from nextcloud/backport/24315/stable20 
[stable20] avoid empty null default with value that will be inserted anyways
 2020-11-26 14:50:27 +01:00
Julius Härtl
49bd82292c Files client and info bundles are always loaded so we don't need to load them again 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-11-25 16:11:36 +00:00
Arthur Schiwon
4850019fcd avoid empty null default with value that will be inserted anyways 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-11-24 10:31:27 +00:00
Arthur Schiwon
e2577440b3 inform the user when flow config data exceeds thresholds 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-10-28 15:11:06 +00:00
Julius Härtl
53ac186473 Make sure to check the mimetype on the path if a secure one could not be detemined though the content 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-10-06 06:08:04 +00:00
J0WI
1639289b95 Update urls to stackoverflow.com to "HTTPS" 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2020-09-17 17:38:27 +02:00
Joas Schilling
aa5e4aacc1
Don't use SELECT DISTINCT when to_char() is used in a WHERE statement 
Nice bug in Oracle

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-09-07 15:17:48 +02:00
Arthur Schiwon
28c0eea8cb
fix possible leaking scope in Flow 
- a configured flow can be brought into consideration, despite its event
  was not fired
- it could either run through
- or run into a RuntimeException and killing processing of valid flows

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-08-24 13:44:01 +02:00
Morris Jobke
c0be7e329f
Prefer typed event over string based ones 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-10 15:22:55 +02:00
Arthur Schiwon
692e6a6838
File entity to implement IIcon 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-08-07 00:14:50 +02:00
Arthur Schiwon
b59efb61bd
Flow File entity implements IContextPortation 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-08-05 15:21:57 +02:00
Christoph Wurst
91e7f12088
Adjust apps' code to use the ContainerInterface 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-21 20:43:18 +02:00
Roeland Jago Douma
c97e85c6da
Merge pull request #21547 from nextcloud/enhancement/workflowengine-bootstrap 
Migrate WFE to the new bootstrap mechanism
 2020-07-02 21:03:14 +02:00
Roeland Jago Douma
2464a60879
Merge pull request #21590 from nextcloud/debt/noid/unused-method 
Remove unused method.
 2020-07-02 20:58:20 +02:00
Roeland Jago Douma
0157e30ad4
Merge pull request #21599 from nextcloud/debt/noid/type-to-types 
Replace TYPE with TYPES
 2020-07-02 12:21:01 +02:00
Daniel Kesselberg
87dd760a89
Replace TYPE with TYPES 
As TYPE::* is deprecated.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-06-30 23:46:22 +02:00
Joas Schilling
d7c0b9cced
Also always return in app commands 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-26 15:12:11 +02:00
Daniel Kesselberg
dcee9fbf35
Remove unused method. 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-06-25 23:36:54 +02:00
Christoph Wurst
1428853c86
Move the event listener into a dedicated class 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-24 10:54:13 +02:00
Christoph Wurst
7c0c180a56
Migrate WFE to new bootstrap mechanism 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-24 10:54:03 +02:00
Arthur Schiwon
3706eae777
flow to not use deprecated event dispatcher methods 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-06-19 23:03:07 +02:00
Julius Härtl
11329dcb42
Flow: Include root folder for shared storages when fetching system tags 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-06-15 08:28:12 +02:00
Roeland Jago Douma
28f8a445e4 Move the systemtags to core/src 
* Move to the handlebar loader from webpack

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
 2020-05-28 19:05:09 +00:00
Christoph Wurst
28f8eb5dba
Add visibility to all constants 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:54:27 +02:00
Christoph Wurst
1584c9ae9c
Add visibility to all methods and position of static keyword 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:51:06 +02:00
Christoph Wurst
caff1023ea
Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Christoph Wurst
14c996d982
Use elseif instead of else if 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 10:35:09 +02:00
Christoph Wurst
afbd9c4e6e
Unify function spacing to PSR2 recommendation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 13:54:22 +02:00
Christoph Wurst
2a529e453a
Use a blank line after the opening tag 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 11:50:14 +02:00
Christoph Wurst
41b5e5923a
Use exactly one empty line after the namespace declaration 
For PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 11:48:10 +02:00
Christoph Wurst
74936c49ea
Remove unused imports 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 22:08:08 +01:00
Julius Härtl
e4829236cf
Add app config to disable user flows 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-03-21 08:58:41 +01:00
Daniel Kesselberg
b3780bcedd
Annotate $additionalScopes so the IDE knows what type $scopeCandidate is. 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-03-17 15:27:22 +01:00
Roeland Jago Douma
e193e14a08
Merge pull request #19989 from nextcloud/fix-single-ScopeContext-passed-to-setScopes 
Fix single "ScopeContext" passed to "setScopes"
 2020-03-17 15:08:25 +01:00