upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-03 20:41:22 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 25
66349 commits 651 branches 1179 tags 8.1 GiB
Commit graph

119 commits

Author SHA1 Message Date
Côme Chilliet
6b2580d49a
Apply suggestions from code review in View.php 
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-09-05 14:36:23 +02:00
Côme Chilliet
168b07d038
Lower log to debug for connections aborted by the client 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-09-04 16:45:14 +02:00
Côme Chilliet
cb2a6d688f
Detect aborted connection in OC\Files\View and stop writing data to the 
output buffer

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-09-04 14:58:30 +02:00
Anna Larch
1e957b5c87
fix: don't emit Hooks when hookpaths are empty 
Signed-off-by: Anna Larch <anna@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
 2023-08-28 11:45:01 +02:00
Louis Chemineau
cb99a5795d Update cache when file size === 0 
The conditions were false when $result === 0.
$results here contains the number of written bits.
The correct way of checking for operation success is to check if $result === false

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-11-23 14:57:32 +00:00
Robin Appelman
0a2744a998 trigger a rescan when trying to fopen a file that exists in cache but not on disk 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-10-03 15:28:30 +00:00
Carl Schwan
51b9847fad
Merge branch 'master' into display-name-cache-public 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-08-15 15:28:30 +02:00
luz paz
368f83095d Fix typos in lib/private subdirectory 
Found via `codespell -q 3 -S l10n -L jus ./lib/private`

Signed-off-by: luz paz <luzpaz@github.com>
 2022-07-27 08:52:17 -04:00
Robin Appelman
6d6662ec68
expose displayname cache trough a public interface 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-05-18 03:47:34 +02:00
Côme Chilliet
069477e608
Migrate more classes of lib/private to LoggerInterface 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-04-26 16:52:52 +02:00
Vincent Petry
ff385dc679
Merge pull request #32082 from nextcloud/directory-content-lazy-owner 
use a lazy user for the file owner when listing a directory
 2022-04-25 11:44:44 +02:00
Robin Appelman
7a6c724a81 Use a lazy user for the file owner when listing a directory 
Only getUID and getDisplayName are called on the file owner objects anyway
and we can get this information often without DB request

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-04-22 17:02:37 +02:00
Robin Appelman
9f0ba3adc2
optimize adding submount info to directory content 
no need to loop when we can do a hashtable lookup

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-04-22 15:50:14 +02:00
Robin Appelman
5e69f98c16
sh 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-04-06 18:08:13 +02:00
Robin Appelman
151c800397
allow reusing known folder info when getting directory contents 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-04-06 14:40:34 +02:00
Côme Chilliet
140624d551
composer run cs:fix 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-04-05 16:47:13 +02:00
Côme Chilliet
d36a1a7bf6 Exit early if $storage is falsy in View::getDirectoryContent 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-04-05 13:58:49 +00:00
Côme Chilliet
916fbe81c6 Fix incorrect if conditions in View 
($something->getPermissions() && Constants::PERMISSION_READ) does not
  make sense as PERMISSION_READ contant is 1 this will always evaluate to
  true.
getPersmissions is returning an int which is a bitwise combination as
  documented in the interface, so it should be used with bit operators.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-04-05 13:58:49 +00:00
Robin Appelman
ff666e648a Add dav plugin to trigger recalculating of checksums 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-03-31 07:44:13 +00:00
Robin Appelman
917c74e214
type fixes 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-03-04 16:30:16 +01:00
Robin Appelman
5c0fe93498
move teardown logic to SetupManager 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-03-04 16:29:50 +01:00
Vincent Petry
4903cb8db4
Merge pull request #29866 from nextcloud/isset-size 
Check if size value is set
 2022-01-17 10:59:52 +01:00
Carl Schwan
6312c0df69
Check style update 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-13 00:19:07 +01:00
Carl Schwan
aeecb72e96
Fix a few psalm issues and moved back to psalm/phar 4.18 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-12 20:03:06 +01:00
acsfer
97e1855ed5
Typo 2021-11-24 11:55:06 +01:00
acsfer
0a0fd33773
Check if size value is set 
Using `isset()` as it does not return true for array keys that correspond to a `null` value, while `array_key_exists()` does.
Fix #29865
 2021-11-23 21:33:28 +01:00
John Molakvoæ
d6152bf98d
Fix psalm 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2021-11-04 10:24:13 +01:00
John Molakvoæ
d6a26b2536
Revert "add dav plugin to trigger recalculating of checksums" 2021-11-01 11:26:17 +01:00
Robin Appelman
fd5e11a81a
Add dav plugin to trigger recalculating of checksums 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-08-23 15:38:58 +02:00
Morris Jobke
2ae60b42ab
Merge pull request #26494 from rigrig/fix-php8-deprecations 
Fix some php 8 warnings
 2021-06-07 23:30:59 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
Richard de Boer
7990f95558 Check whether output buffering is active before turning it off 
Before we just turned it off and @suppressed the error if ob was not active.
In PHP 8 this error is no longer suppressed, so try to not cause it at all.

Signed-off-by: Richard de Boer <git@tubul.net>
 2021-05-29 14:14:52 +02:00
Christoph Wurst
8196420063
Drop \OCP\User 
Inlines and remaining usages and drops the deprecated public API.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-05-21 15:00:34 +02:00
Robin Appelman
f98fed3f8a
reuse usermanager instance when processing search results 
saves some time when processing large search results

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-03-10 19:35:13 +01:00
Julius Härtl
19eb48b8a3
Properly end iterating over the file once the target has been reached 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-02-26 11:29:01 +01:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-16 18:48:22 +01:00
Ashod Nakashian
a66fb45c0b Unlock when promoting to exclusive lock fails 
In certain cases changeLock to EXCLUSIVE fails
and throws LockedException. This leaves the
file locked as SHARED in file_put_contents,
which prevents retrying (because on second
call file_put_contents takes another SHARED
lock on the same file, and changeLock doesn't
allow more than a single SHARED lock to promote
to EXCLUSIVE).

To avoid this case, we catch the LockedException
and unlock before re-throwing.

Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
 2020-11-07 10:31:26 -05:00
Robin Appelman
cfde74442c
optimize View::getPath if we already know the storage id 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-09-16 13:49:07 +02:00
Christoph Wurst
cb057829f7
Update license headers for 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-29 11:57:22 +02:00
Scott Dutton
65e134c13a
Update View.php 2020-04-15 19:10:06 +01:00
Scott Dutton
75b99e85ff
Increase max read 
8kb is very low, especially given this will be local files

Signed-off-by: Scott Dutton <scott@exussum.co.uk>
 2020-04-12 13:01:29 +01:00
Christoph Wurst
caff1023ea
Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Christoph Wurst
14c996d982
Use elseif instead of else if 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 10:35:09 +02:00
Christoph Wurst
42625a46be
Remove spaces after method or function call 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 16:05:56 +02:00
Christoph Wurst
afbd9c4e6e
Unify function spacing to PSR2 recommendation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 13:54:22 +02:00
Christoph Wurst
1a9330cd69
Update the license headers for Nextcloud 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-31 14:52:54 +02:00
Christoph Wurst
b80ebc9674
Use the short array syntax, everywhere 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-26 16:34:56 +01:00
Roeland Jago Douma
3443a00621
Actually check if the owner is not null 
Else this can error out on storages that do not have an owner (e.g.
groupfolders).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-03-16 13:12:10 +01:00
Robin Appelman
fab22ac14c
pass the existing locks info when making locked exception with absolute paths 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-03-02 19:29:44 +01:00
Joas Schilling
08cadf8416
Don't create invalid users 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-02-12 10:55:27 +01:00