upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-03 20:41:22 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 25
79778 commits 651 branches 1179 tags 8.1 GiB
Commit graph

168 commits

Author SHA1 Message Date
Côme Chilliet
a4c48705ee fix: Log missing nodes of shares at debug level 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-12-15 16:59:42 +01:00
Côme Chilliet
2b8075446d fix: Fix orphan shares blocking moving other shares 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-12-15 16:59:42 +01:00
Jonas
10034c4d15 fix(node): emit hooks on Node::copy() 
When calling `Files\Node\Node::copy()`, `Files\View::copy()` gets called,
but `Files\View::fakeRoot` is empty so the hooks are not emitted if no
path is given to `Files\View::shouldEmitHooks()`.

This results in node-related events like `NodeCopiedEvent` not being
fired when copying files via `Files\Node\Node::copy()`.

`Files\View::shouldEmitHooks()` is given a path as parameter in almost
all places except when called from the `copy()` function. This commit
changes it and passes the copy target path.

Fixes: nextcloud/collectives#1756

Signed-off-by: Jonas <jonas@freesources.org>
 2025-05-28 11:49:58 +00:00
Ferdinand Thiessen
832f79ac93
chore: apply code style 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-04-30 19:04:59 +02:00
Marcel Müller
c6ca459b40 fix: No IFactory in constructor 
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
 2025-03-05 11:34:03 +00:00
Joas Schilling
259919e9fd fix(files): Don't do session related work in the constructor of the View 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-03-05 11:34:03 +00:00
Robin Appelman
33fb176651 fix: make locked exception path relative to the view 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-15 14:42:51 +01:00
Louis Chemineau
a663b3e0cd fix(files): Correctly copy the cache information on copy operations 
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-02-13 23:35:59 +00:00
Robin Appelman
5d094feee0
fix: explicitly ignore nested mounts when transfering ownership 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-05 09:09:04 +01:00
Robin Appelman
6cf97e929b
fix: translate mount move error messages 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-05 09:09:03 +01:00
Robin Appelman
68829ad47c
fix: improve checks for moving shares/storages into other mounts 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-02-05 09:08:58 +01:00
provokateurin
5cc14e2618 fix(View): Catch exceptions when executing mkdir for non-existent parents 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-12-17 09:40:42 +00:00
Git'Fellow
2bb8c023c2 fix(files): Check if the target path is a descendant of the shared folder path 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: fix tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: add tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests
 2024-09-06 02:00:43 +00:00
provokateurin
b9aaa9f2e0 fix(files): Create non-existent parents of mountpoints 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-04 18:04:13 +00:00
Ferdinand Thiessen
6ea52ed218 fix: Adjust filename validation messages 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-30 14:48:23 +02:00
Ferdinand Thiessen
ef3bd03849
fix: Allow read-only filename validation to allow reading files 
Needed to read files with the "Windows compatibility" feature.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-28 20:23:54 +02:00
Andy Scherzinger
4f2a29adf9
Merge pull request #46672 from nextcloud/fix/preview-invalid-id 
Avoid using partial file info as valid one
 2024-07-25 19:37:30 +02:00
Julius Härtl
2b0bc8b310 fix: Do not return partial file info if we have a cache entry 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-07-22 22:32:34 +02:00
Ferdinand Thiessen
12796c3ae7
fix: FileInfo from View should have the correct name of a mountpoint 
If a mountpoint is returned from a `View` the name must match the view scoped name
and not the global name.
For example group folders have a name like `1` or `2` (the ID),
but the name of the FileInfo returned fro mthe View should be the mount point name,
like `First groupfolder` or similar.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-22 22:01:12 +02:00
Ferdinand Thiessen
9716b0d735 refactor: Migrate some legacy and core functions to IFilenameValidator 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-19 19:41:46 +02:00
Ferdinand Thiessen
69341e4306
refactor: Migrate filename validation logic from Storage to FilenameValidator 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-16 12:49:09 +02:00
Robin Appelman
d87c23242b
Merge pull request #45014 from nextcloud/forbid-moving-subfolder 
fix: forbid moving a folder into a subfolder of itself
 2024-05-27 14:29:34 +02:00
Andy Scherzinger
dae7c159f7
chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-05-24 13:11:22 +02:00
Robin Appelman
66d36bffa6
fix: forbid moving a folder into a subfolder of itself 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-05-17 17:45:44 +02:00
Julius Härtl
24e0d5023c
fix: Avoid updating size when calling touch on a file 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-05-08 11:50:20 +02:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-02 14:16:21 +02:00
Robin Appelman
afb589a69b
fix: ensure nested mount points are handled in the correct order 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-18 18:13:31 +01:00
Andrew Summers
45eb4a839d Refactor OC\Server::getLockingProvider 
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
 2024-03-15 13:11:33 +01:00
Robin Appelman
96942e436b
fix: update "move into share" check to share manager 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-02-27 14:15:23 +01:00
Côme Chilliet
b2e9e0fa0d chore: Replace OC::$server->getL10N by OCP\Util::getL10N in lib and some apps 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-02-05 11:16:04 +01:00
Julius Härtl
cc75294eb6 perf: Avoid updating the folder size if we know the size difference 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-01-12 14:21:08 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-11-23 10:36:13 +01:00
Robin Appelman
9bc44de95d
reuse sharing disabled state when listing folder content 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-10-19 19:40:52 +02:00
Benjamin Gaussorgues
003d0dec93 Detect aborted connection in OC\Files\View and stop writing data to the output buffer 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-09-07 09:32:32 +02:00
Anna Larch
556f29bef5 fix: don't emit Hooks when hookpaths are empty 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2023-08-17 09:32:14 +02:00
Faraz Samapoor
e7cc7653b8 Refactors "strpos" calls in lib/private to improve code readability. 
Signed-off-by: Faraz Samapoor <fsamapoor@gmail.com>
 2023-05-15 15:17:19 +03:30
Arthur Schiwon
997efe44ff
Merge pull request #37943 from nextcloud/fix/fix-getcontent-return-type 
Fix file_get_content signatures to make it clear it can return false
 2023-05-03 10:34:51 +02:00
Git'Fellow
951c5b973e
Normalize logical operators 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2023-05-02 10:10:02 +02:00
Côme Chilliet
546d94c3ec
Fix file_get_content signatures to make it clear it can return false 
In File::getContent, which must return a string, throw an Exception
 instead of returning false.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-27 09:56:05 +02:00
Côme Chilliet
6633b4ced6
Remove unecessary fully qualified namespaces from phpdoc 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-05 09:13:39 +02:00
Côme Chilliet
5ad045619c
View needs to return an instance of OC\Files\FileInfo explicitely 
Applications are calling methods from the class which are not from the
 public interface, and which cannot be added easily to public interface
 because Node interface extends FileInfo.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:35 +02:00
Côme Chilliet
0b3dad895f
More type cleanup in View and FileInfo 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:35 +02:00
Côme Chilliet
ea05544213
Fix return type of methods returning false on error 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:34 +02:00
Côme Chilliet
4393b96542
Remove unused method getLocalFolder 
It’s not used and not in any OCP interface/class.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:34 +02:00
Côme Chilliet
966a3e6963
Tidy up typing in OC\Files\View 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:33 +02:00
Julius Härtl
d515da502f fix: Use proper path for quota fetching 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-03-06 22:46:07 +00:00
Robin Appelman
5bcf37b7ff only fetch the data for mounts inside a folder when needed 
for most operations we don't actually care about any mounts inside a folder, only for metadata that needs to propagate across storage boundaries (size, etag, mtime) do we need all the submount info.

By only loading this data when needed we can save a bunch of storage setup in a number of cases

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-02-09 11:39:00 +01:00
Côme Chilliet
028c225d96
Fix psalm errors 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:32 +01:00
Côme Chilliet
ff776a90b1
Strong type filesize related methods to ease 32bits problem findings 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:28 +01:00
Côme Chilliet
f5c361cf44
composer run cs:fix 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:45:08 +01:00