upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-15 08:48:14 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 7
78637 commits 688 branches 1185 tags 6.5 GiB
Commit graph

169 commits

Author SHA1 Message Date
Ferdinand Thiessen
832f79ac93
chore: apply code style 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-04-30 19:04:59 +02:00
Joas Schilling
a5e6f46eb0
fix(l10n): Improve english source strings 
- No leading/trailing whitespace
- Use asci single quote

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-02-26 15:06:47 +01:00
Joas Schilling
37948c5127 fix(setupcheck): Update setup check for PHP version to be more accurate 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-02-10 18:46:56 +00:00
Josh
0ea6c5bb9d fix(SetupChecks): Pass webfinger if a handler is there 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2025-01-26 14:40:35 +00:00
Git'Fellow
c38d308aa2 fix(setupchecks): Binary data can have problems with serialize 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2025-01-10 08:02:37 +00:00
Joas Schilling
f12b81534a
fix(setupcheck): Make the Memcache setupcheck use the cache 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-12-19 15:35:04 +01:00
Git'Fellow
09ad3951e3
Merge pull request #49373 from nextcloud/backportArrayKeySetupCheks 
fix(SetupChecks): Make sure array key is set
 2024-11-21 13:08:14 +01:00
skjnldsv
79bf1abb98 fix(settings): psalm PhpMaxFileSize setup check warning 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-11-19 19:05:35 +01:00
skjnldsv
e22f8a8fa2 feat(settings): add big file upload setup checks 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-11-19 16:24:57 +00:00
Git'Fellow
50d071e7d2 fix(SetupChecks): Make sure array key is set 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-11-19 14:11:20 +01:00
Ferdinand Thiessen
77321bc6cf
Merge pull request #47944 from nextcloud/backport/47883/stable30 
[stable30] fix(setup-checks): Ensure URL with webroot works
 2024-09-19 00:19:19 +02:00
Joas Schilling
9371d93249 fix(a11y): Add OTF font loading check 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-09-16 09:26:59 +00:00
Ferdinand Thiessen
71d870d1bd
refactor(settings): CheckServerResponseTrait always expect absolute path 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-15 21:40:27 +02:00
Ferdinand Thiessen
27300ac6ce
fix(setup-checks): Ensure URL with webroot works 
We basically mock the way `URLGenerator::getAbsoluteURL` works,
so we must make sure that the URL might already contain the webroot.
Because `baseURL` and `cliURL` also contain the webroot we need to remove
the webroot from the URL first.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-09-15 21:40:27 +02:00
Côme Chilliet
6830b250b4 fix(setupchecks): Test overwrite.cli url first, then generated one, and 
trusted domains as last fallback.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-05 15:54:56 +00:00
Daniel Kesselberg
ed8759eab8 fix: add option to remove the webroot for setup checks and don't check trusted_domains. 
1) The checks for well-known urls should always run against the root domain and therefore the option to remove the webroot.

2) For trusted domains, the available protocol is unknown, and thus some guesswork would be needed to make that work. I've decided for now to not consider them anymore to reduce false-positives.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-09-05 15:54:56 +00:00
Ferdinand Thiessen
0563757ea4 fix(SetupCheck): Properly check public access to data directory 
When checking for public (web) access to the data directory the status is not enough
as you might have a webserver that forwards to e.g. a login page.
So instead check that the content of the file matches.

For this the `.ncdata` file (renamed from `.ocdata`¹) has minimal text content
to allow checking.

¹The file was renamed from the legacy `.ocdata`, there is a repair step to remove the old one.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-08 22:08:42 +02:00
Git'Fellow
4488714148
Merge pull request #46353 from nextcloud/skipOPcacheCLI 
fix(setupchecks): Skip checking for OPcache settings if running checks from CLI
 2024-08-01 20:02:25 +02:00
Joas Schilling
047479ccf9
feat(security): Add public API to allow validating IP Ranges and checking for "in range" 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-07-19 16:28:03 +02:00
Benjamin Gaussorgues
202e5b1e95
feat(security): restrict admin actions to IP ranges 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-07-19 16:28:03 +02:00
Anna Larch
2201bce7d3 fix(caldav): lower scheduling table size warning 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2024-07-17 11:20:49 +02:00
Git'Fellow
fa84f52c3f
fix: typo 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-07-08 15:11:35 +02:00
Git'Fellow
372c9d2ee6
fix: check both CLI and value 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-07-08 15:09:29 +02:00
Git'Fellow
39f052407a
fix(setupchecks): Skip checking for OPcache if running from CLI 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-07-08 10:43:20 +02:00
Ferdinand Thiessen
8fc498fb82
fix(IntegrityCheck): Ensure the check is run if no results are available 
If there are no cached results the current implementation was also returning an empty array,
but this was the same as when there was a successful run.
So to distinguish this we return `null` if there are *no* results.
In this case we need to rerun the integrity checker.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-03 11:37:49 +02:00
Daniel
02983f3317
Merge pull request #46190 from nextcloud/bug/45047/skip-check-when-disk-free-space-disabled 
fix(setupchecks): skip check when disk_free_space is disabled
 2024-06-29 15:59:17 +02:00
Daniel Kesselberg
fd9fd1b6fb
fix(setupchecks): skip check when disk_free_space is disabled 
Make it easier to discover that the check failed because disk_free_space is disabled.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-06-28 13:06:49 +02:00
Ferdinand Thiessen
6601adcd6d
refactor(SetupCheck): Make mariadb and mysql version variables 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-06-27 16:22:42 +02:00
Ferdinand Thiessen
6e48ca1cf8
fix(settings): Adjust SetupCheck for supported database versions 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-06-27 16:15:16 +02:00
MichaIng
ea994fe8fb
fix(settings): make trailing slash for caldav/carddav redirects optional 
#43939 moved the CalDAV/CardDAV redirect checks from the frontend to a new backend API.

Since the backend does not send an authentication header, checking for the expected response code 207 of the DAV endpoint does not work anymore, hence the URL of the last redirect is checked instead.

This URL is expected to contain a trailing slash, which was not required before, since the DAV endpoint works properly without it (when authenticated).

While a trailing slash in the redirect does no harm, it causes many setups to throw an admin panel warning, while in fact the redirects work properly. Furthermore, the proposed "/.well-known/carddav" => "/remote.php/dav/" redirect leads to double slashes, when doing a request to "/.well-known/carddav/", which seems more wrong then right.

This change makes the trailing slash optional, hence old and adjusted setups won't throw the warning anymore, and the DAV endpoint works well in both cases.

Signed-off-by: MichaIng <micha@dietpi.com>
 2024-06-24 17:52:22 +02:00
Robin Appelman
e74f71b32e feat: add setup check for needed mimetype migrations 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-06-18 14:46:19 +02:00
Andy Scherzinger
ec5b60af28
chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-06-03 20:33:31 +02:00
Anna Larch
ad78f7e48e fix(caldav): automatically delete outdated scheduling objects 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2024-05-31 13:14:01 +02:00
Côme Chilliet
c31d6b1fdc
Merge pull request #45262 from nextcloud/check-HttpsUrlGeneration 
fix(SetupChecks): Detect CLI mode in HTTPS / URL generator check
 2024-05-13 12:06:21 +02:00
Daniel
99f89bb3de
Merge pull request #45242 from nextcloud/check-memcache-memcached 
fix(setupCheck): Only warn when memcache present w/o memcached
 2024-05-13 11:53:27 +02:00
Ferdinand Thiessen
ef320200b9
fix: Move hint about firewall issues to common helper string 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-05-13 09:27:19 +02:00
Julius Härtl
a5fc9b1563
Merge pull request #45272 from nextcloud/check-db-missing-indices 
feat(SetupChecks): Refactor DatabaseHasMissingIndices
 2024-05-13 07:55:39 +02:00
Josh Richards
5b5178abe7 fix(SetupChecks): Detect CLI mode in HTTPS / URL generator check 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2024-05-12 18:09:36 -04:00
Josh Richards
229e5444c9 feat(SetupChecks): Refactor DatabaseHasMissingIndices 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2024-05-11 10:29:42 -04:00
Josh Richards
29157149c8 fix: oops vendor string embedded in version 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2024-05-10 16:41:29 -04:00
Josh Richards
2e94ec8832 fix: only compare major version of pgsql 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2024-05-10 16:41:29 -04:00
Josh Richards
3ce8c6d0db fix: refactor postgresql check to match mariadb/mysql 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2024-05-10 16:41:29 -04:00
Josh Richards
f486be8da1 fix: only compare minor mariadb version differences 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2024-05-10 16:41:29 -04:00
Josh Richards
2abd67cc02 fix(setupChecks): update db version checks 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2024-05-10 16:41:29 -04:00
Josh Richards
c0e395cc0d fix(setupCheck): Only warn when memcache present w/o memcached 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2024-05-09 11:45:16 -04:00
Côme Chilliet
37262c860a
fix(setupchecks): Fix opcache buffer check 
This was broken by last codestyle update, maybe even before because of
 operator precedence. Now using vars to make it readable and correct at
 the same time.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-30 09:23:59 +02:00
Richard Steinmetz
9ef70f0c4e feat: drop support for php 8.0 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2024-04-08 11:28:54 +02:00
Anna
f63c0cf921
Merge pull request #44306 from nextcloud/settings/show-indextoreplace-warning 
fix(settings): show warning for indexToReplace as part of missing indices
 2024-04-05 13:14:43 +02:00
Josh
66fad4ae93 fix(SetupChecks): Add hint about dns/firewall if mjs check can't run 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2024-04-02 18:10:22 +02:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-02 14:16:21 +02:00