Commit graph

14394 commits

Author SHA1 Message Date
Arthur Schiwon
0ba9f046e7 fix(Session): avoid race conditions on clustered setups
- re-stablishes old behaviour with cache to return null instead of throwing
  an InvalidTokenException when the token is cached as non-existing
- token invalidation and re-generation are bundled in a DB transaction now

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-07-11 07:29:09 +00:00
Julius Härtl
ea262a8ca3 perf: Set session.cache_limiter at runtime to avoid clients caching static assets served by PHP
By default there is a Pragma: no-cache header set due to the default
value `no-cache` of session.cache-limiter, which will cause Chrome and
iOS to not cache even with a different Cache-Control header set on the
response.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-07-11 08:31:21 +02:00
Andy Scherzinger
db748b4652
Merge pull request #45919 from nextcloud/backport/45582/stable29
[stable29] delete background jobs by id when cleaning up
2024-07-10 22:05:38 +02:00
Andy Scherzinger
650aec50bf
Merge pull request #46069 from nextcloud/backport/45877/stable29
[stable29] fix: don't use custom certificate bundle if no customer certificates are configured
2024-07-10 20:33:46 +02:00
Andy Scherzinger
0f332839af
Merge pull request #46035 from nextcloud/backport/46017/stable29
[stable29] fix: also use optimized getFirstNodeyIdInPath for Folder::getFirstNodeById
2024-07-10 20:32:36 +02:00
Robin Appelman
7a801f0690 fix: delete background jobs by id when cleaning up
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-10 20:29:36 +02:00
Ferdinand Thiessen
2071f4d713
Merge pull request #46298 from nextcloud/backport/46174/stable29
[stable29] fix(IntegrityCheck): Ensure the check is run if no results are available
2024-07-10 19:01:43 +02:00
Git'Fellow
aa24a4ad5d fix(s3): Don't wait indefinitely for S3 to return
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: lint

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: use AwsException

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Throw on connection failure

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Wrap all in try catch block

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: use RequestTimeout error message

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

log: use OCP Server class

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Handle connect timeout only

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Handle errors more generically

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-09 07:51:43 +00:00
Daniel
ad0d58eeba
Merge pull request #46306 from nextcloud/backport/46276/stable29
[stable29] chore(mp3info): apply upstream patch for invalid array access
2024-07-06 17:16:14 +02:00
Daniel
d4a1710220
Merge pull request #46163 from nextcloud/backport/45876/stable29
[stable29] fix: Avoid throwing errors for teams are unavailable
2024-07-06 14:40:40 +02:00
Daniel Kesselberg
a4bf0f69be
feat: log file id and path when extracting the mp3 cover fails
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>

[skip ci]
2024-07-06 14:24:27 +02:00
Ferdinand Thiessen
57c889f773
fix(IntegrityCheck): Ensure the check is run if no results are available
If there are no cached results the current implementation was also returning an empty array,
but this was the same as when there was a successful run.
So to distinguish this we return `null` if there are *no* results.
In this case we need to rerun the integrity checker.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-05 12:32:39 +02:00
Daniel Kesselberg
4342617dd9 fix(preview): don't create folder structure when previews are disabled
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-07-02 11:51:31 +02:00
Louis Chemineau
1fb0cc25d2
fix(files_sharing): Store the expiration date relative to the server's timezone
This is needed as we want to store the difference between the server's and the user's timezones.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-01 22:23:26 +02:00
Julius Härtl
a3cec03f3a fix: Avoid throwing errors for teams are unavailable
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-06-28 09:51:25 +02:00
Joas Schilling
17434538d4 fix(federation): Fix missing protocol on CloudID remote
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-06-27 13:00:43 +00:00
Louis
a0dc778e14
Merge pull request #45995 from nextcloud/backport/45580/stable29
[stable29] fix: avoid duplicate tag inserts by checking if the mapping exists already in db
2024-06-25 14:06:45 +02:00
Arthur Schiwon
4ccc5905b7
fix(Token): add FILESYSTEM scope with SCOPE_SKIP_PASSWORD_VALIDATION
The scope design requires scopes to be either not specified, or
specified explicitely. Therefore, when setting the
skip-password-validation scope for user authentication from mechanisms
like SAML, we also have to set the filesystem scope, otherwise they will
lack access to the filesystem.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-06-24 16:03:36 +02:00
Robin Appelman
36ba1d8825 fix: don't use custom certificate bundle if no customer certificates are configured
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-24 10:54:05 +00:00
Robin Appelman
bf8a73c539 fix: also use optimized getFirstNodeyIdInPath for Folder::getFirstNodeById
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-21 10:29:52 +00:00
yemkareems
c47432fe49 fix: removed unused variable and check if tag ids are empty before starting the inserts
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-06-20 05:31:55 +00:00
yemkareems
42551c558a fix: filtering tags based on existing tags and doing a transaction around the select and insert
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-06-20 05:31:55 +00:00
yemkareems
6305de4d5a fix: do a select in systemtag_object_mapping to see if tag exists already in db. if it does not exist alone insert the same or else do nothing
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-06-20 05:31:55 +00:00
Robin Appelman
523346e1ff fix: set mimetype_version during upgrade to the old version
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-19 11:33:16 +02:00
Robin Appelman
d3d2488fbb feat: add setup check for needed mimetype migrations
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-19 11:22:49 +02:00
Robin Appelman
0a5983ba9a fix: move repair mimetype repair step to the expensive steps
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-19 11:20:42 +02:00
Robin Appelman
3e56c3d681 feat: add option to disable scanner transactions
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-13 12:02:53 +00:00
Robin Appelman
d1aac3292a fix: get child ids for folder in a separate query during move
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-13 09:46:42 +00:00
Josh
fcdf453b58 fix(ObjectStore): handle empty S3 hostname
Fixes #45637

The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when `hostname` is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated).

Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-06-13 09:37:03 +02:00
Arthur Schiwon
3a17ec6db7
Merge pull request #45809 from nextcloud/fix/noid/fix-new-token-scope-name
[stable29] fix(Token): make new scope future compatible
2024-06-12 19:01:49 +02:00
Arthur Schiwon
fc584b7874
fix(Token): make new scope future compatible
- "password-unconfirmable" is the effective name for 30, but a draft
  name was backported.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-06-12 11:05:43 +02:00
Louis Chemineau
b7cd197315 fix(files): Use isRetryable to catch retryable exceptions
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-12 08:15:08 +00:00
Arthur Schiwon
f0494ec17a fix(Session): avoid password confirmation on SSO
SSO backends like SAML and OIDC tried a trick to suppress password
confirmations as they are not possible by design. At least for SAML it was
not reliable when existing user backends where used as user repositories.

Now we are setting a special scope with the token, and also make sure that
the scope is taken over when tokens are regenerated.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-06-11 20:19:18 +02:00
Ferdinand Thiessen
29ab5d2f52 fix(Mailer): Allow to enforce strict email format
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-07 17:16:21 +02:00
John Molakvoæ
3c392c0913
Merge pull request #45379 from nextcloud/backport/45374/stable29 2024-06-07 12:06:44 +02:00
John Molakvoæ
a0ede5744b
Merge pull request #45476 from nextcloud/backport/45459/stable29 2024-06-07 12:02:30 +02:00
John Molakvoæ
620669d571
Merge pull request #45590 from nextcloud/backport/45413/stable29 2024-06-07 11:59:55 +02:00
Sam Bull
ccfdc97093 fix: regression with updating read-only config
Signed-off-by: Sam Bull <git@sambull.org>
2024-06-07 11:03:47 +02:00
John Molakvoæ
8ed2df80c2
Merge pull request #44988 from nextcloud/backport/44973/stable29 2024-06-07 11:03:00 +02:00
John Molakvoæ
6c27d57e0d
Merge pull request #44894 from nextcloud/backport/44644/stable29 2024-06-07 11:01:38 +02:00
Christoph Wurst
ce339b327f fix(auth): Update authtoken activity selectively
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-06-06 14:39:46 +02:00
Julius Härtl
c647f89296 fix: Always set last activity if we update the row of an authtoken anyways
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-06-06 14:39:46 +02:00
Kate
f530773f24
Merge pull request #45645 from nextcloud/backport/45455/stable29 2024-06-06 12:52:03 +02:00
Joas Schilling
6ea06e1b11
Merge pull request #45602 from nextcloud/backport/44670/stable29
[stable29] fix(session): Do not update authtoken last_check for passwordless
2024-06-06 12:34:47 +02:00
Christoph Wurst
8f9a0f8fdc fix(session): Do not update authtoken last_check for passwordless
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-06-03 22:54:50 +02:00
provokateurin
3d2b63c057 fix(NavigationManager): Make entry order always an integer
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-06-03 15:12:32 +00:00
Anna Larch
ec94f5499c fix(caldav): automatically delete outdated scheduling objects
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-06-03 11:10:03 +00:00
F. E Noel Nfebe
806e390d14
Merge pull request #45483 from nextcloud/backport/44485/stable29
[stable29] Respect empty `expiryDate` value in server
2024-05-31 13:12:09 +01:00
Git'Fellow
eec6816d49 Try create folder first and check if it exists after
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-05-30 18:29:20 +00:00
Git'Fellow
75883cb4d9 fix(files): Try to create dir only if it not exists
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-05-30 18:29:20 +00:00