Commit graph

31013 commits

Author SHA1 Message Date
fenn-cs
0bee2a6fca fix(shareManager): Respect empty expireDate in server
If `expireDate` is an empty string and not `null` then the server should not set a default.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-13 18:34:51 +02:00
Robin Appelman
0ab1cc5f17 refactor: make share manager buildable
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-13 18:34:51 +02:00
John Molakvoæ
683ae3c2fd
Merge pull request #45836 from nextcloud/backport/45251/stable28
[stable28] fix(files): do not rely on unique fileid
2024-06-13 10:33:43 +02:00
skjnldsv
6f6f1ad2ed fix(files): fetch nodes if we have multiple of the same fileid in the store
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-13 09:28:34 +02:00
skjnldsv
e1248947fb fix(files): do not rely on unique fileid
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-13 09:28:34 +02:00
F. E Noel Nfebe
857b208c14
Merge pull request #45303 from nextcloud/backport/44464/stable28
[stable28] 44032 fix show new shares without refresh
2024-06-13 01:23:44 +01:00
Nextcloud bot
7c657e205f
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-06-13 00:20:05 +00:00
fenn-cs
013768a9bc fix(files_sharing): Improve recursion in onNewLinShare
These changes fixes the issue of having the refresh the UI after share creation, as the share is not
immediately removed from the UI list.

Important changes

- The basis of checking wether a password/expire date is no longer based on config values alone
because the config is not expected in a share creation circle. Hence we check the configs and check
if the share object (this.share) has the expected values set. This way, once the required properties
are set, code control does not enter the block meant to handle the setting of required properties
unneccessarily.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-13 00:18:54 +01:00
fenn-cs
2b62e1794c refactor(ShareDetails): Prevent undefined errors for share.permissions
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-12 23:08:07 +01:00
Arthur Schiwon
9943f3ba46
Merge pull request #45774 from nextcloud/backport/45347/stable28
[stable28] fix: Only list remnants as disabled if option is enabled
2024-06-12 19:52:39 +02:00
John Molakvoæ (skjnldsv)
63ca843105 fix(files): also trigger new tab on file name middle click
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-06-12 14:41:39 +00:00
skjnldsv
f1f2f5ca98 fix(files_sharing): dark avatar support
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 13:30:16 +02:00
skjnldsv
14c1b53b56 fix(dav): also return shared-with-me shares data
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 13:23:39 +02:00
skjnldsv
d991eaed92 fix(files_sharing): fix parsing of remote shares
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 13:23:39 +02:00
Sanskar Soni
cc09bcf19e fix(files): handling numbered type owner name & id
Signed-off-by: Sanskar Soni <sanskarsoni300@gmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-06-12 09:49:47 +00:00
Côme Chilliet
cade682752
fix: Only list remnants as disabled if option is enabled
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-12 09:59:22 +02:00
John Molakvoæ (skjnldsv)
b967dcc041
fix(files): reset menu pos when opening in grid mode
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-06-12 09:55:38 +02:00
Andy Scherzinger
21ef938fbc
Merge pull request #45799 from nextcloud/backport/45775/stable28
[stable28] fix(caldav): event links in shared calendar notifications
2024-06-12 09:08:25 +02:00
Nextcloud bot
88f2a30931
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-06-12 00:20:20 +00:00
Richard Steinmetz
051d94117f fix(caldav): event links in shared calendar notifications
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-06-11 18:42:56 +00:00
skjnldsv
3a11a49e48 fix(search): tags redirect route
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-11 16:56:43 +02:00
Louis Chemineau
71188dc3f2
test: Fix encryption test
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-06-11 11:53:57 +02:00
Côme Chilliet
9026c98243 fix: add default value for new flag $useDecryptAll on getFileKey
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-06-11 08:35:51 +00:00
Côme Chilliet
92e053aab3 fix: Autodetect legacy filekey instead of trusting the header for legacy header
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-06-11 08:35:51 +00:00
John Molakvoæ
436663f3c7
Merge pull request #44912 from nextcloud/backport/44838/stable28 2024-06-11 09:44:08 +02:00
Nextcloud bot
974c9f2e09
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-06-11 00:19:46 +00:00
Ferdinand Thiessen
892f17a7a8
feat(cypress): Add tests for files sidebar
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-10 18:11:45 +02:00
Ferdinand Thiessen
3808a5b056
fix(files): Update current fileid in route if that node was deleted
We do not change the view to the trash bin but stay in the current view,
so we need to update the current fileid on the route if that was deleted.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-10 17:48:09 +02:00
Ferdinand Thiessen
3c74559e4c
fix(files): Close sidebar if shown node is deleted
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-10 17:48:09 +02:00
Joas Schilling
c57df2777a fix(dav): Don't log access control as error
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-06-10 11:57:00 +00:00
Benjamin Gaussorgues
2691ceb575
Merge pull request #45727 from nextcloud/backport/45611/stable28 2024-06-10 11:42:25 +02:00
Joas Schilling
4d748b9f5a fix(sharing): Don't change the type of the controller argument
[EA] New value type (\DateTime) is not matching the resolved parameter type and might introduce types-related false-positives.

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-10 09:10:29 +01:00
fenn-cs
3c507773b7 fix(shareApiController): avoid duplicated expiryDate operations
`expireDate` can be set once and used anywhere needed, the current implementation,

duplicates this behavior which leads to `parseDate` receiving an a date object it

parsed and returend earlier in the createShare method.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-10 09:08:02 +01:00
fenn-cs
30900ae751 refactor(shareApiController): use contrusctor property promotion & DI logger
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-10 09:08:02 +01:00
Nextcloud bot
0ac234c4e8
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-06-10 00:19:53 +00:00
Nextcloud bot
09abd43ee0
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-06-09 00:19:35 +00:00
Ferdinand Thiessen
280a9bdd21 fix(files): Ensure that focussed file is always scrolled right
Ensure the correct file is scrolled if the content changes,
this also sets a minimal height to the virtual scrolling area
so that the `scrollTop` can be set.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:09:18 +00:00
Ferdinand Thiessen
e6fc2e4a82 fix(files): Keep query when trigger the sidebar action
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:09:18 +00:00
Ferdinand Thiessen
684c067511 fix(files): open-in-files action should also set openfile query
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:09:18 +00:00
Ferdinand Thiessen
5b1969b0f5 refactor(files): Fix TypeScript issues in FileEntryActions
* We filter the array in `enabledSubmenuActions` so we can be sure the action does have a parent
* Node attributes must be accessed using the `attributes` getter not the private `_attributes` property
* Cast action ref to correct component interface to make TypeScript happy

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:09:18 +00:00
Nextcloud bot
2770a56bb9
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-06-08 00:19:27 +00:00
John Molakvoæ
aac7d33865
Merge pull request #45542 from nextcloud/backport/44664/stable28
[stable28] fix(dav): Rate limit address book creation
2024-06-07 13:42:33 +02:00
Hamza Mahjoubi
aafab6987b fix(dav): Rate limit address book creation
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2024-06-07 12:14:42 +02:00
John Molakvoæ
bf904e7faf
Merge pull request #44010 from nextcloud/backport/43252/stable28 2024-06-07 12:14:11 +02:00
John Molakvoæ
1aeb49e74f
Merge pull request #45110 from nextcloud/backport/45105/stable28 2024-06-07 12:01:47 +02:00
Christopher Ng
0fd69a6851 fix(files): Display selected files count
Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit a999544ff2)
2024-06-07 11:24:03 +02:00
Nextcloud bot
bf4d2ec50b
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-06-07 00:35:32 +00:00
skjnldsv
d7f3dc390b fix(federatedfilesharing): import external federated share script
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-06-06 12:59:32 +00:00
Louis Chemineau
6fb0ac6116 fix(files_sharing): usage of NcTextField in SelectShareFolderDialogue
The NcTextField needs a value property to be set.

Signed-off-by: Louis Chemineau <louis@chmn.me>

[skip ci]
2024-06-06 10:20:37 +00:00
Nextcloud bot
c114b362c3
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-06-06 00:21:06 +00:00