Commit graph

6398 commits

Author SHA1 Message Date
fenn-cs
0bee2a6fca fix(shareManager): Respect empty expireDate in server
If `expireDate` is an empty string and not `null` then the server should not set a default.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-13 18:34:51 +02:00
Robin Appelman
0ab1cc5f17 refactor: make share manager buildable
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-13 18:34:51 +02:00
fenn-cs
013768a9bc fix(files_sharing): Improve recursion in onNewLinShare
These changes fixes the issue of having the refresh the UI after share creation, as the share is not
immediately removed from the UI list.

Important changes

- The basis of checking wether a password/expire date is no longer based on config values alone
because the config is not expected in a share creation circle. Hence we check the configs and check
if the share object (this.share) has the expected values set. This way, once the required properties
are set, code control does not enter the block meant to handle the setting of required properties
unneccessarily.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-13 00:18:54 +01:00
fenn-cs
2b62e1794c refactor(ShareDetails): Prevent undefined errors for share.permissions
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-12 23:08:07 +01:00
skjnldsv
f1f2f5ca98 fix(files_sharing): dark avatar support
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 13:30:16 +02:00
skjnldsv
d991eaed92 fix(files_sharing): fix parsing of remote shares
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 13:23:39 +02:00
John Molakvoæ
436663f3c7
Merge pull request #44912 from nextcloud/backport/44838/stable28 2024-06-11 09:44:08 +02:00
Joas Schilling
4d748b9f5a fix(sharing): Don't change the type of the controller argument
[EA] New value type (\DateTime) is not matching the resolved parameter type and might introduce types-related false-positives.

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-10 09:10:29 +01:00
fenn-cs
3c507773b7 fix(shareApiController): avoid duplicated expiryDate operations
`expireDate` can be set once and used anywhere needed, the current implementation,

duplicates this behavior which leads to `parseDate` receiving an a date object it

parsed and returend earlier in the createShare method.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-10 09:08:02 +01:00
fenn-cs
30900ae751 refactor(shareApiController): use contrusctor property promotion & DI logger
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-10 09:08:02 +01:00
Ferdinand Thiessen
684c067511 fix(files): open-in-files action should also set openfile query
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-08 15:09:18 +00:00
John Molakvoæ
bf904e7faf
Merge pull request #44010 from nextcloud/backport/43252/stable28 2024-06-07 12:14:11 +02:00
Louis Chemineau
6fb0ac6116 fix(files_sharing): usage of NcTextField in SelectShareFolderDialogue
The NcTextField needs a value property to be set.

Signed-off-by: Louis Chemineau <louis@chmn.me>

[skip ci]
2024-06-06 10:20:37 +00:00
Nextcloud bot
a62a1faf3b
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-06-05 09:56:25 +00:00
Ferdinand Thiessen
dc1ca39f0f fix(deps): Update @nextcloud/event-bus to version 3.3.1
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-31 15:38:45 -07:00
Git'Fellow
1a50eb42e8 Fix backport
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-05-29 10:55:28 +02:00
Christoph Wurst
64469efa29 fix(sharing): Avoid (dead)locking during orphan deletion
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>

[skip ci]
2024-05-29 10:55:28 +02:00
Nextcloud bot
2967c21465
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-05-08 00:21:13 +00:00
Nextcloud bot
bae9e2e6e1
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-05-07 00:20:24 +00:00
Nextcloud bot
d1a0b1946c
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-05-03 00:20:05 +00:00
Côme Chilliet
369247338b
Merge pull request #44500 from nextcloud/backport/44484/stable28
[stable28] fix(share): Send correct share attributes upon share creation
2024-04-29 15:25:21 +02:00
Nextcloud bot
4be7b83426
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-27 00:20:28 +00:00
fenn-cs
bbb28fd483 fix(share): Send correct share attributes upon share creation
- Send correct share attributes (`share.attributes`) to server upon creation.

- Delete parts of code that create or reference, `share.hasDownloadPermission`

(Not required by Share API)

Resolves : https://github.com/nextcloud/server/issues/44131

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-04-26 20:59:57 +01:00
Nextcloud bot
4006d9961e
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-26 00:21:20 +00:00
Nextcloud bot
93c8d1df3b
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-25 00:21:04 +00:00
Nextcloud bot
fc8bbf6154
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-24 00:20:37 +00:00
Nextcloud bot
7da3f87817
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-23 00:21:02 +00:00
Nextcloud bot
a7b52f82f9
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-22 00:21:18 +00:00
Nextcloud bot
1cb891c8fd
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-21 00:20:48 +00:00
Nextcloud bot
8acbcf5edb
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-20 00:20:22 +00:00
Nextcloud bot
7fca7ff774
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-19 00:20:45 +00:00
Nextcloud bot
243a98adb6
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-18 00:20:50 +00:00
Nextcloud bot
2001e14157
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-17 00:21:00 +00:00
fenn-cs
713f2667c1 fix(share): Send empty expireDate when not expireDate set
When creating a new share, if the user unchecks "Set expiry date"

no `expireDate` is sent to the server.

However, the server then assumes the default configured, hence better

to send an empty value.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

[skip ci]
2024-04-16 09:51:39 +01:00
Nextcloud bot
90e68f0ff5
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-05 00:20:06 +00:00
Nextcloud bot
6f353f3919
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-04 00:20:23 +00:00
Nextcloud bot
be17be68f0
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-03 00:20:05 +00:00
Ferdinand Thiessen
697dafaabc
fix(files_sharing): Disable autocomplete for share label and password
Prevent browsers - as good as possible - from filling in user credentials as share label and password.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-02 14:10:19 +02:00
Nextcloud bot
0e290ca9a2
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-02 00:19:47 +00:00
Nextcloud bot
8db8c615d0
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-04-01 00:19:50 +00:00
Nextcloud bot
b5e233eb95
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-03-31 00:19:49 +00:00
Nextcloud bot
cfe54be838
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-03-30 00:20:48 +00:00
Ferdinand Thiessen
237e78c84e fix(files_sharing): Create passwords when enforced for mail shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-29 14:36:02 +00:00
Nextcloud bot
724a62daee
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-03-29 00:24:46 +00:00
Nextcloud bot
b9bd149534
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-03-28 00:19:17 +00:00
Nextcloud bot
49a2efe22c
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-03-27 00:20:21 +00:00
Nextcloud bot
e54a0e1ca4
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-03-26 00:19:32 +00:00
Stephan Orbaugh
08444f45f1
Merge pull request #44320 from nextcloud/backport/39990/stable28
[stable28] add some recrusive detection/prevention
2024-03-25 15:27:27 +01:00
Robin Appelman
93dc9fca32 fix: add extra check to ensure wrapped shared storage is set
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-22 19:46:00 +00:00
Robin Appelman
7d98e83e3f
fix: add some recrusive detection/prevention
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-22 17:17:57 +01:00