Commit graph

668 commits

Author SHA1 Message Date
Ferdinand Thiessen
d4685cb036 fix(files): Ensure renaming state is correctly reset
Problem: Is a node is renamed and the new name is out of the current
visible list of nodes the component will be recycled, this means
the props will change, so when the `onRename` functions is about to reset
the state the `this.source` will point to a different node.

To fix this, but also to separate business logic from visual representation,
the logic is moved into the renaming store and the component is only
responsible for rendering.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-21 13:53:08 +02:00
Ferdinand Thiessen
7b78a64fa8
test(files): Add tests for path handling
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 17:54:13 +02:00
Ferdinand Thiessen
c7d22f9773
fix(files): Ensure children are removed from folder and not duplicated
* Resolves https://github.com/nextcloud/server/issues/47904

We need to make sure that we only add one source (unique!) once as a child,
this is ensured by simply use a native `Set`.
Also we need to remove children on from folders when the `files:node:deleted`
event is emitted.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 16:25:24 +02:00
Ferdinand Thiessen
64cc7afb12 fix(files): Add more visual move / copy notification
* Resolves: https://github.com/nextcloud/server/issues/46645

This adds loading toast notification while the move operation is running.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 15:02:15 +02:00
Ferdinand Thiessen
f8bb7c8b4d
fix(files): Make openMenu watcher null safe
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 14:27:30 +02:00
Ferdinand Thiessen
be33321059
fix(files): Reset context menu position on close
* Resolves https://github.com/nextcloud/server/issues/46934

Ensure that after a right-click the context menu position is resetted,
so that pressing the "actions"-menu button it is displayed on the correct location.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 14:27:30 +02:00
Christopher Ng
56953f4315 fix(files): Fix folders not being selectable in the smart picker
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-10-02 09:09:04 +00:00
Louis Chemineau
17ec9a2317 fix: Show storage full warning when storage is actually full
< 0 values for "free" do not mean that the storage is full: 6befdd6dd7/lib/public/Files/FileInfo.php (L31-L42)

Signed-off-by: Louis Chemineau <louis@chmn.me>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-09-26 08:58:26 +00:00
Christopher Ng
88687a8223 fix(files): Fix having to resolve conflicts twice when dropping files
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-09-25 14:25:58 -07:00
rakekniven
e35dca0972
fix(translations): Changed grammar
[skip-ci]

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-09-23 16:09:38 +02:00
Louis Chemineau
ae70a426ac feat: Reset route if neither the Viewer of the Sidebar is open
When the viewer or the sidebar is opened, we add the fileid to the route.
When both of them are closed, we do not remove the fileid from the route.
This means that, upon reload, the sidebar will be opened even though it was closed previously.

This PR ensure that the fileid is removed from the route when both the Sidebar and the Viewer are closed.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-16 11:18:13 +02:00
Christopher Ng
0376f18ca9 fix(files): Render folders in natural sort order
- Nodes are returned from the endpoint in an undefined order

Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-09-10 14:24:27 -07:00
Christopher Ng
f88a84208c fix(files): Sort tree views correctly by natural order
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-09-10 14:24:23 -07:00
skjnldsv
2393b855ab fix(files): undefined displayname for outdated @nextcloud/files<3.6.0 apps
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-09-05 07:23:42 +02:00
skjnldsv
a1902abf75 fix(files): undefined sidebar
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-09-04 14:57:26 +00:00
Christopher Ng
6897622546 fix(files): Fix navigating with breadcrumbs not highlighting navigation entry
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-09-03 11:44:30 -07:00
Ferdinand Thiessen
b4b93d6bcd fix(files): Node loading information should be accessible
The loading icon visually informs that the node is currently loading,
but there is no non-visual information (accessible information).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-01 11:48:05 +02:00
Christopher Ng
94fbcf3d53 test(files): Adapt favorite views spec
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-29 11:54:22 -07:00
Christopher Ng
3eca671c36 feat(files): Allow more than 50 favorite views
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-29 11:54:22 -07:00
Louis Chemineau
edb05e6a70
fix(files): Remove margin and width to not break layout
In grid view, this was messing with the reported available list width which was breaking the computed layout.

Fix https://github.com/nextcloud/server/issues/47599

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-08-29 17:16:08 +02:00
Ferdinand Thiessen
bc3d7a00b0 fix(files): Correctly check for already used names when creating new folder
Also add Cypress tests for the "new"-menu.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-29 15:33:26 +02:00
Elizabeth Danzberger
1d9066cc68 fix: use empty template by default when pressing enter
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-08-29 14:16:25 +02:00
Christopher Ng
2908674ddd
refactor(files): Consolidate node registration
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-29 11:31:00 +02:00
Christopher Ng
97b2f97f94
refactor(files): Organize event subscriptions
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-29 11:31:00 +02:00
Christopher Ng
957f7c113e
fix(files): Respect "Show hidden files" setting in tree
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-29 11:30:56 +02:00
Elizabeth Danzberger
905adcaeb8 feat(templates): add support for checkboxes in template filler
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-08-29 05:26:58 +00:00
Ferdinand Thiessen
183fcef39b
fix: Renaming does not need update but delete permissions
Renaming is basically copy + delete (a move), so no need to update permissions.
Especially if the node is in a invalid directory the node should be moveable but not editable.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 20:23:50 +02:00
Andy Scherzinger
b6096d2a22
Merge pull request #47499 from nextcloud/backport/47490/stable30
[stable30] chore(files): Adjust wording for file type filter
2024-08-28 12:15:52 +02:00
Ferdinand Thiessen
ceebf2df6a
fix(files): Remove huge margin on bottom
Instead make it relative to screen size.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-27 23:16:05 +02:00
Elizabeth Danzberger
c84cd0415e
fix(files): fix list gap at bottom
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-27 12:41:19 -04:00
Ferdinand Thiessen
08391ee642 chore(files): Adjust wording for file type filter
* Resolves: https://github.com/nextcloud/server/issues/47440

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-26 19:42:16 +00:00
Ferdinand Thiessen
fc64d5c838 fix(files): Reset drop notice on firefox
On firefox there is an old bug where when you move a dragged file outside
the window the `dragleave` event is never emitted.
So we just use a timeout to reset the drag over state.

Also a small change: Use the ID of the main container instead of relying on tag name and class.
(The ID is guranteed as other APIs rely on it, while the class is just used internally).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-26 19:03:42 +00:00
Ferdinand Thiessen
0b29811e08 fix(files): Move loading icon before grid toggle
This prevents jumping of that toggle button when the view is loading.
Also adjust the design for Nextcloud 30 (prevent jumping of breadcrumbs when loading due to increased height).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-21 17:38:19 +02:00
Ferdinand Thiessen
57bd5d06c1 fix: Access node owner by top level owner property
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-17 16:31:24 +00:00
Ferdinand Thiessen
ee4fb148b3 perf(files): Cache getContents function used for uploader
Instead of trigger a PROPFIND for every new-menu entry clicks,
or conflict handling of uploads, we can just use the cached content from the file store.
If we do not have any cache entry we fetch new, but otherwise this is not needed.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-14 09:47:56 +02:00
Ferdinand Thiessen
7fec706f68 refactor(files): Drop unneeded initial state
The initial state is no longer used, it was only used in legacy UI and in the f2v rewrite
it was only used for the `id` which can be loaded just from the URL.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-14 09:31:27 +02:00
Christopher Ng
0c0ba5f552 fix(files): Fix non-sticky sticky views in files nav
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-14 07:27:49 +00:00
rakekniven
b030449ad1 chore(i18n): Improved grammar
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-14 07:18:27 +00:00
Ferdinand Thiessen
ea021df9fa
chore(deps): Update @nextcloud/auth to v2.4.0 and use getCSPNonce where possible
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-13 17:54:47 +02:00
Ferdinand Thiessen
58acf4c608 fix(files): Add messages when "new folder" fails or gets cancelled
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-13 10:31:07 +02:00
Christopher Ng
a3ad8daed6 perf(files): Prevent extraneous requests when tree children are loading
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-09 15:32:17 -07:00
skjnldsv
e4e12a35f5 fix(files): trim names on new node creation
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-09 11:58:37 +00:00
Konstantin Myakshin
81ee1ce8fc fix(files): Disable tags editing for shared files/folders with view only permission
Signed-off-by: Konstantin Myakshin <molodchick@gmail.com>
2024-08-09 11:42:28 +02:00
Christopher Ng
44bc57bc57 feat: Load limited depth tree
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-08 11:15:52 -07:00
Christopher Ng
cfec6fcb1a feat(files): Add getter for all view configs
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-08 10:52:20 -07:00
Christopher Ng
86459aa5da perf(files): Remove redundant call to get navigation
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-08 10:52:20 -07:00
skjnldsv
827c6fdda9 fix(files): file name and header sort buttons alignments
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-07 15:12:32 +00:00
skjnldsv
40d9b42c84 fix(files): use files:config:updated to monitor user config change
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-08-07 10:50:33 +00:00
Ferdinand Thiessen
066bd0a25d
fix(files): openfile is set on the query not as a param
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-03 13:52:12 +02:00
skjnldsv
760c37b52e fix(files): show folder sharing overlay on received shares
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-08-02 16:52:12 +00:00