Commit graph

207 commits

Author SHA1 Message Date
Côme Chilliet
e51d20479e
Check limit and offset parameters sent to controller
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-10 10:43:18 +02:00
Côme Chilliet
afcebd1e92
Fix api description for Users#getDisabledUsers
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-09 14:50:12 +02:00
Côme Chilliet
cac3d465f0 Remove psalm @var annotations which should not be needed
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-09 12:04:35 +02:00
Côme Chilliet
a1255539b8 Add endpoint for getting disabled user list
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-09 12:04:35 +02:00
jld3103
c2d45cb172
Add single status code descriptions for OpenAPI
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-09-27 08:05:21 +02:00
Joas Schilling
0956b493b6
fix(phonenumber): Use the newly introduced API to limit 3rdparty lib usage
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-09-25 15:54:21 +02:00
jld3103
38db3873a2
provisioning_api: Add OpenAPI spec
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-07-31 10:29:08 +02:00
Joas Schilling
4809e8d9a9
fix(CI): Satisfy psalm by removing a now obsolete type check
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-31 15:42:15 +02:00
Christoph Wurst
1381c4c157
feat(users): Store and load a user's manager
Co-Authored-By: hamza221 <hamzamahjoubi221@gmail.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-12 13:56:48 +02:00
Joas Schilling
1c0aae9c54
fix(provisioning_api): Don't allow to configure the same additional email multiple times
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-26 08:41:37 +02:00
Christopher Ng
7bc8b543be Improve handling of profile fields
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-03-30 17:11:41 -07:00
Julien Veyssier
c838bdb820
Merge pull request #36665 from nextcloud/fix/36539
Always set displayname and display-name for user data
2023-03-22 15:21:29 +01:00
Julius Härtl
3287eddbbc fix: Recalculate storage statistics on updating the quota
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-03-06 22:46:07 +00:00
jld3103
77f7da9921
Always set displayname and display-name for user data
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-02-10 21:52:54 +01:00
Joas Schilling
b4a29644cc
Add a const for the max user password length
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-04 11:23:43 +01:00
Carl Schwan
d1209d8302 Rename mastodon to fediverse
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-22 08:40:12 +01:00
Carl Schwan
86d9626901 Add mastodon personal info field
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-21 16:28:56 +01:00
Joas Schilling
ab055418c6
Fix password length limitation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-10 12:33:58 +02:00
Christopher Ng
8a15c629e2 Fix translation of user exists error server-side
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-09-15 22:56:18 +00:00
luz paz
9d26671f05 Fix typos in apps/ subdirectory
Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`

Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-09-05 12:59:54 +00:00
Christopher Ng
d59585974e Fix creation of new user and display the correct error message
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-08-22 19:13:11 +00:00
Christopher Ng
c0868f93f1 Do not save invalid display name to the database
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-28 18:03:15 +00:00
Joas Schilling
3235785c24
Fix exception handling when profile data is too long
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-06-09 22:07:46 +02:00
Christopher Ng
309354852f Profile backend
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-10-19 04:59:35 +00:00
Christopher Ng
7215148a24 Add new account properties
- New properties
  - Organisation
  - Role
  - Headline
  - Biography
  - Profile Enabled property
- Fix errors with building default account properties
- Fix L10N factory method `getLanguage` not public error
- Update tests

Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-10-19 04:44:40 +00:00
Arthur Schiwon
763136ab48
also allow admins to set the primary email
- there will be times when it is necessary to reset this value for sure

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:05 +02:00
Arthur Schiwon
27865d03c0
use specific email getter where necessary
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:05 +02:00
Arthur Schiwon
4461b9e870
enable the user to set a primary (notification) email address (backend)
- specific getters and setters on IUser and implementation
- new notify_email field in provisioning API

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:04 +02:00
Arthur Schiwon
aacaad2a3f
implement verification for additional mails
- mails added by (sub)admins are automatically verified
- provisioning_api controller as verification endpoint
- IAccountProperty gets a locallyVerified property
- IPropertyCollection gets a method to fetch an IAccountProperty by value
  - an remove equivalent was already present
- AccountManager always initiates mail verification on update if necessary
- add core success template for arbitrary title and message

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 14:03:35 +02:00
Julien Veyssier
416d10f76c refs #21045 add app config to disable unlimited quota and to set max quota
avoid unlimited quota as default_quota fallback value if unlimited quota is not allowed
avoid getting/setting/displaying unlimited default quota if not allowed
implement tests for unlimited quota restrictions

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-29 19:31:36 +00:00
Gary Kim
b78f3a57d1
Migrate HintException to OCP
Signed-off-by: Gary Kim <gary@garykim.dev>
2021-06-30 15:28:02 -04:00
Arthur Schiwon
ad0a11b2bf
cleanup
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 01:03:44 +02:00
Arthur Schiwon
a0752543d8
fix small issues in UsersController handling
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:48:05 +02:00
Arthur Schiwon
00ffad3c60
adjust access permissions of new controller method
- fixes wrong veriable usage also

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:48:05 +02:00
Arthur Schiwon
02808e38b4
create a property on editUser when it was not set before
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:47:43 +02:00
Arthur Schiwon
d109d4f581
prov api to be able to edit multivalue properties
- adding as usual
- deleting and scope setting via additional endpoint

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:11 +02:00
Arthur Schiwon
3da9064f9d
prov api reports multiple mail as editable field
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:11 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +02:00
Joas Schilling
94584ee788
Fix the get editable fields endpoint without a user id
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-27 14:23:04 +02:00
blizzz
0ab5b3e265
Merge pull request #26679 from nextcloud/bugfix/noid/fix-unauthorized-ocs-status-in-provisioning
Fix unauthorized OCS status in provisioning
2021-05-13 23:39:20 +02:00
Joas Schilling
b6c6527705
Fix unauthorized OCS status in provisioning
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 08:16:07 +02:00
Arthur Schiwon
8413ed9475
allow to set valid scopes only in AccountProperty
the auto-fallback to v2-local is removed as well to react on wrong input

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-12 01:31:15 +02:00
Arthur Schiwon
1e271e9f76
provAPI to use only public API of IAccountManager
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-08 01:20:17 +02:00
Joas Schilling
03b467bd23
Also check implementsAction method
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 15:28:02 +02:00
Joas Schilling
f67a10e8d0
Only return display name as editable when the user backend allows it
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 15:01:30 +02:00
Joas Schilling
2f99ae1120
Also check the default phone region when the number has no country code
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 08:45:32 +02:00
Vincent Petry
2a312fe4e3
Expose avatarScope through provisioning API
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:09 +01:00
Vincent Petry
266a6fb5f8
OCS allow reading and writing account property scopes
Extends the provisioning API to allow a user to get and set their own
account property scopes.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +01:00
Vincent Petry
5d14fd4396
Make extra user profile fields always editable
The fields for phone number, address, website and twitter are now
editable regardless whether federated sharing and the lookup server
are enabled or not.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +01:00
Joas Schilling
5c3551cf2f
Only clear known users when we had at least one phonebook entry
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-12 09:04:13 +01:00
Joas Schilling
61ed57b757
Rename some parameters and methods to make the API more clear
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 20:30:29 +01:00
Joas Schilling
c7be18c0d6
Add a service to find out if a user knows another user
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:19:55 +01:00
Joas Schilling
55a5d26c56
Delete matches when a user changes their phone number
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 15:05:48 +01:00
Joas Schilling
f62d9b50fd
Store when a user knows another user based on phone number
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 15:05:48 +01:00
Roeland Jago Douma
128b682b7c Fixed error after merge in UsersController
This was moved to the LoggerInterface so the recent merge of #25589
broke master.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-05 09:14:01 +01:00
Roeland Jago Douma
4a9f3ef232
Merge pull request #25589 from nextcloud/provisioning-api-invalid-argument
forward invalid argument message to frontend when creating a user fails
2021-03-05 08:59:50 +01:00
Roeland Jago Douma
cc744740b7 Remove deprecated \OCP\API
Time to remove this forgood now.
Remaining constant moved over
The world is a tiny bit better

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 20:54:32 +01:00
Roeland Jago Douma
dc7eb2bd85 LoggerInterface for provisioning API Controllers
Sweep swoop swaap swuup
away with the deprecated stuff

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 21:46:51 +01:00
Robin Appelman
c6ce1eb557
forward invalid argument message to frontend when creating a user fails
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-11 17:05:51 +01:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +01:00
Joas Schilling
d0750df20c
Unit tests for searching by phone number
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +01:00
Joas Schilling
f648635758
Make the throwing optional, so background tasks don't break
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +01:00
Joas Schilling
9e04e6f99a
Also translate the phone number when coming in via the accounts manager API directly
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +01:00
Joas Schilling
fe9c46e595
Add an endpoint to search for accounts based on phone number
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +01:00
Joas Schilling
da9462b482
Make code strict
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +01:00
Morris Jobke
0f7fb7cb4e
Merge pull request #23189 from nextcloud/enhancement/cs/binary_operator_spaces
Format code to a single space around binary operators
2020-10-05 21:31:38 +02:00
Christoph Wurst
d9015a8c94
Format code to a single space around binary operators
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +02:00
Sujith Haridasan
62923a5e1e Fix the user email issue while creating a user
When the user is created, the provisioning api
was not adding the email address of the user
when provided if the `send email to new user`
is not set.

Signed-off-by: Sujith Haridasan <sujith.h@gmail.com>
2020-10-05 16:47:57 +05:30
Christoph Wurst
2a054e6c04
Update the license headers for Nextcloud 20
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +02:00
Daniel Kesselberg
c19bdb05e8
Generate password on addUser by password_policy app
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-09 18:38:19 +02:00
Morris Jobke
7e281a07bb
Use IBootstrap for the app federatedfilesharing
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-14 16:34:43 +02:00
Joas Schilling
db8267db26
Use the new method everywhere
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-03 10:59:43 +02:00
Mikael Hammarin
6ffde74928
Patch to optimize for large installations (>5000 users >20000 groups) where subadmins have access to many of groups (>250)
- UsersController:editUser() calls isUserAccessible() even if the user is admin

This fix reduces API calls to editUser (ex change locale/display name) from >2 minutes (!) to ~3 seconds per call in average.

Signed-off-by: Mikael Hammarin <mikael@try2.se>
2020-04-25 14:37:46 +02:00
Christoph Wurst
caff1023ea
Format control structures, classes, methods and function
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
Christoph Wurst
14c996d982
Use elseif instead of else if
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +02:00
Christoph Wurst
2fbad1ed72
Fix (array) indent style to always use one tab
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +02:00
Christoph Wurst
1a9330cd69
Update the license headers for Nextcloud 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +02:00
Christoph Wurst
d47daefe38
Revive the "send email to new users" toggle for the user form
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-02-28 14:01:03 +01:00
Robin Appelman
170660840b
query FederatedFileSharing Application instead of creating it
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-12-16 15:33:41 +01:00
Christoph Wurst
5bf3d1bb38
Update license headers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +01:00
John Molakvoæ (skjnldsv)
f675e61c26
Fix provisioning_api getUsers types
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-11-28 20:28:27 +01:00
Roeland Jago Douma
68748d4f85
Some php-cs fixes
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-22 20:52:10 +01:00
Christoph Wurst
de6940352a Move settings to an app
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2019-09-28 09:39:28 +00:00
Christoph Wurst
d058ef2b6c
Make it possible to wipe all tokens/devices of a user
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-07-09 13:57:04 +02:00
John Molakvoæ (skjnldsv)
33409319be
Do not fail hard on new user mail error
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-07-02 08:42:47 +02:00
Roeland Jago Douma
98244b5d6d
Merge pull request #16024 from nextcloud/bugfix/15944/fix-return-code-user-provision
Forward OCSException to initiator
2019-06-25 13:32:10 +02:00
Arthur Schiwon
99075825e3
changes the returned key from UserID to id, in accordance with getUserData
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-06-21 16:38:25 +02:00
Arthur Schiwon
29449f85b6
uses "yes" and "no" for config switch over stringified numbers
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-06-21 10:22:12 +02:00
Daniel Kesselberg
4177653e99
Forward OCSException to initiator
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-06-20 18:04:52 +02:00
Arthur Schiwon
bbe2f2535a
makes users management page aware of the introduced options
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-06-19 17:04:35 +02:00
Arthur Schiwon
5b754a6353
extends Provisioning API with optional userid and required email
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-06-19 17:02:28 +02:00
Arthur Schiwon
45110f4c5d
fixes misunderstanding of the error message
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-05-16 14:31:10 +02:00
Julius Härtl
add43bc19c
Check if password can be changed for the users backend in OCS api
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-03-05 13:44:25 +01:00
Roeland Jago Douma
95d1cf4817
Merge pull request #13412 from nextcloud/forward-password-policy
forward error message from password policy
2019-01-30 11:12:02 +01:00
Roeland Jago Douma
15abcff2a1
Expose subadmin to OCP
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-01-29 20:47:35 +01:00
Joas Schilling
9262507881
Fix doc block
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-01-10 10:49:09 +01:00
Robin Appelman
3991aa0166
forward error message from password policy
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-01-07 16:28:06 +01:00
zulan
cf266ee004 Get l10n within NewUserMailHelper to ensure it always uses the new user's language.
Some related tests had to be changed because they relied on internals, see also from the PHPUnit documentation:
"Exercise caution when using [the at] matcher as it can lead to brittle tests which are too closely tied to specific implementation details."

Signed-off-by: Zulan <git@zulan.net>
2018-10-15 19:01:46 +02:00
Joas Schilling
f0d48554d3
Fix user and group listing with users that have an integer user id
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-09-12 09:47:25 +02:00
Daniel Calviño Sánchez
36326e38a0 Add optional "displayName" parameter to add user endpoint
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-07-31 13:33:55 +02:00