Commit graph

402 commits

Author SHA1 Message Date
provokateurin
82fb8f8508
refactor: Extend rector to core/
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-15 00:16:54 +02:00
Christopher Ng
5786fcb3fb fix(core): Fix undefined "application" array key error in user layout
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-02-11 16:07:59 -08:00
Ferdinand Thiessen
182acb1e29
fix(template): Use <div> instead of <main> to support Vue3 apps mounting
Vue3 does not replace the element while mounting but only renders within
(replace inner HTML).
So it would result in two stacked `<main>` elements which is invalid and
an accessibility issue.
Instead we just use a `<div>` element for mounting.

For Vue2 apps this does not change anything as the whole element will be
replaced with a new `<main>` element.
For vanilla apps this will slightly decrease the accessibility as the
main landmark is now missing, but this is not a hard accessibility issue
as it would be for Vue3 apps having two main elements.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-14 09:18:43 +01:00
ali ghorbani
2b7efd66b6
feat(rtl): Set layout direction based on language
Signed-off-by: ali ghorbani <ghorbani.ali.developer@gmail.com>
2024-09-23 16:59:20 +02:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +02:00
Mostafa Ahangarha
c5baf3d7ef Fix: float and clear
Fix other background-positions
Minor fix in link button icon position
Update header left and right to start and end

Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
2024-08-29 08:32:47 +00:00
Ferdinand Thiessen
ec00367f30
fix: Disable auto-zoom on iOS
When using iOS and focussing an input element the view should not be zoomed.
So if we set a maximum scale iOS will not auto-zoom but still allow users to zoom.
But we can not do this by default as this will disable user zoom on Chrome.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-21 13:01:18 +02:00
Ferdinand Thiessen
2916e5df7e
feat: Provide CSP nonce as <meta> element
This way we use the CSP nonce for dynamically loaded scripts.
Important to notice: The CSP nonce must NOT be injected in `content` as
this can lead to value exfiltration using e.g. side-channel attacts (CSS selectors).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-13 10:32:44 +02:00
Grigorii K. Shartsev
885ec73603 chore(core): wrap initial state into hidden container
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-07-30 13:24:38 +02:00
Andy Scherzinger
e07a190641
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-27 14:53:40 +02:00
Andrii Rublov
7142ea9227 php-cs-fixer fixes
Signed-off-by: Andrii Rublov <airublev@outlook.com>
2024-02-23 18:39:23 +01:00
Andrii Rublov
8d22d341c8 [Bugfix]: Titles of pages (dashboard, apps-settings, users-settings) #43327
Signed-off-by: Andrii Rublov <airublev@outlook.com>
2024-02-23 18:39:23 +01:00
Joas Schilling
2fccd090b3
fix(manifest): Check if app exists instead of accessing null as an array
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-17 09:25:44 +01:00
Ferdinand Thiessen
7ee706ac14
Merge pull request #42837 from nextcloud/refactor/remove-legacy-sudo-login-form
refactor(core): remove `sudo-login-form` layout
2024-01-16 16:56:40 +01:00
Grigorii K. Shartsev
5260c18b89 refactor(core): remove sudo-login-form layout
This form has never been used and existed only during the introduting the first password confirmation.
- PR 1447

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-01-16 11:32:36 +01:00
julia.kirschenheuter
f6ec297df6 Complete <h1> settings heading
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2024-01-16 09:24:22 +01:00
fenn-cs
0b171f6095 Rename "global search" to "unified search"
- Changes appearances of "Global search" to "Unified search" in UI
- Refactors code, to remove usage of term "GlobalSearch" in files and code
 structure
- Rename old unified search to `legacy-unified-search`

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-12-12 20:34:37 +01:00
fenn-cs
20b3338288 Feat: New UI global search
We are introducing a new search UI that providers a lot more space
for users via a large centralized modal and providers various filters
which can by applied by adding various chips on the UI.

For example, users can now filter their search or scope it by limiting the results
to specific apps, time period and people by apply the appropriate filters on the
new UI, previously filters where applied using text in the search box by prefixing
with `::`.

Resolves: #39162

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-11-10 11:27:32 +01:00
Grigorii K. Shartsev
0e8abfd24c fix(core): remove unnecessary role=banner on top level header
By default, the HTML's `<header>` element has an identical meaning to the banner landmark,
unless it is a descendant of `<aside>`, `<article>`, `<main>`, `<nav>`, or `<section>`.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2023-10-21 17:35:44 +02:00
julia.kirschenheuter
541607349b Move heading to the main content
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-04-05 10:27:16 +02:00
Christopher Ng
4f8e916585 Add label for logo link
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-03-29 13:36:45 -07:00
julia.kirschenheuter
0cfbe54a5a Create headings for settings pages
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-03-07 17:51:19 +01:00
Julia Kirschenheuter
9160b3791f
Merge pull request #36633 from nextcloud/fix/36632-create_an_accessible_name_for_logo
Create an accessible name for logo on logged in page
2023-02-13 10:32:42 +01:00
julia.kirschenheuter
2b39261b62 Create an accessible name for logo on logged in page
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-02-13 09:17:24 +01:00
Christopher Ng
c77998209f Port user menu to Vue
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-02-09 17:54:59 -08:00
Côme Chilliet
f5c361cf44
composer run cs:fix
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +01:00
John Molakvoæ
9af7ee8d11
Revert "Add alt to the logo, adapt css for logo"
This reverts commit bba5ab0532.
2023-01-17 14:19:23 +01:00
Christopher Ng
f6aa5224c4 Focus trap contacts menu with NcHeaderMenu port
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-13 23:19:28 +00:00
julia.kirschenheuter
bba5ab0532 Add alt to the logo, adapt css for logo
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-12-08 09:28:25 +01:00
julia.kirschenheuter
a8ff2ff0b0 Place ``<h1>`` into main content
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2022-11-15 10:50:33 +00:00
Arnout Engelen
087deb9f1b
Disable browser translations
This will tell the browser not to translate the text on the page,
since this is very confusing given the good existing translation
support in Nextcloud and the fact that the language the Nextcloud
UI is set to might not match the language the content of the
instance is in, leading to surprising effects.

Better to disable it and remove the confusion.

Fixes #34857

Signed-off-by: Arnout Engelen <arnout@bzzt.net>
2022-10-27 20:16:47 +02:00
Carl Schwan
2397ea7219
Merge branch 'master' into fix/setting/accessibility-title
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-02 12:05:51 +02:00
Julius Härtl
ac736b2f82
Do not prevent scaling due to accessibility
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-09-01 14:15:39 +02:00
Julius Härtl
03b9047e95
More refactoring of app content areas
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-09-01 14:15:37 +02:00
Julius Härtl
5b4708c5be
Move app menu to vue
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-08-31 10:24:03 +02:00
julia.kirschenheuter
f22427be89 Transfer aria-label from nav settings menu to settings menu icon-button
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2022-07-28 11:20:34 +02:00
Vincent Petry
ac4e60e6f4
Merge pull request #33361 from nextcloud/techdebt/noid/further-cleanup
Further markup cleanup
2022-07-26 22:34:27 +02:00
Vincent Petry
b896cd7f01 Add missing closing spans and avoid empty href
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-07-26 14:00:12 +00:00
Vincent Petry
255d22fa71 Remove obsolete notification container
The future is TOAST 🍞

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-07-26 13:54:24 +00:00
Julius Härtl
87320cba99
Fix styling for single skip buttons globally
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-07-16 10:17:15 +02:00
Julius Härtl
ca0435382d
Allow to override #app-content and #app-navigation hrefs for content skipping
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-07-16 10:00:53 +02:00
Joas Schilling
1ad24d22df
Fix duplicate id "hole"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-07-14 14:36:56 +02:00
Louis Chemineau
6905b347ea Declare header entries in the order they are displayed
The notifications entry was declared after the search one, but they are rendered in a different order. This PR switch their declarations, so the order they appear in match their order in the DOM.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-06-02 11:22:59 +02:00
Carl Schwan
046d5451b1 Improve accessibility of the title of the settings
Before every setting page had the same title and this is causing issues
for screenreaders since they can't differenciate the title of page. Now
a new variable is available for apps to declare the page subtitle.

This new variable is implemented for the settings app and while at it I
added a bit more type hinting to the stuff I touched :)

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-16 22:47:37 +02:00
Carl Schwan
c1499519d4 Improve accessibility with more visible focus indication for non vue apps
- Add visible-focus effect on each header entry
- Show focus outline when using focus-visible (keyboard navigation)
- Add polyfy for focus-visible since it's only very recently available
  on webkit
- Change text for link to home button to describe the destination and
  not the current page
- Improve focus effect in app sidebar navigation

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-16 13:21:48 +02:00
John Molakvoæ
c59c3b5c1f
Migrate to static icons colours
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-05-10 23:24:06 +02:00
John Molakvoæ
5e8a3eb66c
Fix header apps icons
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-28 18:12:29 +02:00
John Molakvoæ
d1dfdfe799
Lint and psalm fix
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-21 19:00:29 +02:00
John Molakvoæ
69d1d1a84e
Write body theme selector straight in the template
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-21 09:31:07 +02:00
Joas Schilling
b3cf312edc
Start theming providers
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-04-21 09:29:33 +02:00