Commit graph

509 commits

Author SHA1 Message Date
Joas Schilling
150ab15a83
fix(logger): Prevent infinite recursion with log.condition => matches
When we need to check the log condition for a user matches,
there is a risk that something on the way checks the log level
and would result in an infinite loop.
So we simply check if it's a nested call and use the default
warning level in that case.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-02 13:48:18 +02:00
Louis Chemineau
ab6d1982c5
test(ExternalStorage): Send basic auth during integrations tests
Signed-off-by: Louis Chemineau <louis@chmn.me>

[skip ci]
2025-02-11 11:56:30 +01:00
Ferdinand Thiessen
44742d617f
fix(settings): Also sanitize fediverse and twitter handle in the frontend
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-09 13:46:27 +01:00
Ferdinand Thiessen
34bb825f21
fix(provisioning_api): Correct limit for editUser
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-09 13:46:27 +01:00
Ferdinand Thiessen
3d5085343a
test: Reset sharing app config after test
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-31 18:46:07 +01:00
Benjamin Gaussorgues
db1d71e322
Merge pull request #48473 from nextcloud/backport/47846/stable29 2024-10-30 10:07:37 +01:00
Ferdinand Thiessen
eae69cb8bc
fix(dav): Public WebDAV endpoint should allow GET requests
`GET` should be allowed even without Ajax header to allow downloading files,
or show files in the viewer. All other requests could be guarded, but this should not.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-09 18:17:19 +02:00
Hamza Mahjoubi
6534e52ce3 fix: provision api's status codes
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2024-10-09 13:49:21 +02:00
Daniel Calviño Sánchez
f34daedd4c test: Add integration tests for saving external userglobal storages
As the external storage uses the Nextcloud server itself the number of
workers of the PHP process running the Nextcloud server had to be
increased. Otherwise if a request is sent for the external storage while
handling a request from the integration tests a deadlock would occur.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 23:19:37 +02:00
fenn-cs
bd9e2f13a9 test(Sharing): Integration test for no expiration set date for share
- Verify that explicitly sending empty `expireDate` param to server overwrite default

and sets not expiry date, if non is enforced.

- Update tests to avoid converting empty string to date.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-05-29 12:58:37 +01:00
Côme Chilliet
0b332ceac2 fix: Apply new coding standard to all files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-04 11:45:22 +02:00
Richard Steinmetz
53ef6c5f71
feat(dav): update a principal's schedule-default-calendar-URL
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-02-28 14:51:10 +01:00
Ferdinand Thiessen
52cc18efc0
fix(tests): Ensure ldap server can be reached in integration tests on GitHub Actions and other improvments
* Run integration tests for every pull request
* Also print docker logs of service containers (ldap, redis)
* Ensure consistent `datadir` for test assertions
* Test openldap features separatly
* Only the LDAP tests rely on `/dev/shm` while `federated.feature` rely on real directory access

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-26 13:53:34 +01:00
Joas Schilling
34ea298843
Fix "Creation of dynamic property CommandLineContext::$…BaseUrl is deprecated in CommandLineContext.php on line 41"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-26 13:53:32 +01:00
Joas Schilling
d7e249874e
Ensure the testing app is enabled
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-26 13:53:31 +01:00
Joas Schilling
736fb4c162
Fix "Creation of dynamic property FeatureContext::$parts is deprecated in WebDav.php line 757"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-26 13:53:30 +01:00
Joas Schilling
058b69eef0
chore: Move integration tests from drone to github
* Improve grouping as setting up CI took 3* the time of the test in average

Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-26 13:53:29 +01:00
John Molakvoæ
82b5a19a35
fix: public dav and files_sharing testing fixes
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-01-09 10:56:14 +01:00
Maxence Lange
d821f7487a confirm content on dav-v2 test
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-11-24 11:11:48 -01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +01:00
Maxence Lange
09879700aa
Merge pull request #41668 from nextcloud/enh/noid/test-dav-favorite-search
test boolean favorite
2023-11-23 07:53:39 -01:00
Maxence Lange
fbe92d4a90 fixing test
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-11-23 00:43:26 -01:00
Maxence Lange
fa17de290d test boolean favorite
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-11-22 13:17:49 -01:00
Joas Schilling
a7018bc5e8
fix(autocomplete): Fix missing user status on autocomplete endpoint
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-09-28 14:02:18 +02:00
Christopher Ng
af98c702e0 fix(ci): add to enabled apps
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-08-03 15:30:11 -07:00
Daniel Kesselberg
debd03f30d perf: skip request without write permission
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-19 13:42:13 +00:00
Simon L
2cb7dd2d84 disable contacts menu features that regularly fail on drone
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-05-17 10:51:24 +02:00
Joas Schilling
8013bc91c8
Merge pull request #37385 from nextcloud/bugfix/noid/dont-allow-adding-the-same-email-multiple-times
fix(provisioning_api): Don't allow to configure the same additional e…
2023-05-03 11:06:41 +02:00
Simon L
dcd723ee23 disable contacts menu features that regularly fail on drone
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-05-02 12:30:35 +02:00
Joas Schilling
41fc6787bc
fix(tests): Fix new integration tests
The integration tests are not isolated, so we can not reuse previously used data

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-26 10:05:04 +02:00
Joas Schilling
1c0aae9c54
fix(provisioning_api): Don't allow to configure the same additional email multiple times
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-26 08:41:37 +02:00
Julius Härtl
d2a0571675
tests(integration): Fix catching error only on object store
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-03-08 20:23:29 +01:00
Julius Härtl
e23aa8883e
feat(s3): Use multipart upload for chunked uploading
This allows to stream file chunks directly to S3 during upload.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-03-08 14:00:04 +01:00
Joas Schilling
98ed72b3ed
Revert "fix(performance): Do not set up filesystem on every call" 2023-02-21 07:36:43 +01:00
Julius Härtl
ec356504ea
tests: Remove legacy chunking tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 19:18:38 +01:00
Julius Härtl
3493099617
tests: Remove legacy checksum test
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 19:18:38 +01:00
MichaIng
5f90b8eb11
Change X-Robots-Tag header from "none" to "noindex, nofollow"
While "none" is indeed equivalent to "noindex, nofollow" for Google, but seems to be not supported by Bing and probably other search engines.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name#other_metadata_names
https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag?hl=de#comma-separated-list
https://www.bing.com/webmasters/help/which-robots-metatags-does-bing-support-5198d240

Signed-off-by: MichaIng <micha@dietpi.com>
2023-02-15 20:16:51 +01:00
Côme Chilliet
f5c361cf44
composer run cs:fix
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +01:00
Côme Chilliet
7b93a143c8
Fix check in integration tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:12 +01:00
Carl Schwan
f244406ebd Update composer autoloader
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-22 13:35:17 +01:00
Vincent Petry
486d8bc986
Add test for received share in share_folder
Add integration test for receiving a share in a configured
"share_folder".

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-15 09:57:44 +01:00
Christopher Ng
f44d2586b1 Remake profile picture saving with Vue
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-09-02 02:22:57 +00:00
Vincent Petry
c1df72fc8b
Fix copy in view-only mode
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-26 14:18:47 +02:00
Vincent Petry
e9a344a644
Add int test for view-only download
Asserts that downloading a view-only document returns 403.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-26 14:18:47 +02:00
Louis Chemineau
347ca20f4e Rename setting name to reduce its length
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-06-27 11:04:17 +02:00
Carl Schwan
09c6cd77ec Add test
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-23 12:47:58 +02:00
Joas Schilling
550258200b
Fix integration test which now actually matches the system-addresssbook entry
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-06-09 15:38:30 +02:00
Côme Chilliet
8951f069fe Require a recent phpunit version in integration and acceptance
Otherwise build with PHP>8 will fail as PHPUnit 6 does not support it

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-05-24 18:54:29 +02:00
Louis Chemineau
80fa3c7319 Add setting to ignore email during search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-05-03 17:50:29 +02:00
John Molakvoæ
1dee36c761
Remove accessibility
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-04-21 19:00:28 +02:00