upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-10 22:34:26 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 59
72532 commits 692 branches 1182 tags 8.2 GiB
Commit graph

239 commits

Author SHA1 Message Date
Benjamin Gaussorgues
1afaac7031 fix(files_external): list root when using SMB case-insensitive option 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-02-12 10:16:31 +00:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-11-23 10:36:13 +01:00
Benjamin Gaussorgues
c52d5e418a
Merge pull request #41053 from nextcloud/bug/smb/in-place-case-rename 
fix(files_external): on case insensitive system, block case change
 2023-10-31 16:07:29 +01:00
Louis Chemineau
e66e8bad1a
Return correct status if touch failed 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-10-23 15:26:43 +02:00
Benjamin Gaussorgues
a45e12abc8
fix(files_external): on case insensitive system, block case change 
When a file/directory is renamed to the same name with only case change,
the rename fail. We block this kind of rename.
The user will have to rename to another name first.

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-10-23 10:32:28 +02:00
Robin Appelman
eab8dd3ca0 use multipart copy for s3 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-20 17:28:48 +02:00
Robin Appelman
d42d809170 sftp psalm fixes 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-18 16:12:03 +02:00
Robin Appelman
c264903cb9
psalm suppress 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-04 16:30:12 +02:00
Robin Appelman
aa2a3ae6c8
implement fseek for sftp read stream 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-04 16:30:11 +02:00
Robin Appelman
b41c8e0ef5
more optimized getPermissions/getMetaData 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-04 16:30:10 +02:00
Robin Appelman
1dfef9fccf
sftp optimize file_put_contents, writeStream and copy 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-04 16:30:10 +02:00
Robin Appelman
9cf732a90b
fix error during sftp stream close 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-04 16:30:09 +02:00
Robin Appelman
19daa70947
clear sftp stat cache when opening a write stream 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-09-04 16:30:07 +02:00
Benjamin Gaussorgues
9b03dc52a4
Migrate files external to PSR LoggerInterface 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-08-01 09:44:57 +02:00
Robin Appelman
7c9edbff32
handle more exceptions in AmazonS3::fopen 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-07-13 15:37:42 +02:00
Simon L
83faba5e61
Merge pull request #38591 from nextcloud/fix/caching/avoid-haskey-get 
fix(caching): Avoid checking existence before fetching
 2023-06-12 13:53:37 +02:00
Christoph Wurst
b8c61b3515 fix(caching): Avoid checking existence before fetching 
The cache might expire between checking for key existence and fetching
the value. In this rare case the code continues with a null value when
it doesn't expect one.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-06-12 09:44:48 +02:00
Faraz Samapoor
94f2f57519
Update apps/files_external/lib/Lib/Storage/SMB.php 
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
 2023-06-05 16:21:14 +03:30
Faraz Samapoor
cfb921b26c Refactors "strpos" calls in /apps/files_external to improve code readability. 
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
 2023-06-02 19:54:49 +03:30
James Guo
bb173e092b
Update AmazonS3.php 
Signed-off-by: James Guo <i@ze3kr.com>
 2023-04-06 14:34:08 +08:00
Robin Appelman
b1f352c614
improve handling of files we can't access in the scanner 
instead of erroring, remove the items from the cache.

this situation can be triggered if a user has access to a file but looses it afterwards

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-05 14:44:55 +02:00
Robin Appelman
fd0ef588b4
fix ftp external storage with filezilla server 
- filezilla doesn't like "" as parameter for `mdtm` (all others seem fine)
- filezilla sends fractional modified date

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-03-30 17:44:47 +02:00
Côme Chilliet
308fcf4526
Respect OCP interface in private classes 
Because the parameter type was moved to phpdoc it needs to be removed
 from implementations

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:35 +01:00
Côme Chilliet
ff776a90b1
Strong type filesize related methods to ease 32bits problem findings 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:28 +01:00
François Ménabé
710f3fd405 Support of s3 storage class in External Storage application 
Signed-off-by: François Ménabé <francois.menabe@gmail.com>
 2023-01-12 14:59:13 +01:00
Côme Chilliet
9430899f16
Fix psalm issues related to signature changes from PHP 8.0 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-29 12:36:34 +01:00
Robin Appelman
ed8fedc685
fix s3 directory copy 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-11-15 17:17:59 +01:00
Côme Chilliet
9ba9f9a7dc
Make sure to not pass null to DateTime::createFromFormat 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-14 16:23:50 +01:00
Carl Schwan
a5ea677370 Rename file1 and file2 to source and target in Storage abstraction 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-18 17:21:47 +02:00
Carl Schwan
732badf552 Additional type hinting found by psalm 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-18 12:28:34 +02:00
Carl Schwan
c2c63a551f Fix usage of streams 
always return a bool and type the handle as a string

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 10:58:27 +02:00
Carl Schwan
74e6976779 Use argument name from parent class 
This will be an issue with php 8, so best to fix it now

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 10:58:27 +02:00
Carl Schwan
cf1381a6f9 Port away from deprecated clearBucket call 
This was removed a long time ago in the library that we use, but never
detected since this was inside a try catch block...

Remove the call for now and we should investigate newer api in the
future.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-16 23:39:49 +02:00
Carl Schwan
1d90f84141 Port to LoggerInterface 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-16 23:39:28 +02:00
Carl Schwan
ff4c8e9bee Force cast getCode to int 
Otherwise psalm complains that the type can also be a non-falsy-string

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-16 23:38:31 +02:00
Matthieu Gallien
54c05bcdb9 handle AccessDenied error when checking if external s3 support versions 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-07-28 09:20:12 +00:00
Carl Schwan
d5c23dbb9f Move CappedMemoryCache to OCP 
This is an helpful helper that should be used in more place than just
server and this is already the case with groupfodlers, deck, user_oidc
and more using it, so let's make it public

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-07-14 15:54:31 +02:00
Carl Schwan
ec6b83cc18 Add stricter psalm type for CappedMemoryCache 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-12 15:06:18 +02:00
Carl Schwan
f945c0cbc6 Add a public replacement for OC::$server->get 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-10 18:51:12 +02:00
Vincent Petry
bccb69f806
Merge pull request #30860 from nextcloud/smb-getdirectory-content-catch 
handle notfound and notpermitted error in Smb::getDirectoryContent
 2022-04-14 20:26:17 +02:00
Côme Chilliet
ea23523c70
Adapt more code to migration to LoggerInterface 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-03-24 16:21:25 +01:00
Robin Appelman
ec4be7f2be
Merge pull request #31215 from nextcloud/smb-directory-invalid-type 
handle invalid type when listing directory in smb
 2022-03-17 16:25:26 +00:00
Erik van Velzen
17f3e5e4b5 AmazonS3: allow not implemented versioning 
In case the S3 implementation does not implement versioning, set it to
false. Versioning was introduced in Nexcloud in commit
09ffac5e6d

This is needed for compatibility with the Storj gateway.

Signed-off-by: Erik van Velzen <erik@evanv.nl>
 2022-03-15 00:40:38 +01:00
John Molakvoæ
e81eaf45d2
Prevent reading key on SFTP stat bool 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2022-03-11 10:54:52 +01:00
Robin Appelman
a6f245f6ff
type hint as generator 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-03-04 16:26:08 +01:00
Robin Appelman
5b77099612
handle invilid type when listing directory in smb 
just handle it as an empty directory

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-03-04 15:49:00 +01:00
Robin Appelman
e2aa283dba
handle notfound and notpermitted error in Smb::getDirectoryContent 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-02-11 17:23:54 +01:00
Carl Schwan
aeecb72e96
Fix a few psalm issues and moved back to psalm/phar 4.18 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-12 20:03:06 +01:00
Julius Härtl
4e57146617
Use unique combination of hostname/bucket/key for external storages 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-11-04 11:34:13 +01:00
Julius Härtl
9356124700
Merge pull request #29021 from nextcloud/work/smb/additional-logging 2021-10-25 13:25:04 +02:00