upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-25 02:34:12 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 9
72532 commits 982 branches 1211 tags 8.6 GiB
Commit graph

1583 commits

Author SHA1 Message Date
Christoph Wurst
b8c61b3515 fix(caching): Avoid checking existence before fetching 
The cache might expire between checking for key existence and fetching
the value. In this rare case the code continues with a null value when
it doesn't expect one.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-06-12 09:44:48 +02:00
Faraz Samapoor
12e3594299 Refactors "strpos" calls in /apps/files_sharing to improve code readability. 
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
 2023-06-02 20:08:40 +03:30
Robin Appelman
2ea41dab93
repair -1 folder sizes for object store background scan 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-05-10 19:33:26 +02:00
Louis Chemineau
6b53e4b13a Mutualize expireDate handling when creating and updating a share 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-04-27 16:26:24 +02:00
Robin Appelman
1bff4e23bf
Merge pull request #37525 from nextcloud/file-debug-info 
add command for getting fileinfo for debugging
 2023-04-21 14:18:05 +02:00
rakekniven
86b17e2248 Update apps/files_sharing/lib/Controller/ShareAPIController.php 
Co-authored-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2023-04-18 12:08:38 +02:00
rakekniven
eaaeb32074 fix(l10n): Fixed grammar 
Reported at Transifex.
  
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>


Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2023-04-18 12:08:38 +02:00
Robin Appelman
60cf0c8f5f
add command for getting fileinfo for debugging 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-17 16:23:52 +02:00
jld3103
dcf6ebebab
Fix inherited parameter names 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-04-03 08:29:33 +02:00
Michiel de Jong
c0e84cb512 Add SHARE_TYPE_SCIENCEMESH 
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
 2023-03-08 16:46:55 +01:00
Côme Chilliet
74811813e7 Avoid extra parenthesis around SQL in IN expressions 
The expression builder already suround the SQL with parenthesis when
 using in(), so we must not add another pair, this confuses at least
 sqlite.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-21 13:37:30 +00:00
Julius Härtl
38ca468502
Merge pull request #36515 from nextcloud/fix/sharees-remove-deck 2023-02-16 21:17:16 +01:00
Joas Schilling
80071bd8b9
fix(sharing): Remove casting to int from INF 
Regression from nextcloud/server#35736
INF is a the float INF, casting it to integer will make it 0

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-02-07 14:13:39 +01:00
Vincent Petry
1fed799826
Merge pull request #36452 from nextcloud/perf/share-availability-check 
perf(federation): Only request root share info for checking availability
 2023-02-03 13:34:35 +01:00
jld3103
30858df737
Remove Deck from Sharees API 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-02-03 12:01:37 +01:00
Louis Chemineau
4ab3c16403 Pluggable share provider 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-02-02 15:41:26 +01:00
Julius Härtl
7e3ea019d1
chore: Add return types 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-01-31 11:42:33 +01:00
Julius Härtl
7cc9ba28a7
perf(federation): Only request root share info for checking availability 
Otherwise this would request a full recursive dirctory listing while the result is never being used

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-01-31 11:41:34 +01:00
Robin Appelman
c105b6a85d
still include the share target in the cache key for validating share mount 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-01-16 13:09:50 +01:00
Robin Appelman
927174e325
fix cache key used to verify shared mountpoints 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-01-09 13:48:44 +01:00
John Molakvoæ
887c9e05de
Port Files navigation to vue 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2023-01-04 16:45:41 +01:00
Julius Härtl
628b0d8fc4
Merge pull request #35213 from PLUTEX/32611-ocs-api-share-permissions 
Honor permissions of new link share via OCS API
 2022-12-22 15:42:42 +01:00
Côme Chilliet
cbbb0712db
Merge pull request #34807 from nextcloud/fix/compute-notification-parsed-subject 
Compute notification parsed subject from rich subject when possible
 2022-12-19 10:46:39 +01:00
Jan-Philipp Litza
a7abe2c35a Honor permissions of new link share via OCS API 
The API currently overrides the supplied permissions with "read only"
when a file is shared via link. It allows to update the permissions
later, however.

This keeps the default to "read only" but honors the permissions
supplied by API call if any.

Signed-off-by: Jan-Philipp Litza <jpl@plutex.de>
 2022-12-06 16:00:20 +01:00
Côme Chilliet
1821712615
Merge pull request #35596 from nextcloud/fix/move-to-ocp-timedjob 
Use TimedJob from OCP instead of OC
 2022-12-06 12:14:43 +01:00
Côme Chilliet
f95aa23356
Merge pull request #35400 from nextcloud/fix/remove-unused-dynamic-var-in-files_sharing 
Fix name of dymanic var $mountOptions to fix PHP 8.2 compatibility
 2022-12-05 17:57:46 +01:00
Côme Chilliet
3bcb4fc024
Put back the variable but make sure it is properly declared 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-05 11:51:16 +01:00
Côme Chilliet
a0f6a6545b
Use TimedJob from OCP instead of OC 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-05 10:13:34 +01:00
Côme Chilliet
d9151ff35c Get rid of all useless calls to setParsedSubject now that setRichSubject is able to do it 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-29 14:36:29 +00:00
Anna Larch
7c4ceb444c Add group display name cache 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2022-11-28 11:52:55 +00:00
Côme Chilliet
26033653a8
Remove dymanic var $mountOptions to fix PHP 8.2 compatibility 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-24 11:52:07 +01:00
Julius Härtl
8629d8e44f
Check share attributes on preview endpoints 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-10-25 11:35:31 +02:00
Carl Schwan
0de71a73e5
Merge pull request #34502 from nextcloud/fix/correct-attribute-resharing 
Propagate attributes when resharing
 2022-10-20 17:03:02 +02:00
Carl Schwan
0f0f132959
Merge pull request #34624 from nextcloud/fix/files_external_psalm 
Multiple fix for files external
 2022-10-20 16:53:43 +02:00
Carl Schwan
a5ea677370 Rename file1 and file2 to source and target in Storage abstraction 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-18 17:21:47 +02:00
Carl Schwan
54031e370a Fix various other small psalm issues 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 12:40:35 +02:00
Carl Schwan
0a2a4d8687 Fix incorrect argument name in inherited method 
The arguments now need to be the same as in the parent method

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 12:39:22 +02:00
Carl Schwan
60313683e2 Fix checkpassword undocummented null parameter 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 12:38:21 +02:00
Carl Schwan
c6b8a3bec3 Fix permission not being int 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 12:37:46 +02:00
Carl Schwan
53e408f76a Fix exception getCode type 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 12:36:50 +02:00
Carl Schwan
3a11128e6c Fix type when getting appconfig with int 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 12:36:05 +02:00
Vincent Petry
95d45c2058
Merge pull request #34471 from starypatyk/dav_read_share_notes 
Reduce number of database queries during WebDAV propfind request
 2022-10-14 15:33:13 +02:00
Simon L
d967488ec0
Merge pull request #34544 from nextcloud/fix/more-flexible-date-validation 
More flexible date validation
 2022-10-13 01:10:55 +02:00
Carl Schwan
9eb67ad57d More flexible date validation 
Fix #34542

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-11 23:02:10 +02:00
Carl Schwan
8e3f21d9ed Small progress with fixing unit tests 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-11 14:00:15 +02:00
Carl Schwan
cf39885b53 Propagate attributes when resharing 
When updating a share, load the node from the initiator instead of the
owner similar to how this is done when creating the share.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-10 17:06:29 +02:00
Roeland Jago Douma
c6e100ed32
type closure to make psalm a bit happier 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2022-10-09 21:41:18 +02:00
Dariusz Olszewski
255d1dd686 Read notes from share already loaded into memory 
Signed-off-by: Dariusz Olszewski <starypatyk@users.noreply.github.com>
 2022-10-07 23:24:12 +02:00
tobiasKaminsky
610bbaed68 includeTags -> include_tags 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-09-28 13:17:56 +00:00
Joas Schilling
2acf9ffafe
Ignore invalid share types 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-09-26 09:40:53 +02:00
Tobias Kaminsky
5b3fb7a8ff
Update apps/files_sharing/lib/Controller/ShareAPIController.php 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Tobias Kaminsky <tobias@nextcloud.com>
 2022-09-21 08:28:03 +02:00
tobiasKaminsky
ebd28ef9e0
Show include tags on single share 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
 2022-09-19 11:36:52 +02:00
tobiasKaminsky
4a4a3874da
Add includeTags to /share/id 2022-09-19 11:11:09 +02:00
Carl Schwan
02d55eb90f
Merge pull request #33941 from nextcloud/fix/public-sharing 
Only normalize data in public shares and not crud
 2022-09-15 16:43:01 +02:00
Carl Schwan
7ded5a769b
Only normalize data in public shares and not crud 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-09-08 14:51:28 +02:00
luz paz
9d26671f05 Fix typos in apps/ subdirectory 
Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`

Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
 2022-09-05 12:59:54 +00:00
Max
99aa938452 feature: first take on using the viewer to render single file shares 
Signed-off-by: Max <max@nextcloud.com>
 2022-08-25 21:59:19 +00:00
Vincent Petry
5f90a6a5e2
Merge pull request #33574 from nextcloud/search-share-query-filter-no-init 
directly build the search filter for shared storage instead of setting up the source cache
 2022-08-23 14:15:24 +02:00
Joas Schilling
7e11778190
Use user name cache in activity providers 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-08-19 10:48:32 +02:00
Robin Appelman
b731c95b79 further pre-filter search result before setting up share source cache 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-08-17 13:49:21 +02:00
Robin Appelman
b6f8b8da60 directly build the search filter for shared storage instead of setting up the source cache 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-08-17 11:58:57 +02:00
Carl Schwan
8004aa7721
Make DisplayNameCache return null if user doesn't exists 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-08-16 14:10:05 +02:00
Robin Appelman
8367b99c59
fix external share scanner not propagating locking-opt-out 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-08-03 17:12:30 +02:00
Carl Schwan
6ba9a4a752
Disable locking on federated shares 
The old inneficiant code didn't do locking and adding locking is
creating issues

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-08-03 15:17:55 +02:00
Carl Schwan
fa48430feb
Revert "Revert "Remove inefficient fed share scanner"" 
This reverts commit 6667007bf2.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-08-03 15:17:51 +02:00
Carl Schwan
7b723813ce
Multiple fixes 
- Fix tests
- Use non deprecated event stuff
- Add a bit of type hinting to the new stuff
- More safe handling of instanceOfStorage (share might not be the first
  wrapper)
- Fix resharing

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-07-31 19:37:59 +02:00
Carl Schwan
ab1a20522b
Enforcing permission during resharing 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-07-28 16:54:13 +02:00
Vincent Petry
bbb5043c07
Inherit hide download from share attributes 
When resharing by link, if the download permission was removed through
share attributes, convert it to the hide download flag.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:54:13 +02:00
Vincent Petry
3cfb4cbf94
Block download when needed on direct download endpoint 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:54:13 +02:00
Vincent Petry
2ee659e547
Fix view-only code after code review comments 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:53:24 +02:00
Vincent Petry
54a0d8fe64
Don't reset share attributes when not specified 
When not specified in the OCS call, don't reset the share attributes.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:53:23 +02:00
Vincent Petry
03b1791cca
Fix share attribute related tests + code style 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:53:22 +02:00
Vincent Petry
9493f86de3
Fix share controller to accept share attributes alone 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:53:22 +02:00
Vincent Petry
a95c19e14b
Add share attributes + prevent download permission 
Makes it possible to store download permission

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-28 16:53:22 +02:00
Louis Chemineau
f525067930 Add argument to getSharesInFolder enable deep share lookup 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-07-26 12:17:46 +00:00
Louis Chemineau
0fb4ecadae Recursively fetch subshares 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-07-26 12:17:46 +00:00
Louis Chemineau
13e7ebbe4b Change share owner when moving share out of share 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-07-26 12:17:46 +00:00
Vincent Petry
8ca910976d Update owner of subdir on move into/out of share 
When moving a directory into or out of a received share, make sure to
also update the share owner column for shares that exist insie the
directory.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-07-26 12:17:46 +00:00
Carl Schwan
d5c23dbb9f Move CappedMemoryCache to OCP 
This is an helpful helper that should be used in more place than just
server and this is already the case with groupfodlers, deck, user_oidc
and more using it, so let's make it public

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-07-14 15:54:31 +02:00
Vincent Petry
85cc867143
Merge pull request #31771 from nextcloud/fix/hook-encryption-cron 
Fix hook encryption with cron job
 2022-06-10 16:27:59 +02:00
Joas Schilling
148498bba5
Merge pull request #32741 from nextcloud/Valdnet-patch-2 
l10n: Delete apostrophe
 2022-06-10 15:54:14 +02:00
Vincent Petry
6ee4e0b94c
Merge pull request #32806 from nextcloud/fix-federated-sharing 
Revert "Remove inefficient fed share scanner"
 2022-06-10 15:47:13 +02:00
Carl Schwan
6667007bf2 Revert "Remove inefficient fed share scanner" 
This reverts commit ce31914314.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-06-10 10:29:42 +02:00
Cyrille Bollu
50badb3fb6 Various improvements related to the recent implementation of temporary passwords 
for mail shares:

1- Changes style of "forgot password?" and "Back" button
2- Adds information about share password's expiration time in the emails sent.
3- Shows password expiration time in the Share menu
4- Fixes an issue when the message "Password expires..." would be shown for non email share types (which don't have temporary passswords)
5- At share's creation, password should only be sent when it's a permanent one

See also https://github.com/nextcloud/server/issues/31952

Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
 2022-06-08 11:29:19 +00:00
Joas Schilling
50c697dbd4
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-06-07 20:40:55 +02:00
Carl Schwan
5907bba3fd Fix hook encryption with cron job 
Make sure the setup fs is set before using the Update service

Fix #29674

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-06-07 15:38:45 +00:00
Valdnet
dfe7243338
l10n: Delete apostrophe 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-06-07 16:41:38 +02:00
Carl Schwan
e4378fd18c
Merge pull request #32349 from nextcloud/enh/projects-event 
Add event to load additional scripts for projects
 2022-05-27 18:36:40 +02:00
Carl Schwan
ec6b83cc18 Add stricter psalm type for CappedMemoryCache 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-12 15:06:18 +02:00
Julius Härtl
ae0e9ff083
Move files_sharing over to new event for projects 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-05-12 10:50:13 +02:00
blizzz
102d119297
Merge pull request #32053 from nextcloud/cache-verify-share-mountpoint 
cache the verification of the share mountpoint
 2022-04-22 14:36:49 +02:00
Carl Schwan
ed4c1e584f Update cache when display name change 
This improve the correctness of the data

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-04-22 10:29:18 +02:00
Carl Schwan
4333c215cb Cache display name 
This should saves some query in the share backend when displaying the
owner and it's not important if the display name is 10 minutes outdated
as it is very rare that this gets changed.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-04-22 10:22:15 +02:00
John Molakvoæ
54532b2df3
Merge pull request #32050 from nextcloud/share-cache-owner-name 2022-04-22 08:13:38 +02:00
Robin Appelman
bda8601648
cache the verification of the share mountpoint 
after the initial verification this can only really be invalidated by a system mount (external/group/etc) being created at the share target since any normal file/folder creation will already conflict with the share

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-04-21 18:08:35 +02:00
Robin Appelman
1f1b2a32cb
cache the share owner name for formating cache entries 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-04-21 17:33:18 +02:00
Robin Appelman
e3ade5507d
also apply the fix for the other storage types 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-04-21 15:00:42 +02:00
Robin Appelman
f6d5eb9a75
improve optimization for SharedStorage::instanceOfStorage(Common) 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-04-21 14:51:09 +02:00
Vincent Petry
f5c8fa4f11
Properly reset pw expiration 
When requesting a new password for share by mail link, now we correctly
reset the expiration date.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2022-04-13 15:46:30 +02:00
Vincent Petry
483741ff36
Merge pull request #31220 from nextcloud/enhancement/31005/temporary-passwords 
Temporary passwords for public non-anonymous protected shares (ie: files shared with an email recipient).
 2022-04-12 09:46:31 +02:00