Commit graph

17601 commits

Author SHA1 Message Date
Joas Schilling
2d2b41300a
Merge pull request #21539 from nextcloud/backport/21452/stable18
[stable18] Fix autocomplete for LDAP with `shareapi_only_share_with_group_members` on
2020-07-01 10:13:34 +02:00
Nextcloud bot
dcc2938429
[tx-robot] updated from transifex 2020-07-01 02:16:32 +00:00
Nextcloud bot
d317833986
[tx-robot] updated from transifex 2020-06-30 02:16:29 +00:00
Joas Schilling
3495f4c0c1
Fix PHP CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 14:55:26 +02:00
Joas Schilling
1e3748f672
Move back to IGroupManager::displayNamesInGroup()
The problem is that despite it's name IGroup::searchDisplayName()
only searches by userid and this is less fixable than changing back to this method here

Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 14:55:26 +02:00
Roeland Jago Douma
779f45de9c
Merge pull request #21448 from nextcloud/backport/21406/stable18
[stable18] Disable Client-Side Monitoring on AWS storage
2020-06-22 16:28:59 +02:00
Roeland Jago Douma
2cfb7172a0
Merge pull request #21486 from nextcloud/backport/21482/stable18
[stable18] Don't log Keys
2020-06-21 09:19:25 +02:00
Roeland Jago Douma
d24009dc20
Merge pull request #21496 from nextcloud/backport/21483/stable18
[stable18] Give up after 10 seconds in SCSS timeout
2020-06-20 16:00:47 +02:00
Nextcloud bot
cf4572227e
[tx-robot] updated from transifex 2020-06-20 02:16:56 +00:00
Roeland Jago Douma
5d57876047 Give up after 10 seconds in SCSS timeout
Else we keep idling for ages which leads to bad UX

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-06-19 19:29:58 +00:00
Joas Schilling
f5ee7736d9 Don't log Keys
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-19 13:13:35 +00:00
Roeland Jago Douma
5e0c5a0a83
Merge pull request #21381 from nextcloud/backport/20447/stable18
[stable18] Increase max-height on button in welcome email template
2020-06-19 13:22:58 +02:00
Christoph Wurst
8e3d47a215 Clean up auth tokens when user is deleted
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-18 13:32:24 +00:00
Nextcloud bot
a02a22b423
[tx-robot] updated from transifex 2020-06-18 02:16:54 +00:00
Christoph Wurst
5fdcb5a1e3 Disable Client-Side Monitoring on AWS storage
The S3 client enables this by default and then tries to read
`.aws/config`. This causes `open_basedir` restriction related error for
some setups. So this patch disables the CSM because it's most likely
unused anyway.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-17 09:02:20 +00:00
Liam JACK
597a04acb5 Fix #13287 - Increase max-height on button in welcome email template
Signed-off-by: Liam JACK <liamjack@users.noreply.github.com>
2020-06-12 11:18:29 +00:00
Nextcloud bot
09029d3481
[tx-robot] updated from transifex 2020-06-11 02:16:08 +00:00
Nextcloud bot
de8a8f3663
[tx-robot] updated from transifex 2020-06-10 02:16:25 +00:00
Nextcloud bot
4b567bfcf9
[tx-robot] updated from transifex 2020-06-09 02:16:14 +00:00
Roeland Jago Douma
3d1273d2f2
Merge pull request #21160 from nextcloud/backport/21152/stable18
[stable18] [stable18] Fix password changes in link and mail shares
2020-06-06 09:35:02 +02:00
Nextcloud bot
b07978f18e
[tx-robot] updated from transifex 2020-06-06 02:16:17 +00:00
Nextcloud bot
d1f40575f9
[tx-robot] updated from transifex 2020-06-05 02:16:55 +00:00
Joas Schilling
f97a61aa14 Prevent harder to share your root
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-04 09:03:54 +00:00
Nextcloud bot
7e8803ba9f
[tx-robot] updated from transifex 2020-06-03 02:16:28 +00:00
Nextcloud bot
802de535c6
[tx-robot] updated from transifex 2020-06-01 02:16:10 +00:00
Nextcloud bot
556a9e88f0
[tx-robot] updated from transifex 2020-05-30 02:16:15 +00:00
Daniel Calviño Sánchez
fb271d6b81 Fix disabling send password by Talk without new password in mail shares
When "send password by Talk" was disabled in a mail share it was
possible to keep the same password as before, as it does not pose any
security issue (unlike keeping it when "send password by Talk" is
enabled, as in that case the password was already disclosed by mail).

However, if a mail share is updated but the password is not set again
only the hashed password will be available. In that case it would not
make sense to send the password by mail, so now the password must be
changed when disabling "send password by Talk".

Note that, even if explicitly setting the same password again along with
the "send password by Talk" property would work, this was also prevented
for simplicity.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 19:38:28 +00:00
Daniel Calviño Sánchez
6e19f53173 Fix enabling send password by Talk with same password in mail shares
When "send password by Talk" is enabled in a mail share a new password
must be also set. However, when the passwords of the original and the
new share were compared it was not taken into account that the original
password is now hashed, while the new one is not (unless no new password
was sent, in which case the password of the original share was set in
the new share by the controller, but that was already prevented due to
both passwords being literally the same), so it was possible to set the
same password again.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 19:38:28 +00:00
Daniel Calviño Sánchez
57663d19f1 Fix enabling send password by Talk with empty password in link shares
When "send password by Talk" is enabled in a link share now a non empty
password is enforced.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 19:38:28 +00:00
Morris Jobke
555108dc65
Revert "[stable18] Fix password changes in link and mail shares" 2020-05-29 21:35:57 +02:00
Daniel Calviño Sánchez
d6f1937502 Fix disabling send password by Talk without new password in mail shares
When "send password by Talk" was disabled in a mail share it was
possible to keep the same password as before, as it does not pose any
security issue (unlike keeping it when "send password by Talk" is
enabled, as in that case the password was already disclosed by mail).

However, if a mail share is updated but the password is not set again
only the hashed password will be available. In that case it would not
make sense to send the password by mail, so now the password must be
changed when disabling "send password by Talk".

Note that, even if explicitly setting the same password again along with
the "send password by Talk" property would work, this was also prevented
for simplicity.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 14:42:16 +02:00
Daniel Calviño Sánchez
1c580351da Fix enabling send password by Talk with same password in mail shares
When "send password by Talk" is enabled in a mail share a new password
must be also set. However, when the passwords of the original and the
new share were compared it was not taken into account that the original
password is now hashed, while the new one is not (unless no new password
was sent, in which case the password of the original share was set in
the new share by the controller, but that was already prevented due to
both passwords being literally the same), so it was possible to set the
same password again.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 14:42:16 +02:00
Daniel Calviño Sánchez
26e4c292c7 Fix enabling send password by Talk with empty password in link shares
When "send password by Talk" is enabled in a link share now a non empty
password is enforced.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-29 14:42:16 +02:00
Roeland Jago Douma
876479799e
Merge pull request #21109 from nextcloud/backport/19793/stable18
[stable18] Fix resharing of federated shares that were created out of links
2020-05-28 16:37:28 +02:00
Nextcloud bot
fdb58f1852
[tx-robot] updated from transifex 2020-05-27 02:16:21 +00:00
Julius Härtl
4a2ded0199
Link shares have reshare permission if outgoing federated shares are enabled
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-05-26 11:28:42 +02:00
Morris Jobke
64df6aaf85 Do not read certificate bundle from data dir by default
Before the resources/config/ca-bundle.crt was only used when the list of custom
certificates was empty and the instance was not installed. But it should also
be used when the list is empty and the instance is installed.

This is inverting the logic to stop if the instance is not installed to use the
default bundle. And it also does this when the list is empty.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-05-25 17:53:23 +00:00
Morris Jobke
1d816add44
Merge pull request #20965 from nextcloud/backport/20033/stable18
[stable18] Enable fseek for files in S3 storage
2020-05-25 13:38:04 +02:00
Nextcloud bot
4e8f72726a
[tx-robot] updated from transifex 2020-05-25 02:16:31 +00:00
Nextcloud bot
120a7a7e23
[tx-robot] updated from transifex 2020-05-23 02:16:31 +00:00
Robin Appelman
3d3ee1bfae
harden seekable http stream a bit against failures
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-22 15:29:43 +02:00
Nextcloud bot
588fa72207
[tx-robot] updated from transifex 2020-05-22 02:17:31 +00:00
Nextcloud bot
8529fbae9b
[tx-robot] updated from transifex 2020-05-21 02:17:37 +00:00
Robin Appelman
25f5a5e575
update autoloader
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-20 22:59:08 +02:00
Robin Appelman
136a716df0
add basic tests for s3 seeking and add some error handling if reopen return the wrong range
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-20 22:58:58 +02:00
Robin Appelman
8434d0af9f
make seekable s3 stream generic
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-05-20 22:57:36 +02:00
Lukas Stabe
7a62514c31
Enable fseek for files in S3 storage
Signed-off-by: Lukas Stabe <lukas@stabe.de>
2020-05-20 22:57:30 +02:00
Morris Jobke
d26c5103e6
Compress the appstore requests by default
In test it reduced the transfered data from 5 MB to 2 MB. This should reduce the load on the appstore significantly.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-05-20 11:18:19 +02:00
Morris Jobke
f7b39e13a2
Cache appstore requests for 60 instead of 5 minutes
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-05-20 11:18:19 +02:00
Nextcloud bot
d6fa810331
[tx-robot] updated from transifex 2020-05-20 02:16:38 +00:00