Commit graph

13078 commits

Author SHA1 Message Date
Côme Chilliet
5434b35ac7
Merge pull request #40280 from nextcloud/backport/40233/stable26
[stable26] Detect aborted connection in OC\Files\View and stop writing data to the output buffer
2023-09-07 09:31:44 +02:00
Joas Schilling
a1cb0b4460 fix(ratelimit): Only use memory cache backend for redis
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-09-06 18:09:54 +02:00
max-nextcloud
dc73199e2f
Merge pull request #39991 from nextcloud/backport/39770/stable26
[stable26] fix: always use display name from correct backend
2023-09-06 13:26:42 +02:00
Arthur Schiwon
d5f6249b76
Merge pull request #40167 from nextcloud/backport/40108/stable26
[stable26] feat: add switch to disable dns pinning
2023-09-06 10:34:48 +02:00
Arthur Schiwon
4230aa8dd3
Merge pull request #40085 from nextcloud/backport/40077/stable26
[stable26] fix(cache): Remove displayname cache entry on delete
2023-09-05 19:11:28 +02:00
Côme Chilliet
342cb33f71 Apply suggestions from code review in View.php
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-05 17:06:11 +00:00
Côme Chilliet
ea2b28e1fc Lower log to debug for connections aborted by the client
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-05 17:06:11 +00:00
Côme Chilliet
b7d82f7c01 Detect aborted connection in OC\Files\View and stop writing data to the
output buffer

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-05 17:06:10 +00:00
Arthur Schiwon
1c29d87f48
Merge pull request #40232 from nextcloud/sharing-mask-wrapper-26
[26] move share permission logic to storage wrapper
2023-09-05 19:04:41 +02:00
Arthur Schiwon
f755b50a6b
Merge pull request #40187 from nextcloud/backport/39017/stable26
[stable26] fix(s3): fix handling verify_bucket_exists parameter
2023-09-05 19:00:40 +02:00
Arthur Schiwon
f7d890cd66
Merge pull request #39726 from nextcloud/backport/39698/stable26
[stable26] Catch more invalid cache source storage paths
2023-09-05 18:59:48 +02:00
Daniel
02e009867b
Merge pull request #40260 from nextcloud/backport/40234/stable26 2023-09-05 09:52:35 +02:00
Daniel Kesselberg
c2a2416e0c enh: skip processing for empty response
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-09-04 20:17:17 +00:00
Robin Appelman
065f636cb7
cleanup di for share permissions wrapper
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-04 14:21:19 +02:00
Robin Appelman
1340133526
more share permission logic to storage wrapper
this way we only have to determine the share permissions once

Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-04 14:21:11 +02:00
John Molakvoæ
c3f146b965 fix: prevent sharing permissions on user root folder
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-09-04 09:19:44 +00:00
Thomas Citharel
7deef46668 fix(s3): fix handling verify_bucket_exists parameter
If 'verify_bucket_exists' is set to false in the config.php s3 configuration, it's supposed to avoid
verifying that the bucket exists. However empty(falsy) will  always return true, so this condition
would not work.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-08-31 21:33:05 +00:00
Daniel Kesselberg
652a8a8f7a
feat: add switch to disable dns pinning
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-08-30 22:21:55 +02:00
Anna Larch
651405a320 fix(CalDAV): check voject exists before attempting any operation
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-08-29 08:18:30 +00:00
Joas Schilling
61e61fb9c3
fix(cache): Remove displayname cache entry on delete
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-29 08:53:09 +02:00
Andy Scherzinger
f3619d8558
Merge pull request #39872 from nextcloud/backport/38714/stable26
[stable26] select the fileid first when looking for incomplete files
2023-08-28 13:44:48 +02:00
Côme Chilliet
36f9ca2218 fix(loggging): user log condition feature
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-08-24 15:04:54 +02:00
Max
aa709291cf
fix: always use display name from correct backend
Overwrite the display name after the account is initialized
when using an instacne of IGetDisplayNameBackend.

Before when using a variation of user_oidc and registering
a Backend.php implementing IGetDisplayNameBackend
the personal setting page shows 'uid'.

The UserManager/AccountManager seems not to use consistently
the correct backend.

The correct backend is used in this sequence:

server/lib/private/TemplateLayout.php

          $userDisplayName = \OC_User::getDisplayName();
          $this->assign(user_displayname, $userDisplayName);

In the settings page, it definitely not calls the registered backend,
but seems to fall back to default Backend and shows (usually) uid
or a value from the standard account property table.

Signed-off-by: Max <max@nextcloud.com>
2023-08-22 09:47:51 +02:00
Anna
fcaa6760af
Merge pull request #39935 from nextcloud/fix/stable26/transfer-ownership
[stable26] fix: don't emit Hooks when hookpaths are empty
2023-08-21 09:06:18 +02:00
Joas Schilling
361d8f2742 fix(memcache): Fix comparison of Memcache configs to classes
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-17 21:48:23 +00:00
Anna Larch
fe26271c78 fix: don't emit Hooks when hookpaths are empty
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-08-17 15:00:49 +02:00
Ferdinand Thiessen
15ea32c1e1 fix: Prevent PHP warnings when optional CacheEntry attributes are unset
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-08-17 10:03:53 +00:00
Robin Appelman
690d9bac5e select the fileid first when looking for incomplete files
this seems to improve mariadbs index selection

Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-14 19:15:41 +00:00
John Molakvoæ
fe85d7d05d fix: simplify sourceData check
Co-authored-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2023-08-05 22:04:35 +00:00
Josh Richards
c4505160a0 Catch more invalid cache source storage paths
OC\Files\Cache\Cache::get can return string|false|null, not just string|false.

- nextcloud/server#26270 added handling of false, but null is needed too.
- Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason

Related: nextcloud/server#19009

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2023-08-05 22:04:35 +00:00
Johannes Merkel
38ba696729 fix(mail): ContactManager search with fullmatch
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2023-08-02 21:36:10 +02:00
Arthur Schiwon
f361b5e215
Merge pull request #39597 from nextcloud/backport/38667/stable26
[stable26] fix(SystemTagManager): Use truncated tagName in getTag and updateTag
2023-08-02 21:18:26 +02:00
Arthur Schiwon
105d0663f9
Merge pull request #39437 from nextcloud/backport/39309/stable26
[stable26] fix(profile): fix getUID on nullable user variable
2023-08-02 21:16:31 +02:00
Arthur Schiwon
c174c47f1e
Merge pull request #39370 from nextcloud/backport/39339/stable26
[stable26] fix(node): non-existing folder is not searchable
2023-08-02 21:16:12 +02:00
Marcel Klehr
ce7641ebfc fix(SystemTagManager): Use truncated tagName in getTag and updateTag
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-27 17:13:41 +00:00
Benjamin Gaussorgues
25ba08b1d3
Add instance category while checking new updates
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-07-21 12:06:49 +02:00
Joas Schilling
4a21e41313
fix(apps): Fix loading info.xml file
Ref: https://bugs.php.net/bug.php?id=62577

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-20 10:47:45 +02:00
Thomas Citharel
5a6447645a fix(profile): fix getUID on nullable user variable
As per method signature, $visitingUser is nullable, so we can't be sure calling getUid() on it will
work.

Closes #35766

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-07-17 13:33:58 +00:00
Arthur Schiwon
6eaaef1403 fix(node): non-existing folder is not searchable
the previosuly introduced searchBySystemTag was not overwritten in
NonExistingFolder and could run the inherited method.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-13 14:33:05 +00:00
Julius Härtl
c7a8c3b427
Merge pull request #39232 from nextcloud/backport/39202/stable26 2023-07-10 18:08:23 +02:00
Arthur Schiwon
1c59a7a5db
Merge pull request #39031 from nextcloud/backport/38917/stable26
[stable26] fix(l10n): Fix plural issue with different locale and language
2023-07-10 18:05:48 +02:00
Arthur Schiwon
91a44763bd
Merge pull request #39100 from nextcloud/backport/39093/stable26
[stable26] Silent `imagecreatefromstring()` errors
2023-07-10 17:59:29 +02:00
Arthur Schiwon
48f27a90bd
Merge pull request #39270 from nextcloud/backport/35915/35915-stable26
[stable26] display displayname on federated shares
2023-07-10 17:49:34 +02:00
Maxence Lange
b9a25ce4d5 display displayname on federated shares
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-07-10 10:57:26 -01:00
Joas Schilling
ddff2e692d
fix(dav): Abort requests with 429 instead of waiting
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-10 06:32:01 +02:00
Arthur Schiwon
fc9fd0d7f2
refactor: adjust to unexposed searchBySystemTag
- in this backport we have to drop the breaking addition in
  \OCP\Files\Folder
- this requires adjustments in check for the existance of the method but
  also in testing
- another change in \OCP\SystemTag\ISystemTagManager can be applied as
  this interface is not implemented elsewhere

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-07 16:58:07 +02:00
Arthur Schiwon
749efc1ba1 fix: cominbation of small fixes
- possible null return
- parameter name mismatch in implementation
- incomplete unit test

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-07 14:54:56 +00:00
Arthur Schiwon
0b4db60d3b fix: include invisible tags for admins
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-07 14:54:56 +00:00
Arthur Schiwon
48c92ade85 fix: favorites view and universal search against tags
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-07 14:54:56 +00:00
Arthur Schiwon
c33f728249 fix: change if with conditionless else to switch; and a parameter value
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-07-07 14:54:55 +00:00