upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-25 02:34:12 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 9
73785 commits 982 branches 1211 tags 8.6 GiB
Commit graph

6973 commits

Author SHA1 Message Date
Louis
64583a0f86
Merge pull request #48985 from nextcloud/backport/47986/stable28 
[stable28] perf(ObjectStoreStorage): Improve (slow) move on same object bucket
 2024-10-31 15:57:22 +01:00
Côme Chilliet
ab611a279a
fix(tests): Fix most obvious errors in ObjectStore tests 
Some are still failing

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-31 14:41:19 +01:00
Christoph Fiehe
dec5a5fe9b perf(ObjectStoreStorage): Improve (slow) move on same object bucket 
This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.

The behavior improves a lot with https://github.com/nextcloud/server/pull/46013. However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.

Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
 2024-10-29 15:53:48 +00:00
Robin Appelman
accf707659 test: add test for nested jail cross-storage move 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-10-29 10:36:33 +00:00
yemkareems
a3abe2c4e1
fix: crypto added manually as expected 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-28 18:48:14 +05:30
yemkareems
e253479d83 fix: crypto type made not nullable and tests run using ICrypto 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-28 12:34:36 +00:00
yemkareems
be581d7ce8 fix: encrypt and store password, decrypt and retrieve the same 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-28 12:34:36 +00:00
Joas Schilling
24f8fd333e
Merge pull request #48762 from nextcloud/backport/48539/stable28 
[stable28] fix(message): Fix logic of Mail test
 2024-10-17 21:34:24 +02:00
Ferdinand Thiessen
86ed7aada1
Merge pull request #48739 from nextcloud/backport/48673/stable28 
[stable28] fix(share): Return empty string if no label is set
 2024-10-17 19:49:26 +02:00
Ferdinand Thiessen
788233c3d7
fix(share): Return empty string if no label is set 
* Resolves: https://github.com/nextcloud/server/issues/48629

While the database supports NULL, the typing has always said it only returns *string*.
So to not break any apps that might trust the typings we should return `''` if the database is set to `NULL`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-17 18:47:56 +02:00
provokateurin
c42ec8d0d2
fix(UserTrait): Fix backend initialization 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-17 17:59:20 +02:00
Joas Schilling
d518cedafd fix(message): Fix logic of Mail test 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-17 12:44:43 +00:00
Ferdinand Thiessen
229deb0497
fix: Make user removal more resilient 
Currently there is a problem if an exception is thrown in `User::delete`,
because at that point the user is already removed from the backend,
but not all data is deleted.

There is no way to recover from this state, as the user is gone no information is available anymore.
This means the data is still available on the server but can not removed by any API anymore.

The solution here is to first set a flag and backup the user home,
this can be used to recover failed user deletions in a way the delete can be re-tried.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-15 16:43:19 +02:00
Louis Chemineau
2a27a4129c fix(tests): UserManager constructor arguments 
After https://github.com/nextcloud/server/pull/48283

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-10-08 18:14:26 +02:00
Côme Chilliet
ec0ff3d5dd fix(tests): Fix Folder tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-08 18:14:26 +02:00
Robin Appelman
b8464efa69 test: put parent items into cache in tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-10-08 18:14:26 +02:00
Robin Appelman
f1df40f718 test: fix incorrect ltrim usage in test 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-10-08 18:14:26 +02:00
Richard Steinmetz
8752c3de79
fix: gracefully parse non-standard trusted certificates 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2024-09-30 09:17:25 +02:00
Louis Chemineau
483eaa7e72
fix(users): Don't crash if disabled user is missing in the database 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-09-23 16:59:58 +02:00
Robin Appelman
6baa60a5dd
Merge pull request #48099 from nextcloud/backport/46140/stable28 
[stable28] fix(config): Add missing handling for `envCache` in `getKeys()`
 2024-09-23 07:27:44 +02:00
Josh Richards
cf752657ee fix(config): add envCache tests for getKeys() 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2024-09-16 14:56:12 +00:00
provokateurin
1b5a56df48 fix(Entity): Fix magic setter call for custom strong typed setters 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-16 13:52:41 +00:00
Joas Schilling
25d70bf77f fix(config): Throw PreconditionException always when it didn't match 
Previously even when the precondition did not match, the call "passed"
when the after value was the expected one. This however can lead to
race conditions, duplicate code excutions and other things.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-09-13 11:41:53 +00:00
provokateurin
e77ac5c8e1 fix(files): Create non-existent parents of mountpoints 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-04 18:01:36 +00:00
Arthur Schiwon
15f160f8b9
Revert "Revert "[stable28] Apply group limit on remove from group"" 2024-08-19 16:11:38 +02:00
Arthur Schiwon
f2559e4480
Revert "[stable28] Apply group limit on remove from group" 2024-08-19 15:27:34 +02:00
Côme Chilliet
c999fea57c fix: Remove call to non-existing method in 28 and add missing use in test 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-08-19 10:33:11 +02:00
Côme Chilliet
1cf8815237 fix(tests): Fix PHP 8.0 compatibility 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-08-19 10:33:11 +02:00
Côme Chilliet
716ecf4e37 fix(tests): Adapt tests to change of DefaultShareProvider constructor 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-08-19 10:33:11 +02:00
Ferdinand Thiessen
e102c752f9 fix: OCP\Files\Node\Folder::search was not setting the owner 
The owner was not set on the file info causing e.g. webdav searches to never return the known owner.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-30 11:05:22 +00:00
Andy Scherzinger
c8961c7160
Merge pull request #46763 from nextcloud/backport/46672/stable28 
[stable28] Avoid using partial file info as valid one
 2024-07-28 12:14:48 +02:00
Julius Härtl
7f9b44d6a5 fix: Ignore preview requests for invalid file ids 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-07-25 17:40:12 +00:00
Hoang Pham
da0353dc6a feat: support excalidraw file 
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
 2024-07-25 16:59:25 +07:00
Hoang Pham
b3143bf930 feat: support excalidraw file 
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
 2024-07-25 16:59:24 +07:00
Joas Schilling
b087e140e6
fix(mail): Fix big logos in mail templates for Outlook 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-07-19 10:11:43 +02:00
Benjamin Gaussorgues
8df095f368 feat: don't count failed CSRF as failed login attempt 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-07-11 14:27:08 +02:00
Daniel Kesselberg
ee65749138
test: run tests in child process 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-07-11 00:25:32 +02:00
Andy Scherzinger
e319057a93
Merge pull request #45955 from nextcloud/backport/45228/stable28 
[stable28] fix(settings): define a 'heartbeat' route, so SecurityHeaders can handle redirected root
 2024-07-10 22:29:01 +02:00
Andy Scherzinger
e57dd34846
Merge pull request #45920 from nextcloud/backport/45582/stable28 
[stable28] delete background jobs by id when cleaning up
 2024-07-10 22:26:43 +02:00
Côme Chilliet
82f9c66dfc fix(tests): Strong type property $router in RouterTest 
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
 2024-07-10 14:38:34 +02:00
Steve Mokris
1226e79cf1 fix(settings): define a 'heartbeat' route, so SecurityHeaders can handle redirected root 
Signed-off-by: Steve Mokris <steve@kosada.com>
 2024-07-10 14:38:34 +02:00
Robin Appelman
5a9e8e7d3f feat: add setup check for needed mimetype migrations 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-06-21 11:37:13 +02:00
Robin Appelman
1b346aa9a4 test: update DummyJobList 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-06-17 13:25:03 +02:00
Robin Appelman
0ab1cc5f17 refactor: make share manager buildable 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-06-13 18:34:51 +02:00
Daniel Kesselberg
01a6c9119e test: add tests for ProfilePageController 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-06-12 19:35:45 +02:00
John Molakvoæ
b9857b9a7f
Merge pull request #45817 from nextcloud/backport/45698/stable28 2024-06-12 16:30:45 +02:00
Arthur Schiwon
b54668be35
Merge pull request #45704 from nextcloud/backport/43942/stable28 
[stable28] fix(Session): avoid password confirmation on SSO
 2024-06-12 14:31:37 +02:00
skjnldsv
f1f2f5ca98 fix(files_sharing): dark avatar support 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-06-12 13:30:16 +02:00
Arthur Schiwon
4ec174197f
fix(Token): make new scope future compatible 
- "password-unconfirmable" is the effective name for 30, but a draft
  name was backported.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2024-06-12 11:25:35 +02:00
Arthur Schiwon
86a496d589
fix(Session): avoid password confirmation on SSO 
SSO backends like SAML and OIDC tried a trick to suppress password
confirmations as they are not possible by design. At least for SAML it was
not reliable when existing user backends where used as user repositories.

Now we are setting a special scope with the token, and also make sure that
the scope is taken over when tokens are regenerated.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2024-06-12 11:14:25 +02:00