upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-03 20:41:22 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 26
54680 commits 651 branches 1179 tags 8.1 GiB
Commit graph

4443 commits

Author SHA1 Message Date
Georg Ehrke
5b26487f14
Expose status via Collaborators API 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
 2020-08-14 17:04:52 +02:00
Gary Kim
5559570faf
Merge pull request #22242 from nextcloud/techdebt/noid/remove-deprecated-methods 
Remove deprecated and unused method calls
 2020-08-14 10:10:53 +08:00
Morris Jobke
8e249569af
Fix existing test and add a specific one for the new case 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-13 23:24:21 +02:00
Morris Jobke
16d83ab30a
Remove getLastJob from IJobList 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-13 21:50:06 +02:00
Morris Jobke
725fecee34
Merge pull request #21344 from nextcloud/fix/twofactor-cleanup-event 
Emit an event for every disabled 2FA provider during cleanup
 2020-08-13 07:25:01 +02:00
Morris Jobke
234b510652
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-12 13:55:19 +02:00
Morris Jobke
8fc877ff7d
Merge pull request #22117 from nextcloud/activity-settings-grouping 
allow grouping of activity settings
 2020-08-11 11:24:23 +02:00
Morris Jobke
45428e4948
Add config option to enable multibucket preview distribution 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-06 22:31:39 +02:00
Morris Jobke
159f28cd52
Mount the old previews in a separate folder for the multi bucket setup and check in them before using the actual locations 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-08-06 22:19:21 +02:00
Morris Jobke
519cd678ee
Merge pull request #22008 from elijahnyp/OCImage_Leak_Fix 
Ensured large image is unloaded from memory when generating previews
 2020-08-05 22:39:09 +02:00
Robin Appelman
227e362842
allow grouping of activity settings 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-08-05 16:13:03 +02:00
Georg Ehrke
0fad921840
Add user-status app 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
 2020-07-31 16:45:27 +02:00
Joas Schilling
bab4fb98eb
Fix overwriteService() for apps 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-28 09:38:43 +02:00
Elijah Martin-Merrill
56ed563b0c fix memory leak caused by not destroying image in Preview/Generate.php 
Signed-off-by: Elijah Martin-Merrill <elijah@nyp-itsours.com>
 2020-07-27 10:52:44 -04:00
Morris Jobke
a169bd243f
Merge pull request #21972 from nextcloud/techdebt/noid/cleanup-phpunit-warnings 
Fix PHPUnit deprecation warnings
 2020-07-23 21:38:22 +02:00
Morris Jobke
761cdf9877
Remove deprecated test of internal attributes via assertAttributeEquals in constructor tests 
I removed the tests completely because they just test that the constructor assigns the values to the internal properties. Nothing that should be cared about from the outside.

See https://github.com/sebastianbergmann/phpunit/issues/3339#issuecomment-428843322

It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-23 17:11:29 +02:00
Morris Jobke
7e6c0ec284
Use assertEqualsCanonicalizing instead of deprecated assertEquals parameter 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-23 17:11:29 +02:00
Morris Jobke
e4144e6b36
Remove deprecated test of internal attributes via assertAttributeEquals 
See https://github.com/sebastianbergmann/phpunit/issues/3339#issuecomment-428843322

It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-23 17:11:29 +02:00
Morris Jobke
0123cd0ae3
Use assertStringContainsString instead of assertContains on strings 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-23 17:11:29 +02:00
Robin Appelman
ad7798f9c9
use exceptions for error signaling in writeStream 
this remove the ambiguity when writing zero length files

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-23 15:24:52 +02:00
Robin Appelman
fcad692b4a
rollback cache rename if trashbin move fails 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-23 15:24:48 +02:00
Christoph Wurst
91e7f12088
Adjust apps' code to use the ContainerInterface 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-21 20:43:18 +02:00
Roeland Jago Douma
7d7ba61625
Add real events to load additionalscripts 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-15 14:07:18 +02:00
Julius Härtl
81e5593133
Move to lazy panel registration during registration context 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-07-15 09:27:57 +02:00
Christoph Wurst
f03f88b437
Delegate bootstrap registration lazily 
* Keep the registration context
* Expose the context object for other components
* Ensure registration is only run once

Search providers are migrated for demonstration.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-14 15:33:32 +02:00
Roeland Jago Douma
10d862e243
Merge pull request #21759 from nextcloud/enh/lazy_subscription 
Make the subscription registry lazy
 2020-07-09 15:43:48 +02:00
Daniel Kesselberg
d9f5fdb67a
Add DummySubscription for tests 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-07-09 14:24:00 +02:00
Roeland Jago Douma
725872c23a
Make the subscription registry lazy 
This will allow to do lazy registration here which should allow for
loading less (or at least only when needed!).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-09 12:21:06 +02:00
Robin Appelman
37c334a2a6
ensure mounts are scanned during tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2020-07-09 11:14:44 +02:00
Roeland Jago Douma
43efac345e
Use the correct mountpoint to calculate 
If we use the owners mount point this results in null. And then the rest
of the checks get called with null. Which doesn't work.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-09 11:14:44 +02:00
Roeland Jago Douma
3f447b9c8c
Fix supporting defaults for routes 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-08 19:52:45 +02:00
Roeland Jago Douma
edc1c77dd9
Do not create a RouteActionHandler object for each route 
This is not required and doesn't allow us to be properly lazy. On top of
it this doesnt allow us to cache the routes (since closures/objects
can't be cached).

This is the first small step into cleaning up the routing we have

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-07-07 12:33:22 +02:00
Holger Hees
e70249e089
Update SecurityMiddleware.php 
OC::$WEBROOT can be empty in case if your nextcloud installation has no url prefix. This will result in an empty Location Header.

in other areas OC::$WEBROOT is always used together with an /
 2020-07-06 21:34:46 +02:00
Morris Jobke
e20db42a0c
Tags.php and the old sharing mechanism 
The old sharing mechanism isn't working anymore, because it was replaced by Share 2.0. Also it was nowhere used so this removes the code paths and reduces complexity.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-06 14:12:12 +02:00
Christoph Wurst
4a3ea04baa
Callable parameter injection 
This is like what we have to DI and classes, but for callables.

The motivating factor is to get rid of *service locators* in the `boot`
method of apps as a new pattern is about to emerge where we have lots of
`query` calls on the app or server container in order to fetch some
services.

With this little helper it's possible to call another (public) method
and magically have everything injected.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-03 14:37:46 +02:00
Roeland Jago Douma
d53e005458
Merge pull request #21360 from nextcloud/root-storage-prevent-scanning 
prevent the root storage from accidentally scanning user folders
 2020-07-02 21:07:16 +02:00
Roeland Jago Douma
0157e30ad4
Merge pull request #21599 from nextcloud/debt/noid/type-to-types 
Replace TYPE with TYPES
 2020-07-02 12:21:01 +02:00
Roeland Jago Douma
0ac3a65f62
Merge pull request #21653 from nextcloud/bugfix/noid/fix-ipv6-remote-addresses-from-x-forwarded-for-header 
Fix IPv6 remote addresses from X_FORWARDED_FOR headers before validating
 2020-07-02 12:01:24 +02:00
Joas Schilling
74a9cadc50
Fix IPv6 remote addresses from X_FORWARDED_FOR headers before validating 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-07-02 11:13:13 +02:00
Daniel Kesselberg
87dd760a89
Replace TYPE with TYPES 
As TYPE::* is deprecated.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2020-06-30 23:46:22 +02:00
Joas Schilling
1336f44a68
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-26 16:13:09 +02:00
Joas Schilling
b7060be18d
Fix robots "noindex, nofollow" signals 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-25 08:29:43 +02:00
Joas Schilling
a2f34f46b2
Fix tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-24 18:13:37 +02:00
Joas Schilling
89ed2c37bf
Update share type constant usage 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-24 16:49:16 +02:00
Christoph Wurst
4488e846a5
Add unified search API 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-06-24 14:20:25 +02:00
Joas Schilling
95652d4469
Fix language in share notes email for users 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-23 22:01:40 +02:00
Joas Schilling
8ec1b8132e
Merge pull request #21452 from nextcloud/bugfix/21451/allow-autocomplete-by-displayname-again 
Fix autocomplete for LDAP with `shareapi_only_share_with_group_members` on
 2020-06-23 14:02:17 +02:00
blizzz
859941db32
Merge pull request #21479 from nextcloud/fix/21474/allow_specifying_cookie_type 
Allow to specify the cookie type for appframework responses
 2020-06-22 13:00:12 +02:00
Roeland Jago Douma
fbf9772a3e
Allow to specify the cookie type for appframework responses 
In general it is good to set them to Lax. But also to give devs more
control over them is not a bad thing.

Helps with #21474

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-06-22 08:38:44 +02:00
Roeland Jago Douma
c006b5ff2a
Fix unit test of the ResponseTest 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-06-21 09:44:56 +02:00