upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-14 00:04:57 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 32
68045 commits 695 branches 1185 tags 6.5 GiB
Commit graph

1178 commits

Author SHA1 Message Date
Maxence Lange
6c98f951d5 getStorage before remove 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2023-07-13 10:18:31 -01:00
Simon L
fa4d153610
Merge pull request #38115 from DerGenaue/patch-1 
Rename `numericStorageId` to `numericExternalStorageId` in PersonalMount.php
 2023-05-16 19:08:39 +02:00
Robin Appelman
2466724b01
check the username when doing external storage session auth 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-05-11 17:47:56 +02:00
Daniel
55d7add92f
Rename numericStorageId to numericExternalStorageId in PersonalMount.php 
so that it doesn't override `numericStorageId` in the `MountPoint` baseclass

fixes https://github.com/nextcloud/server/issues/37473
fixes https://github.com/nextcloud/server/issues/37414

Signed-off-by: Daniel <7558512+DerGenaue@users.noreply.github.com>
 2023-05-07 04:47:44 +02:00
Louis
c0076d9cc0
Merge pull request #37717 from nextcloud/artonge/fix/dont_override_stored_credentials_with_saml 
Do not override stored credentials when login in with SAML
 2023-04-24 11:30:43 +02:00
Robin Appelman
60cf0c8f5f
add command for getting fileinfo for debugging 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-17 16:23:52 +02:00
Julius Härtl
140c2541ed
Merge pull request #37611 from ZE3kr/patch-1 
Unquote S3 ETag stored in oc_filecache
 2023-04-14 16:20:44 +02:00
Louis Chemineau
fec8ad8441 Do not override stored credentials when login in with SAML 
When login in with SAML, the password from `$event->getPassword()` is `null`.

This PR makes sure that this `null` value won't be used to override the stored password even though it is different.

This PR also allow for the password and user to be updated even though they were not set before.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-04-13 18:05:37 +02:00
Robin Appelman
570b64aafc
handle not being able to write file for notify self-test 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-06 11:52:22 +02:00
James Guo
bb173e092b
Update AmazonS3.php 
Signed-off-by: James Guo <i@ze3kr.com>
 2023-04-06 14:34:08 +08:00
Robin Appelman
b1f352c614
improve handling of files we can't access in the scanner 
instead of erroring, remove the items from the cache.

this situation can be triggered if a user has access to a file but looses it afterwards

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-04-05 14:44:55 +02:00
Robin Appelman
fd0ef588b4
fix ftp external storage with filezilla server 
- filezilla doesn't like "" as parameter for `mdtm` (all others seem fine)
- filezilla sends fractional modified date

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-03-30 17:44:47 +02:00
Côme Chilliet
308fcf4526
Respect OCP interface in private classes 
Because the parameter type was moved to phpdoc it needs to be removed
 from implementations

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:35 +01:00
Côme Chilliet
ff776a90b1
Strong type filesize related methods to ease 32bits problem findings 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:28 +01:00
Côme Chilliet
0c466b7ff5
Attempt at reducing psalm errors 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:22:09 +01:00
Vincent Petry
f0b9b6ebaa
Merge pull request #36089 from nextcloud/enh/noid/ext-storage-default-values 
Ext storage configs default value support + enable SSL by default
 2023-01-16 14:22:16 +01:00
Vincent Petry
4e179e0e07
Enable SSL by default in ext storage configs 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2023-01-13 10:27:17 +01:00
Vincent Petry
a0f70988f4
Extend ext storage params to contain default value 
Extend the external storage configuration parameters definition to allow
to specify a default value

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2023-01-13 10:27:17 +01:00
François Ménabé
710f3fd405 Support of s3 storage class in External Storage application 
Signed-off-by: François Ménabé <francois.menabe@gmail.com>
 2023-01-12 14:59:13 +01:00
Côme Chilliet
9430899f16
Fix psalm issues related to signature changes from PHP 8.0 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-29 12:36:34 +01:00
Carl Schwan
5e31ed4f52 Add comments 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-12-05 15:26:36 +01:00
Carl Schwan
754cb58b12 Fix migration to non-empty secret 
Add a fallback for empty keys

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-12-05 11:28:52 +01:00
Robin Appelman
ed8fedc685
fix s3 directory copy 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-11-15 17:17:59 +01:00
Côme Chilliet
9ba9f9a7dc
Make sure to not pass null to DateTime::createFromFormat 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-14 16:23:50 +01:00
Carl Schwan
a5ea677370 Rename file1 and file2 to source and target in Storage abstraction 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-18 17:21:47 +02:00
Carl Schwan
732badf552 Additional type hinting found by psalm 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-18 12:28:34 +02:00
Carl Schwan
94a0b27000 Specify type to internal storage class 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 11:53:11 +02:00
Carl Schwan
7da806d6eb Fix returning null when getMessage return null 
Don't overwrite $message but instead create another temporary variable

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 11:53:11 +02:00
Carl Schwan
9319bbb00c More type safety 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 11:53:11 +02:00
Carl Schwan
5b3509dc05 Fix type of getVisibilityType 
This is a int not a string

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 10:58:27 +02:00
Carl Schwan
c2c63a551f Fix usage of streams 
always return a bool and type the handle as a string

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 10:58:27 +02:00
Carl Schwan
74e6976779 Use argument name from parent class 
This will be an issue with php 8, so best to fix it now

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 10:58:27 +02:00
Carl Schwan
c94f9f5e5f Add corresponding interface to trait 
Since we can't specify that we want a class implementing a trait yet in
PHP

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 10:58:27 +02:00
Carl Schwan
2d75321c23 Add more typing to FilesExternal commands 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-17 10:58:25 +02:00
Carl Schwan
cf1381a6f9 Port away from deprecated clearBucket call 
This was removed a long time ago in the library that we use, but never
detected since this was inside a try catch block...

Remove the call for now and we should investigate newer api in the
future.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-16 23:39:49 +02:00
Carl Schwan
1d90f84141 Port to LoggerInterface 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-16 23:39:28 +02:00
Carl Schwan
ff4c8e9bee Force cast getCode to int 
Otherwise psalm complains that the type can also be a non-falsy-string

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-16 23:38:31 +02:00
Carl Schwan
c4bb69c143 Specify that userId can be null 
This fixes a psalm false-positive where the method is called with null, since
the method actually handle this correctly already

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-16 23:35:33 +02:00
Carl Schwan
d4d1952f67 Fix return value of updateParent 
Port to executeStatement to guarantee that we will return an int and
remove a deprecated method call at the same time

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-16 23:33:52 +02:00
Carl Schwan
a40ca520d4 Port away from removed IDBConnection->isConnected method 
Instead track if the reconnection was successful with return value of
connect method

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-16 23:32:55 +02:00
Carl Schwan
386ef04e42 Fix too many arguments in LegacyDependencyCheckPolyfill 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-16 23:29:38 +02:00
luz paz
9d26671f05 Fix typos in apps/ subdirectory 
Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`

Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
 2022-09-05 12:59:54 +00:00
Robin Appelman
c2b206db64
add marker interface to mark system mount points for encryption 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-08-25 13:55:53 +02:00
Matthieu Gallien
54c05bcdb9 handle AccessDenied error when checking if external s3 support versions 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-07-28 09:20:12 +00:00
Carl Schwan
d5c23dbb9f Move CappedMemoryCache to OCP 
This is an helpful helper that should be used in more place than just
server and this is already the case with groupfodlers, deck, user_oidc
and more using it, so let's make it public

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-07-14 15:54:31 +02:00
Louis
259b2806bc
Merge pull request #32016 from nextcloud/fix/PasswordUpdatedEvent_handling 
Use stored user for PasswordUpdatedEvent
 2022-05-16 12:38:49 +02:00
Carl Schwan
ec6b83cc18 Add stricter psalm type for CappedMemoryCache 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-12 15:06:18 +02:00
Carl Schwan
f945c0cbc6 Add a public replacement for OC::$server->get 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-05-10 18:51:12 +02:00
Louis Chemineau
816e7827f0 Use stored user for PasswordUpdatedEvent 
When handling PasswordUpdatedEvent event, we are calling getLoginName which does not exists.

This PR adds a condition to use the previously stored user when handling PasswordUpdatedEvent.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-05-10 12:16:33 +02:00
Vincent Petry
bccb69f806
Merge pull request #30860 from nextcloud/smb-getdirectory-content-catch 
handle notfound and notpermitted error in Smb::getDirectoryContent
 2022-04-14 20:26:17 +02:00