upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-24 15:53:36 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 11
68045 commits 867 branches 1197 tags 8.3 GiB
Commit graph

5263 commits

Author SHA1 Message Date
Côme Chilliet
4393b96542
Remove unused method getLocalFolder 
It’s not used and not in any OCP interface/class.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:34 +02:00
Côme Chilliet
966a3e6963
Tidy up typing in OC\Files\View 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:33 +02:00
Joas Schilling
454281af03
feat(security): Allow to opt-out of ratelimit protection, e.g. for testing on CI 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-04-03 09:06:45 +02:00
Arthur Schiwon
997c2a2a79
fix DBAL exception handling in setValues 
This seems to be a left over after abstracting DBAL. Nowadays,
IQueryBuilder::executeStatement() only throws a \OCP\DB\Exception, where
previously original DBAL exceptions where thrown. These are now wrapped,
the orignal classes are now mapped to a reason.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-03-31 17:01:17 +02:00
Christopher Ng
4f8e916585 Add label for logo link 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2023-03-29 13:36:45 -07:00
Julius Härtl
8b4d49cf50
Merge pull request #36057 from nextcloud/feat/esm-js-scripts 2023-03-22 09:17:28 +01:00
Côme Chilliet
633ea018af
Fix BackgroundCleanupJobTest 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-03-20 10:21:44 +01:00
Joas Schilling
bfc37afed3
Merge pull request #36928 from nextcloud/techdebt/noid/bruteforce-protection-attribute 
feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple
 2023-03-16 19:33:13 +01:00
Arthur Schiwon
a30d7c51d3
Merge pull request #37227 from nextcloud/h1-dav-brute-force-protection 
chore: use local variable for remote address
 2023-03-15 15:11:53 +01:00
Artur Neumann
37cfccabc1
unit tests for Manager::invalidateTokensOfUser 
Signed-off-by: Artur Neumann <artur@jankaritech.com>
 2023-03-14 17:13:30 +01:00
Côme Chilliet
71328107da
Merge pull request #37029 from nextcloud/fix/chunk-objectids-in-systemtagobjectmapper 
Add chunking in SystemTagObjectMapper::getTagIdsForObjects
 2023-03-13 22:10:47 +01:00
Côme Chilliet
9b1d7794a8 Add chunking in SystemTagObjectMapper::getTagIdsForObjects 
This avoids crashing on Oracle with more than 1000 objects

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-03-13 17:36:10 +00:00
Thomas Citharel
f1751c4428
Introduced app enable/disable/update typed events 
OCP\App\ManagerEvent is depreciated since 22 without a replacement

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2023-03-13 11:52:57 +01:00
Daniel Kesselberg
39c1b6f49f
chore(tests): add tests for handleLoginFailed 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2023-03-10 18:04:39 +01:00
Joas Schilling
2b49861679
Add a debug message when throttling without defining 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-03-08 12:09:22 +01:00
Joas Schilling
e839eb9b5c
feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-03-08 12:09:22 +01:00
Joas Schilling
c297f8ee96
feat(appframework): ⌚ Make ITimeFactory extend \PSR\Clock\ClockInterface 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-03-03 15:37:13 +01:00
Joas Schilling
de64c96a67
Merge pull request #36941 from nextcloud/bugfix/prevent-error-with-oracle-database 
Split the comments ids by chunks
 2023-03-03 12:37:15 +01:00
blizzz
289fadfd50
Merge pull request #36803 from nextcloud/fix/sqlite-comments 
[db]: Remove not supported column comments for SQLite
 2023-03-02 12:10:19 +01:00
Vitor Mattos
e9295f739e Split the comments ids by chunks 
Split the comments ids by chunks to prevent error with Oracle database
that can't do a query with more than 1000 parameters.

https://github.com/nextcloud/spreed/issues/8287

Signed-off-by: Vitor Mattos <vitor@php.rio>
 2023-03-01 13:08:17 -03:00
Ferdinand Thiessen
1785a80754 tests(db): Add test case to ensure column comments work 
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-02-28 10:39:13 +01:00
Marcel Klehr
4f7d77406d Fix SystemTagManagerTest#createTag test 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-02-24 14:40:33 +01:00
Marcel Klehr
889caf4632
Update tests/lib/SystemTag/SystemTagManagerTest.php 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-02-24 14:22:41 +01:00
Marcel Klehr
8151b1b8b0 fix(SystemTagManager): Truncate overlong tag names 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-02-24 12:55:10 +01:00
Ferdinand Thiessen
b642137c65 feat(OC/Template): Add type="module" for ES6 scripts 
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-02-22 21:19:37 +01:00
Ferdinand Thiessen
00e041b907 feat(template): Allow JSResourceLocator to find ES6 scripts 
Enable module js (ES6) support on the `JSResourceLocator`.
This changes `JSResourceLocator` to look for `.mjs` files first
to allow applications to provide a fallback `.js` for older Nextcloud versions.

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-02-22 21:19:37 +01:00
Joas Schilling
98ed72b3ed
Revert "fix(performance): Do not set up filesystem on every call" 2023-02-21 07:36:43 +01:00
Julius Härtl
614981ae9a
feat(directediting): Allow opening by file id 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-02-20 12:16:34 +01:00
Anna Larch
5d4efb4d5f
Do not set up filesystem on every call 
Also remove old Oc_FileChunking logis that produced GC- collectable chunks

Signed-off-by: Anna Larch <anna@nextcloud.com>
 2023-02-17 19:18:37 +01:00
Julius Härtl
47bc024885
Revert the token scope to not end up with storing the user used in the session 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-02-17 10:18:18 +01:00
Julius Härtl
90d2cb09b1
Merge pull request #36396 from nextcloud/fix/cors 2023-02-17 09:42:08 +01:00
Ferdinand Thiessen
f655f83c84 fix(CORS): CORS should only be bypassed on PublicPage if not logged in to prevent CSRF attack vectors 
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-02-16 22:55:18 +01:00
Louis
98b998a2de
Merge pull request #36735 from nextcloud/fix/32635/fix-vcf-contacts 
fix the contacts-menu vcf-contact avatars
 2023-02-16 14:01:19 +01:00
Simon L
b38d2daede fix the contacts-menu vcf-contact avatars 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-02-15 23:16:43 +01:00
MichaIng
5f90b8eb11
Change X-Robots-Tag header from "none" to "noindex, nofollow" 
While "none" is indeed equivalent to "noindex, nofollow" for Google, but seems to be not supported by Bing and probably other search engines.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name#other_metadata_names
https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag?hl=de#comma-separated-list
https://www.bing.com/webmasters/help/which-robots-metatags-does-bing-support-5198d240

Signed-off-by: MichaIng <micha@dietpi.com>
 2023-02-15 20:16:51 +01:00
Julius Härtl
a705132c8d
Merge pull request #36656 from nextcloud/route-instrumentation 2023-02-14 10:12:19 +01:00
Robin Appelman
b911da3e1e
DI for Router 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-02-13 22:51:14 +01:00
Robin Appelman
936f634069
Merge pull request #36643 from nextcloud/fs-setup-instrimuntion 
more filesystem setup performance instrumentation
 2023-02-13 14:37:57 +01:00
Robin Appelman
91d5f6a826 more filesystem setup performance instrumentation 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-02-10 11:11:13 +01:00
Joas Schilling
a81d8ecef5
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-02-09 16:15:47 +01:00
Julius Härtl
08802ad13f
Merge pull request #36566 from nextcloud/mount-find-by-numeric-id 2023-02-08 20:04:57 +01:00
Joas Schilling
dcfc96f0cc
Merge pull request #36417 from nextcloud/fix/psr-container 
Make the container fully fulfill PSR container interface
 2023-02-07 20:38:19 +01:00
Robin Appelman
9f3dbb699a fix tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-02-07 15:50:10 +01:00
Côme Chilliet
892e6c642a
Skip buggy tests for 32bits CI 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:33 +01:00
Côme Chilliet
77c8c9c805
Improve error output on failed Router test 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:31 +01:00
Côme Chilliet
94ecae4ade
Add helper to cast to int|float, fix MemoryInfo on 32bits 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:29 +01:00
Côme Chilliet
0f8c34cdc6
Fix filesize return type error in ViewTest 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:29 +01:00
Côme Chilliet
5cfab229db
Improve test failure output for RouterTest.php 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:29 +01:00
Côme Chilliet
2d8e696c24
Add apcu and ffmpeg to have less skipped tests 
Also exclude test groups which rely on a service

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:28 +01:00
Ferdinand Thiessen
ba8a50c059 fix: Throw NotFoundExceptionInterface to fulfill PSR container interface if class not found 
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-02-06 14:16:35 +01:00
Joas Schilling
47880b143d
Remove failing test that works with mocks only anyway 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-02-02 18:06:31 +01:00
Côme Chilliet
dde5c46a3e
Migrate to Symfony Mailer 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-02 10:30:06 +01:00
Julius Härtl
c246edece6
tests(oci): Test where statement on longtext column 
Signed-off-by: Julius Härtl <jus@bitgrid.net>

test: try with just passing the type to eq which should also cast

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-01-31 11:57:54 +01:00
Louis
2f3007205d
Merge pull request #35160 from nextcloud/artonge/feat/version_naming_backend 
Allow to name a version
 2023-01-30 10:40:49 +01:00
Joas Schilling
959e2aaa17
fix(tests): Fix method name in unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-01-30 09:12:50 +01:00
Christoph Wurst
20e00cdf17
feat(app-framework): Add UseSession attribute to replace annotation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-01-27 09:40:35 +01:00
Christoph Wurst
8d9af3e262
feat(app-framework): Add support for global middlewares 
This allows apps to register middlewares that always register, not just
for the app's own requests

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-01-26 11:54:28 +01:00
Louis Chemineau
d8b479752d Fix hookconnector tests 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-01-26 10:12:23 +00:00
Christoph Wurst
907ff68bfc
perf(app-framework): Make the app middleware registration lazy 
Before this patch, app middlewares were registered on the dispatcher for
every app loaded in a Nextcloud process. With the patch, only
middlewares belonging to the same app of a dispatcher instance are
loaded.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-01-25 09:27:24 +01:00
Côme Chilliet
f5c361cf44
composer run cs:fix 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:45:08 +01:00
Côme Chilliet
b22b6431d2
Fix gzip mimetype mapping 
PHP now detects it as application/gzip and not application/x-gzip anymore

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:22:11 +01:00
Côme Chilliet
7ebbb6b2ca
Remove workarounds specific to 7.4 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:22:08 +01:00
Christoph Wurst
20fcfb5739
feat(app framework)!: Inject services into controller methods 
Usually Nextcloud DI goes through constructor injection. This has the
implication that each instance of a class builds the full DI tree. That
is the injected services, their services, etc. Occasionally there is a
service that is only needed for one controller method. Then the DI tree
is build regardless if used or not.

If services are injected into the method, we only build the DI tree if
that method gets executed.

This is also how Laravel allows injection.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-01-18 14:00:38 +01:00
blizzz
dbfe7b1816
Merge pull request #36073 from nextcloud/fix/fix-background-job-list 
Use a Generator for job list to fix background-job:list command
 2023-01-16 11:10:10 +01:00
Côme Chilliet
d74044f634
Fix API breakage by using a new method instead 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-12 17:18:59 +01:00
Côme Chilliet
75fca38e66
Fix BackgroundJob list tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-12 11:40:18 +01:00
Simon L
7271ec7acf spaces are allowed in userids 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-01-10 13:25:27 +01:00
Vincent Petry
42d9e087fb
Remove unused legacy ajax/list.php in files app 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
 2023-01-09 15:18:37 +01:00
Julius Härtl
18164ae516
Merge pull request #33898 from nextcloud/fix/authtoken-password-update 
PublickKeyTokenProvider: Fix password update routine with password hash
 2023-01-05 08:01:47 +01:00
Joas Schilling
97e33c2bd4
Fix unit tests of the ActionProviderStore 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-01-04 16:17:43 +01:00
Joas Schilling
8eca26012f
Show local time in avatar menu 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-01-04 11:09:58 +01:00
Marcel Klehr
adfe367106
PublickKeyTokenProvider: Fix password update routine with password hash 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-01-04 08:30:53 +01:00
Bennet Becker
4dc0957164
refactor AutoSubmittedValue to Headers\AutoSubmitted and adding 
header name to constants

Signed-off-by: Bennet Becker <dev@bennet.cc>
 2023-01-03 15:15:35 +01:00
Bennet Becker
411467af57
fix static-analysis error and formatting code 
Signed-off-by: Bennet Becker <dev@bennet.cc>
 2022-12-23 21:48:52 +01:00
Bennet Becker
c1c6d215c7
fix getAutoSubmitted return type and adding unit tests 
Signed-off-by: Bennet Becker <bbecker@pks.mpg.de>
 2022-12-23 19:26:49 +01:00
Simon L
bfb3b2af9f increase preview_max_memory and make it easier to debug 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2022-12-22 09:52:46 +01:00
Stanimir Bozhilov
7dcd6eb561
Merge branch 'master' into add-scim-json-support 
Signed-off-by: Stanimir Bozhilov <stanimir.bozhilov.1998@gmail.com>
 2022-12-19 09:07:38 +01:00
Vincent Petry
ae6fe874ed
Merge pull request #35780 from nextcloud/fix/http-dispatcher-double-parameter-cast 
Fix missing cast of double controller parameters
 2022-12-16 16:18:35 +01:00
Christoph Wurst
b6dd1a1d7b
fix(app framework): Fix missing cast of double controller parameters 
``settype`` allows 'double' as alias of 'float'.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2022-12-15 09:33:52 +01:00
Artur Neumann
81f2857f34
check if params given to API are really an array 
Signed-off-by: Artur Neumann <artur@jankaritech.com>
 2022-12-15 13:45:22 +05:45
Joas Schilling
2f7a1fca5f
Merge pull request #34477 from nextcloud/bugfix/noid/sharee-recommendations-show-group-id 
Show group name instead of group id as recommendation
 2022-12-09 22:39:28 +01:00
Julius Härtl
4bcaeb6c2c
Drop 3rdparty root since it is unused and adjust tests 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-12-07 23:55:32 +01:00
Julius Härtl
306d7829b5
Cache available languages locally 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-12-07 22:32:06 +01:00
Julius Härtl
87e638b1f8
Merge pull request #35649 from nextcloud/bugfix/object-storage-master-key-enc 
Update the unencrypted file size when closing streams
 2022-12-07 22:03:13 +01:00
Julius Härtl
3c8fb59fa4
Merge pull request #35620 from nextcloud/fix/fix-calendar-imip-tests 2022-12-07 20:39:41 +01:00
Julius Härtl
59ae6e9dd6
Also update the unencrypted size of files when creating them with empty content 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-12-07 19:12:06 +01:00
Julien Veyssier
4a3f3beb0b
use bruteforce protection on all methods wrapped by PublicShareMiddleware 
if an invalid token is provided or when share password is wrong

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
 2022-12-07 13:24:50 +01:00
Côme Chilliet
7cf1dec842
Fix errors in calendar tests saying function handleIMipMessage does not exists on ICreateFromString 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-06 13:52:13 +01:00
Côme Chilliet
1821712615
Merge pull request #35596 from nextcloud/fix/move-to-ocp-timedjob 
Use TimedJob from OCP instead of OC
 2022-12-06 12:14:43 +01:00
Côme Chilliet
ee06261b82
Fix codestyle in modified files 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-05 16:08:40 +01:00
Côme Chilliet
30560d3165
Merge branch 'master' into tests/fix-phpunit-warnings 
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
 2022-12-05 12:03:39 +01:00
Côme Chilliet
578648a062
Adapt tests to new job constructors 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-12-05 10:41:13 +01:00
J0WI
a4d0700bf2 Fix test image default quality 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2022-12-04 14:51:33 +01:00
Anna Larch
7c4ceb444c Add group display name cache 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2022-11-28 11:52:55 +00:00
Carl Schwan
e35bcc9381 Fix tests 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-11-22 10:06:19 +01:00
Joas Schilling
d1f2e5e967
Increase the fair-use push limit to 1.000 users 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-11-18 15:39:23 +01:00
John Molakvoæ
d27a39271e
getAppValue expects string 
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2022-11-17 08:03:05 +01:00
Git'Fellow
0f3150cff7
Tests adjustement 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2022-11-16 11:01:32 +01:00
Côme Chilliet
68363f6944
Fix some more problems with tests under PHP 8.2 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-15 16:02:24 +01:00
Côme Chilliet
324126888e
Add Union types for properties in tests/lib/Encryption/Keys/StorageTest.php 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-15 09:29:35 +01:00