upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-25 08:08:33 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 33
68045 commits 870 branches 1197 tags 8.4 GiB
Commit graph

6711 commits

Author SHA1 Message Date
Glandos
384a1d34a8 adapt test to new workflow 
getDirectoryListing should return all files
getFile is not called anymore

Signed-off-by: Glandos <bugs-github@antipoul.fr>
 2023-04-17 16:29:13 +02:00
jld3103
b153340b62
Add type hints for mappers 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-04-07 09:49:42 +02:00
John Molakvoæ
5b3900e849
fix(tests): acceptance 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2023-04-06 15:43:30 +02:00
Arthur Schiwon
1ac7a3f107
Merge pull request #37595 from jtrees/add-some-tests-to-lost-controller 
Add some tests for input trimming in LostController.php
 2023-04-06 11:12:52 +02:00
Côme Chilliet
8d5165e8dc
Adapt tests to config value typing 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-05 17:42:14 +02:00
Joshua Trees
a4032a3800 Add some tests for input trimming in LostController.php 
Signed-off-by: Joshua Trees <me@jtrees.io>
 2023-04-05 12:15:38 +02:00
Côme Chilliet
8f550398c4
Merge pull request #36836 from nextcloud/fix/view-type-cleanup 
Tidy up typing in OC\Files\View
 2023-04-05 10:14:55 +02:00
jld3103
d9f8522003
Fix types for reading and writing config values 
Signed-off-by: jld3103 <jld3103yt@gmail.com>
 2023-04-05 09:08:56 +02:00
Joas Schilling
131f481a67
fix(initial-state): Log an error when initial-state can not be JSON encoded 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-04-04 10:54:12 +02:00
Louis
7ab44b2d28
Merge pull request #37146 from nextcloud/artonge/feat/migrate_metadata_to_value 
Migrate metadata JSON column to new value TEXT column
 2023-04-04 10:23:54 +02:00
Joas Schilling
c5339fa336
Merge pull request #37542 from nextcloud/bugfix/noid/allow-to-opt-out-of-ratelimit-for-testing 
feat(security): Allow to opt-out of ratelimit protection, e.g. for te…
 2023-04-03 14:19:41 +02:00
Louis Chemineau
1a6709cf43 Migrate metadata as JSON to value as STRING 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-04-03 14:06:28 +02:00
Côme Chilliet
4393b96542
Remove unused method getLocalFolder 
It’s not used and not in any OCP interface/class.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:34 +02:00
Côme Chilliet
966a3e6963
Tidy up typing in OC\Files\View 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:33 +02:00
Joas Schilling
454281af03
feat(security): Allow to opt-out of ratelimit protection, e.g. for testing on CI 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-04-03 09:06:45 +02:00
Arthur Schiwon
997c2a2a79
fix DBAL exception handling in setValues 
This seems to be a left over after abstracting DBAL. Nowadays,
IQueryBuilder::executeStatement() only throws a \OCP\DB\Exception, where
previously original DBAL exceptions where thrown. These are now wrapped,
the orignal classes are now mapped to a reason.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-03-31 17:01:17 +02:00
Christopher Ng
4f8e916585 Add label for logo link 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2023-03-29 13:36:45 -07:00
Git'Fellow
346054f854
Fix tests 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2023-03-28 09:41:04 +02:00
Julius Härtl
8b4d49cf50
Merge pull request #36057 from nextcloud/feat/esm-js-scripts 2023-03-22 09:17:28 +01:00
Côme Chilliet
633ea018af
Fix BackgroundCleanupJobTest 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-03-20 10:21:44 +01:00
Joas Schilling
bfc37afed3
Merge pull request #36928 from nextcloud/techdebt/noid/bruteforce-protection-attribute 
feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple
 2023-03-16 19:33:13 +01:00
Arthur Schiwon
a30d7c51d3
Merge pull request #37227 from nextcloud/h1-dav-brute-force-protection 
chore: use local variable for remote address
 2023-03-15 15:11:53 +01:00
Artur Neumann
37cfccabc1
unit tests for Manager::invalidateTokensOfUser 
Signed-off-by: Artur Neumann <artur@jankaritech.com>
 2023-03-14 17:13:30 +01:00
Côme Chilliet
71328107da
Merge pull request #37029 from nextcloud/fix/chunk-objectids-in-systemtagobjectmapper 
Add chunking in SystemTagObjectMapper::getTagIdsForObjects
 2023-03-13 22:10:47 +01:00
Côme Chilliet
9b1d7794a8 Add chunking in SystemTagObjectMapper::getTagIdsForObjects 
This avoids crashing on Oracle with more than 1000 objects

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-03-13 17:36:10 +00:00
Thomas Citharel
f1751c4428
Introduced app enable/disable/update typed events 
OCP\App\ManagerEvent is depreciated since 22 without a replacement

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2023-03-13 11:52:57 +01:00
Daniel Kesselberg
39c1b6f49f
chore(tests): add tests for handleLoginFailed 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2023-03-10 18:04:39 +01:00
Joas Schilling
2b49861679
Add a debug message when throttling without defining 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-03-08 12:09:22 +01:00
Joas Schilling
e839eb9b5c
feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-03-08 12:09:22 +01:00
Joas Schilling
b4f51fe728
fix(CI): Fix acceptance test password field selector after @nextcloud/vue lib update 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-03-07 09:34:47 +01:00
Joas Schilling
c297f8ee96
feat(appframework): ⌚ Make ITimeFactory extend \PSR\Clock\ClockInterface 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-03-03 15:37:13 +01:00
Joas Schilling
de64c96a67
Merge pull request #36941 from nextcloud/bugfix/prevent-error-with-oracle-database 
Split the comments ids by chunks
 2023-03-03 12:37:15 +01:00
blizzz
289fadfd50
Merge pull request #36803 from nextcloud/fix/sqlite-comments 
[db]: Remove not supported column comments for SQLite
 2023-03-02 12:10:19 +01:00
Vitor Mattos
e9295f739e Split the comments ids by chunks 
Split the comments ids by chunks to prevent error with Oracle database
that can't do a query with more than 1000 parameters.

https://github.com/nextcloud/spreed/issues/8287

Signed-off-by: Vitor Mattos <vitor@php.rio>
 2023-03-01 13:08:17 -03:00
John Molakvoæ
0b966ab200
Merge pull request #36471 from nextcloud/fix/theming-keep-images 2023-03-01 09:54:49 +01:00
Ferdinand Thiessen
1785a80754 tests(db): Add test case to ensure column comments work 
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-02-28 10:39:13 +01:00
Marcel Klehr
4f7d77406d Fix SystemTagManagerTest#createTag test 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-02-24 14:40:33 +01:00
Marcel Klehr
889caf4632
Update tests/lib/SystemTag/SystemTagManagerTest.php 
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-02-24 14:22:41 +01:00
Marcel Klehr
8151b1b8b0 fix(SystemTagManager): Truncate overlong tag names 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-02-24 12:55:10 +01:00
Ferdinand Thiessen
b642137c65 feat(OC/Template): Add type="module" for ES6 scripts 
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-02-22 21:19:37 +01:00
Ferdinand Thiessen
00e041b907 feat(template): Allow JSResourceLocator to find ES6 scripts 
Enable module js (ES6) support on the `JSResourceLocator`.
This changes `JSResourceLocator` to look for `.mjs` files first
to allow applications to provide a fallback `.js` for older Nextcloud versions.

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-02-22 21:19:37 +01:00
Joas Schilling
98ed72b3ed
Revert "fix(performance): Do not set up filesystem on every call" 2023-02-21 07:36:43 +01:00
Ferdinand Thiessen
61b9ba28e4 Add webp and large jpg test assets 
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-02-20 13:11:19 +01:00
Julius Härtl
614981ae9a
feat(directediting): Allow opening by file id 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-02-20 12:16:34 +01:00
Anna Larch
5d4efb4d5f
Do not set up filesystem on every call 
Also remove old Oc_FileChunking logis that produced GC- collectable chunks

Signed-off-by: Anna Larch <anna@nextcloud.com>
 2023-02-17 19:18:37 +01:00
Julius Härtl
47bc024885
Revert the token scope to not end up with storing the user used in the session 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-02-17 10:18:18 +01:00
Julius Härtl
90d2cb09b1
Merge pull request #36396 from nextcloud/fix/cors 2023-02-17 09:42:08 +01:00
Ferdinand Thiessen
f655f83c84 fix(CORS): CORS should only be bypassed on PublicPage if not logged in to prevent CSRF attack vectors 
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-02-16 22:55:18 +01:00
Louis
98b998a2de
Merge pull request #36735 from nextcloud/fix/32635/fix-vcf-contacts 
fix the contacts-menu vcf-contact avatars
 2023-02-16 14:01:19 +01:00
Simon L
b38d2daede fix the contacts-menu vcf-contact avatars 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-02-15 23:16:43 +01:00
MichaIng
5f90b8eb11
Change X-Robots-Tag header from "none" to "noindex, nofollow" 
While "none" is indeed equivalent to "noindex, nofollow" for Google, but seems to be not supported by Bing and probably other search engines.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name#other_metadata_names
https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag?hl=de#comma-separated-list
https://www.bing.com/webmasters/help/which-robots-metatags-does-bing-support-5198d240

Signed-off-by: MichaIng <micha@dietpi.com>
 2023-02-15 20:16:51 +01:00
Julius Härtl
a705132c8d
Merge pull request #36656 from nextcloud/route-instrumentation 2023-02-14 10:12:19 +01:00
Robin Appelman
b911da3e1e
DI for Router 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-02-13 22:51:14 +01:00
Robin Appelman
936f634069
Merge pull request #36643 from nextcloud/fs-setup-instrimuntion 
more filesystem setup performance instrumentation
 2023-02-13 14:37:57 +01:00
Robin Appelman
91d5f6a826 more filesystem setup performance instrumentation 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-02-10 11:11:13 +01:00
Christopher Ng
c77998209f Port user menu to Vue 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2023-02-09 17:54:59 -08:00
Joas Schilling
a81d8ecef5
Fix unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-02-09 16:15:47 +01:00
Julius Härtl
08802ad13f
Merge pull request #36566 from nextcloud/mount-find-by-numeric-id 2023-02-08 20:04:57 +01:00
Joas Schilling
dcfc96f0cc
Merge pull request #36417 from nextcloud/fix/psr-container 
Make the container fully fulfill PSR container interface
 2023-02-07 20:38:19 +01:00
Robin Appelman
9f3dbb699a fix tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-02-07 15:50:10 +01:00
Côme Chilliet
892e6c642a
Skip buggy tests for 32bits CI 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:33 +01:00
Côme Chilliet
77c8c9c805
Improve error output on failed Router test 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:31 +01:00
Côme Chilliet
94ecae4ade
Add helper to cast to int|float, fix MemoryInfo on 32bits 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:29 +01:00
Côme Chilliet
0f8c34cdc6
Fix filesize return type error in ViewTest 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:29 +01:00
Côme Chilliet
5cfab229db
Improve test failure output for RouterTest.php 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:29 +01:00
Côme Chilliet
2d8e696c24
Add apcu and ffmpeg to have less skipped tests 
Also exclude test groups which rely on a service

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:28 +01:00
Joas Schilling
59578817f5
Merge pull request #36489 from nextcloud/bugfix/noid/brute-force-protection-password-reset 
Add bruteforce protection to password reset page
 2023-02-06 22:12:25 +01:00
Ferdinand Thiessen
ba8a50c059 fix: Throw NotFoundExceptionInterface to fulfill PSR container interface if class not found 
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
 2023-02-06 14:16:35 +01:00
Joas Schilling
875e6cf7e6
fix(CI): Adjust expected result 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-02-06 11:26:38 +01:00
Christoph Wurst
88d116ba84
fix(client-login-flow): Handle missing stateToken gracefully 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-02-06 09:42:15 +01:00
Joas Schilling
47880b143d
Remove failing test that works with mocks only anyway 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-02-02 18:06:31 +01:00
Côme Chilliet
dde5c46a3e
Migrate to Symfony Mailer 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-02 10:30:06 +01:00
Maxence Lange
1a655e88d9 use php8.0 images 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2023-01-31 15:44:12 -01:00
Julius Härtl
c246edece6
tests(oci): Test where statement on longtext column 
Signed-off-by: Julius Härtl <jus@bitgrid.net>

test: try with just passing the type to eq which should also cast

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-01-31 11:57:54 +01:00
Louis
2f3007205d
Merge pull request #35160 from nextcloud/artonge/feat/version_naming_backend 
Allow to name a version
 2023-01-30 10:40:49 +01:00
Joas Schilling
959e2aaa17
fix(tests): Fix method name in unit tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-01-30 09:12:50 +01:00
Christoph Wurst
20e00cdf17
feat(app-framework): Add UseSession attribute to replace annotation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-01-27 09:40:35 +01:00
Christoph Wurst
8d9af3e262
feat(app-framework): Add support for global middlewares 
This allows apps to register middlewares that always register, not just
for the app's own requests

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-01-26 11:54:28 +01:00
Louis Chemineau
d8b479752d Fix hookconnector tests 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2023-01-26 10:12:23 +00:00
Christoph Wurst
907ff68bfc
perf(app-framework): Make the app middleware registration lazy 
Before this patch, app middlewares were registered on the dispatcher for
every app loaded in a Nextcloud process. With the patch, only
middlewares belonging to the same app of a dispatcher instance are
loaded.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-01-25 09:27:24 +01:00
Christopher Ng
0236c9e8cd Port files sharing selector 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2023-01-24 17:40:17 -08:00
Côme Chilliet
003cc2b45a
Fix tests failures (number of calls differed with last rebase) 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-24 09:38:20 +01:00
Carl Schwan
a23cd7b961
Fix a bunch of deprecation in the phpunit for core 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2023-01-24 09:34:09 +01:00
Joas Schilling
1c099c7f17
Fix broken user:setting command unit test 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-01-23 07:01:22 +01:00
Côme Chilliet
f5c361cf44
composer run cs:fix 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:45:08 +01:00
Joas Schilling
89dbc629ff
Fix integrity check 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-01-20 11:22:11 +01:00
Côme Chilliet
de68fc6347
Update test file for mimetypes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:22:11 +01:00
Côme Chilliet
b22b6431d2
Fix gzip mimetype mapping 
PHP now detects it as application/gzip and not application/x-gzip anymore

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:22:11 +01:00
Côme Chilliet
7ebbb6b2ca
Remove workarounds specific to 7.4 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:22:08 +01:00
Joas Schilling
1e2441ff6b
Disable unreliable acceptance tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-01-19 09:21:33 +01:00
Christoph Wurst
20fcfb5739
feat(app framework)!: Inject services into controller methods 
Usually Nextcloud DI goes through constructor injection. This has the
implication that each instance of a class builds the full DI tree. That
is the injected services, their services, etc. Occasionally there is a
service that is only needed for one controller method. Then the DI tree
is build regardless if used or not.

If services are injected into the method, we only build the DI tree if
that method gets executed.

This is also how Laravel allows injection.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-01-18 14:00:38 +01:00
Christoph Wurst
f22101d421
Fix login loop if login CSRF fails and user is not logged in 
If CSRF fails but the user is logged in that they probably logged in in
another tab. This is fine. We can just redirect.
If CSRF fails and the user is also not logged in then something is
fishy. E.g. because Nextcloud contantly regenrates the session and the
CSRF token and the user is stuck in an endless login loop.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2023-01-18 09:39:17 +01:00
blizzz
dbfe7b1816
Merge pull request #36073 from nextcloud/fix/fix-background-job-list 
Use a Generator for job list to fix background-job:list command
 2023-01-16 11:10:10 +01:00
Christopher Ng
f6aa5224c4 Focus trap contacts menu with NcHeaderMenu port 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
 2023-01-13 23:19:28 +00:00
Joas Schilling
238e9cf3a8
feat(CI): Enforce colored output for acceptance tests on drone CI 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-01-13 11:31:13 +01:00
Côme Chilliet
d74044f634
Fix API breakage by using a new method instead 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-12 17:18:59 +01:00
Côme Chilliet
75fca38e66
Fix BackgroundJob list tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-12 11:40:18 +01:00
Simon L
7271ec7acf spaces are allowed in userids 
Signed-off-by: Simon L <szaimen@e.mail.de>
 2023-01-10 13:25:27 +01:00
Vincent Petry
42d9e087fb
Remove unused legacy ajax/list.php in files app 
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
 2023-01-09 15:18:37 +01:00
Julius Härtl
18164ae516
Merge pull request #33898 from nextcloud/fix/authtoken-password-update 
PublickKeyTokenProvider: Fix password update routine with password hash
 2023-01-05 08:01:47 +01:00