upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-04-29 01:50:33 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 51
61759 commits 895 branches 1201 tags 6.6 GiB
Commit graph

11840 commits

Author SHA1 Message Date
Julius Härtl
6fc0e39c5f
Merge pull request #35371 from nextcloud/backport/35250/stable23 
[stable23] Properly compare quota against both float/int values
 2022-11-24 08:23:54 +01:00
blizzz
d74e2b68a8
Merge pull request #35369 from nextcloud/backport/35353/stable23 
[stable23] Update cache when file size === 0
 2022-11-23 21:11:23 +01:00
Julius Härtl
48ec3477ee Properly compare quota against both float/int values 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-11-23 17:33:51 +00:00
Louis Chemineau
36243c5cbf Update cache when file size === 0 
The conditions were false when $result === 0.
$results here contains the number of written bits.
The correct way of checking for operation success is to check if $result === false

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-11-23 15:12:45 +00:00
Joas Schilling
4214458d97 Fix forwarding the object id when searching comments 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-11-23 10:42:35 +00:00
Christoph Wurst
9e82dceb66 Fix unsuccessful token login logged as error 
The condition of a non-existent login token can happen for concurrent
requests. Admins can not do anything about this. So this is to be
expected to happen occasionally. This event is only bad if none of the
requests is able to re-acquire a session. Luckily this happens rarely.

If a login loop persists an admin can still lower the log level to find
this info. But a default error log level will no longer write those
infos about the failed cookie login of one request.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2022-11-22 16:49:31 +00:00
Côme Chilliet
37d849694c
Merge pull request #35144 from nextcloud/backport/34160/stable23 
[stable23] Detect weird local ips
 2022-11-21 09:33:30 +01:00
Joas Schilling
21f0fde0de
Mark more config values as sensitive 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-11-16 10:08:59 +01:00
Julius Härtl
abe243e4b6
Merge pull request #35051 from nextcloud/backport/28610/stable23 
[stable23] Use storage filter when fetching previews to cleanup
 2022-11-15 19:14:06 +01:00
Côme Chilliet
6bdb5d2804
Pass default values to idn_to_utf8 to fix behavior under PHP 7.3 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-15 12:11:09 +01:00
Vincent Petry
b43f2b1d52
Merge pull request #35050 from nextcloud/backport/34834/stable23 
[stable23] Fix size calculation on copying the skeleton files
 2022-11-14 16:41:08 +01:00
Côme Chilliet
96d3d09444
Fix tests for nested v4 in v6 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-14 11:27:27 +01:00
Côme Chilliet
be070516a9
Use new dependency to normalize IPs 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-14 11:26:52 +01:00
Côme Chilliet
72f60a6f96
Add missing urldecode and idn_to_utf8 calls to local address checker 
The call to idn_to_utf8 call is actually to apply normalization

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-14 11:25:58 +01:00
Côme Chilliet
48a226cef3 Make sure that path is normalized and then checked, 
and not the other way around

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-10 18:00:31 +00:00
Julius Härtl
9f8a7a695a
Use storage filter when fetching previews to cleanup 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-11-09 13:14:35 +01:00
Julius Härtl
6ded6afa97
Use proper storage method for writing skeleton files 
otherwise the filecache will have a wrong size for skeleton files

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-11-09 13:11:46 +01:00
Côme Chilliet
ec6ed96fcb Suppress false-positives from psalm, waiting for fix upstream 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-07 10:13:38 +00:00
Côme Chilliet
2b0bc2bb2c Avoid a crash when a PHP extension has no version 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-07 10:13:35 +00:00
Vincent Petry
ca6eaebe85
Merge pull request #34660 from nextcloud/backport/34632/stable23 
[stable23] Add rate limiting on lost password emails
 2022-11-04 17:31:06 +01:00
Vincent Petry
ed827facd8
Merge pull request #34844 from nextcloud/backport/34302/stable23 
[stable23] Fix: Prevent deadlocks during mtime/size/etag propagation
 2022-11-04 17:23:01 +01:00
Côme Chilliet
19c1587ec4
Add rate limiting on lost password emails 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-11-03 16:45:37 +01:00
Julius Härtl
0d3a6b5213
Skip general login with email for non-valid addresses and LDAP 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-11-03 15:45:18 +01:00
raul
43185b5c4e Fix unencrypted size calculation for files created before the Encryption storage is enabled 
Signed-off-by: raul <raul@nextcloud.com>
 2022-10-27 12:56:25 +02:00
raul
a31a03ef52 Fix: Prevent deadlocks during mtime/size/etag propagation 
Signed-off-by: raul <raul@nextcloud.com>
 2022-10-27 12:45:09 +02:00
szaimen
53787e2d3b fix external storages access 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-10-23 09:32:56 +00:00
Côme Chilliet
e4ce2e71cc Correctly handle Redis::keys returning false 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-09-30 08:27:28 +00:00
blizzz
0ba3d38c8c
Merge pull request #33750 from nextcloud/backport/33734/stable23 
[stable23] remove leading slash for search results at mountpoint root
 2022-09-28 10:37:11 +02:00
blizzz
67181d6b01
Merge pull request #33786 from nextcloud/backport/33772/stable23 
[stable23] Log if cookie login failed with token mismatch or session unavailability
 2022-09-27 23:26:55 +02:00
Vincent Petry
187aeb6c36
Merge pull request #34102 from nextcloud/backport/33700/stable23 
[stable23] make groupfolders use system wide encryption keys
 2022-09-27 09:51:42 +02:00
Robin Appelman
35cc27ed21 dont try email login if the provider username is not a valid email 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-09-16 13:31:53 +00:00
Robin Appelman
5580ead535 make groupfolders use system wide encryption keys 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-09-15 21:02:16 +00:00
Carl Schwan
39ef21a6b8
Merge pull request #33982 from nextcloud/backport/33788/stable23 
[stable23] Improve getting recent files performance
 2022-09-13 12:23:10 +02:00
szaimen
5851c265a1 Do not empty config.php file if reading failed for any reason 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-09-12 11:01:38 +02:00
Carl Schwan
4d4a6727fc Filter out old files when trying to get recent files 
Only do so when asking for less than 100 files and having an offset
equal to 0.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-09-08 14:44:00 +00:00
blizzz
fe0756a7e1
Revert "[stable23] Compare lowercase email when updating from ldap" 2022-09-07 12:27:37 +02:00
Louis Chemineau
0b5619f132 I dug into it again, and the issue is much simpler than I previously though. 
- LDAP has an email address with capital letters
- NC store this address in lower case
- When the user logs in, we compare the [stored email with the new lower case email](https://github.com/nextcloud/server/blob/master/lib/private/AllConfig.php#L259-L261) before storing it. Here, both email will be the same, so we won't store the new email address with upper case letters. Which is what we want.
- We then [compare emails as they are before triggering an event](https://github.com/nextcloud/server/blob/master/lib/private/User/User.php#L202-L204), they won't match, so the user will receive an email signaling an email change every time he logs in.

The fix is to compare the old email with the new lower case email before sending the event.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-09-06 15:24:01 +00:00
blizzz
55f07a4d46
Merge pull request #32985 from nextcloud/backport/32242/stable23 
[stable23] Fix logging data context to file
 2022-09-01 09:47:35 +02:00
Christoph Wurst
2fbcc9184b Log if cookie login failed with token mismatch or session unavailability 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2022-09-01 07:34:30 +00:00
blizzz
9d9d5cb458
Merge pull request #33763 from nextcloud/backport/33603/stable23 
[stable23] optimize search post-processing for jail wrapper
 2022-08-31 16:46:46 +02:00
Joas Schilling
67ec2f4d8b
Merge pull request #32751 from nextcloud/backport/32744/stable23 
[stable23] Always log errors from sending federation api requests to ease debugging
 2022-08-30 20:36:14 +02:00
Thomas Citharel
54b0b53295
Fix logging data context to file 
It was only logged when an exception was provided or when using
logData (which is not being much used).

We make sure the interpolated parameters are not logged.

Only tested with file write logger, but shouldn't work differently.

Crash reporters always had the context.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2022-08-30 18:58:20 +02:00
Robin Appelman
d7858bfcf3 optimize search post-processing for jail wrapper 
don't both asking the wrapped cache if we know it's not in our jail anyway

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-08-30 15:51:29 +00:00
blizzz
1e80b33fa7
Merge pull request #33515 from nextcloud/backport/33513/stable23 
[stable23] Recover installation when creating the database user fails and improve password strength
 2022-08-30 17:37:29 +02:00
Robin Appelman
d414008b13 remove leading slash for search results at mountpoint root 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-08-30 10:28:02 +00:00
Arthur Schiwon
71394fc8cb logger ignore args of sharepoint-related methods 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2022-08-25 14:31:32 +00:00
Joas Schilling
2a206cd927
Create more secure passwords by default 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-08-12 11:28:10 +02:00
Joas Schilling
9a53d02ac2
Recover installation when creating the user failed 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2022-08-12 11:27:31 +02:00
Julius Härtl
f5d91e9b28 Do not update passwords if nothing changed 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2022-08-09 18:54:21 +00:00
blizzz
d7c442deaa
Merge pull request #33443 from nextcloud/backport/33407/stable23 
[stable23] Handle one time and large passwords
 2022-08-04 11:16:46 +02:00