upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-05-19 08:25:56 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 14
75257 commits 951 branches 1208 tags 8.3 GiB
Commit graph

7088 commits

Author SHA1 Message Date
Louis
8b42f46c3d
Merge pull request #48998 from nextcloud/backport/47986/stable29 
[stable29] perf(ObjectStoreStorage): Improve (slow) move on same object bucket
 2024-10-31 15:55:32 +01:00
Côme Chilliet
74438f7f96
fix(tests): Fix most obvious errors in ObjectStore tests 
Some are still failing

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-31 14:40:37 +01:00
Benjamin Gaussorgues
31aa1fe4f5
Merge pull request #48488 from nextcloud/backport/48235/stable29 2024-10-30 09:59:56 +01:00
Christoph Fiehe
68b9972889 perf(ObjectStoreStorage): Improve (slow) move on same object bucket 
This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.

The behavior improves a lot with https://github.com/nextcloud/server/pull/46013. However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.

Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
 2024-10-30 08:28:52 +00:00
Robin Appelman
a61d2ab4c4 test: add test for nested jail cross-storage move 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-10-29 10:41:24 +00:00
yemkareems
de14601944
fix: crypto added manually as expected 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-28 18:47:05 +05:30
yemkareems
e4c22e02e0 fix: crypto type made not nullable and tests run using ICrypto 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-28 12:32:00 +00:00
yemkareems
7fa219e834 fix: encrypt and store password, decrypt and retrieve the same 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-28 12:32:00 +00:00
Joas Schilling
b2c8a10444
Merge pull request #48764 from nextcloud/backport/48539/stable29 
[stable29] fix(message): Fix logic of Mail test
 2024-10-17 21:15:20 +02:00
Ferdinand Thiessen
658aa1a2dd
Merge pull request #48588 from nextcloud/backport/47896/stable29 
[stable29] fix: Make user removal more resilient
 2024-10-17 18:21:57 +02:00
Joas Schilling
35933a62f7 fix(message): Fix logic of Mail test 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-17 12:45:06 +00:00
Ferdinand Thiessen
00d3e37e6d
fix(share): Return empty string if no label is set 
* Resolves: https://github.com/nextcloud/server/issues/48629

While the database supports NULL, the typing has always said it only returns *string*.
So to not break any apps that might trust the typings we should return `''` if the database is set to `NULL`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-15 16:56:59 +02:00
provokateurin
7dc1c7f762
fix(UserTrait): Fix backend initialization 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-15 16:50:28 +02:00
Ferdinand Thiessen
5d5c307a1a
fix: Make user removal more resilient 
Currently there is a problem if an exception is thrown in `User::delete`,
because at that point the user is already removed from the backend,
but not all data is deleted.

There is no way to recover from this state, as the user is gone no information is available anymore.
This means the data is still available on the server but can not removed by any API anymore.

The solution here is to first set a flag and backup the user home,
this can be used to recover failed user deletions in a way the delete can be re-tried.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-10-15 16:50:27 +02:00
Robin Appelman
90a6a75e11 test: re-add object store primary storage phpunit tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-10-09 14:50:02 +02:00
Richard Steinmetz
e2373b56fe
fix: gracefully parse non-standard trusted certificates 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
 2024-09-30 09:21:59 +02:00
Louis Chemineau
1e870c02f5
fix(users): Don't crash if disabled user is missing in the database 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-09-23 18:08:17 +02:00
Côme Chilliet
617c663c3b fix(tests): Fix Folder tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-19 17:51:51 +02:00
Robin Appelman
f38d70404d test: put parent items into cache in tests 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-19 17:45:28 +02:00
Robin Appelman
6c9bef6857 test: fix incorrect ltrim usage in test 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-09-19 17:44:49 +02:00
Robin Appelman
0a20c69c85
Merge pull request #48100 from nextcloud/backport/46140/stable29 
[stable29] fix(config): Add missing handling for `envCache` in `getKeys()`
 2024-09-16 18:54:23 +02:00
Josh Richards
80bbffa78a fix(config): add envCache tests for getKeys() 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2024-09-16 14:57:26 +00:00
provokateurin
bbb867f541 fix(Entity): Fix magic setter call for custom strong typed setters 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-16 13:52:18 +00:00
Joas Schilling
6e576e1fbd
Merge pull request #47941 from nextcloud/backport/47933/stable29 
[stable29] fix(config): Throw PreconditionException always when it didn't match
 2024-09-16 09:11:25 +02:00
Joas Schilling
bc750a1d09 fix(config): Throw PreconditionException always when it didn't match 
Previously even when the precondition did not match, the call "passed"
when the after value was the expected one. This however can lead to
race conditions, duplicate code excutions and other things.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-09-13 11:41:01 +00:00
Git'Fellow
01596b54c0 fix(files): Check if the target path is a descendant of the shared folder path 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: fix tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: add tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests
 2024-09-06 01:59:29 +00:00
provokateurin
77c38979c6 fix(files): Create non-existent parents of mountpoints 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-04 18:02:56 +00:00
Côme Chilliet
24e15badb7
fix(tests): Fix PHP 8.0 compatibility 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-08-13 15:17:57 +02:00
Côme Chilliet
92885c5d07
fix(tests): Adapt tests to change of DefaultShareProvider constructor 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-08-13 14:39:14 +02:00
Andy Scherzinger
598d50164a
Merge pull request #46889 from nextcloud/backport/46476/stable29 
[stable29] Migration Attributes
 2024-08-08 13:55:56 +02:00
Christoph Wurst
0a0c07cec1 fix(session): Log when session_* calls are slow 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-08-07 10:44:58 +00:00
Maxence Lange
e227d5afa1 feat(upgrade): migration attributes 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-08-06 22:41:35 -01:00
Ferdinand Thiessen
264074c161 fix: OCP\Files\Node\Folder::search was not setting the owner 
The owner was not set on the file info causing e.g. webdav searches to never return the known owner.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-30 11:06:30 +00:00
Julius Härtl
23ec547af0 fix: Ignore preview requests for invalid file ids 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-07-29 08:16:30 +02:00
Hoang Pham
e5532362da feat: support excalidraw file 
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
 2024-07-25 17:00:34 +07:00
Joas Schilling
ee6d74eb63 fix(mail): Fix big logos in mail templates for Outlook 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-07-19 08:11:54 +00:00
Benjamin Gaussorgues
3e2600bf86 feat: don't count failed CSRF as failed login attempt 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-07-11 14:15:20 +02:00
Daniel Kesselberg
a554ba5d68 test: run tests in child process 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-07-10 23:35:43 +02:00
Côme Chilliet
780bf606d2 fix(tests): Strong type property $router in RouterTest 
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
 2024-07-10 23:35:43 +02:00
Steve Mokris
182284ee98 fix(settings): define a 'heartbeat' route, so SecurityHeaders can handle redirected root 
Signed-off-by: Steve Mokris <steve@kosada.com>
 2024-07-10 23:35:43 +02:00
Robin Appelman
f3c3d890d6 test: update DummyJobList 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-10 20:29:36 +02:00
Joas Schilling
8c6101741c fix(tests): Remove output when running tests 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-07-03 16:03:44 +00:00
Joas Schilling
17434538d4 fix(federation): Fix missing protocol on CloudID remote 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-06-27 13:00:43 +00:00
Robin Appelman
d3d2488fbb feat: add setup check for needed mimetype migrations 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-06-19 11:22:49 +02:00
Arthur Schiwon
464cfce9b5
Merge pull request #44977 from nextcloud/backport/44745/stable29 
[stable29] fix(auth): Keep redirect URL during 2FA setup and challenge
 2024-06-12 19:37:41 +02:00
Daniel
a41941692d
Merge pull request #45821 from nextcloud/backport/45811/stable29 
[stable29] test: add tests for ProfilePageController
 2024-06-12 19:31:50 +02:00
Arthur Schiwon
3a17ec6db7
Merge pull request #45809 from nextcloud/fix/noid/fix-new-token-scope-name 
[stable29] fix(Token): make new scope future compatible
 2024-06-12 19:01:49 +02:00
Daniel Kesselberg
73703eb276 test: add tests for ProfilePageController 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-06-12 18:21:58 +02:00
skjnldsv
7327803816 fix(files_sharing): dark avatar support 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2024-06-12 11:06:10 +00:00
Arthur Schiwon
fc584b7874
fix(Token): make new scope future compatible 
- "password-unconfirmable" is the effective name for 30, but a draft
  name was backported.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2024-06-12 11:05:43 +02:00