Commit graph

720 commits

Author SHA1 Message Date
Ferdinand Thiessen
be82a4e502 fix(files_sharing): ensure share status action works also in grid view
Remove some hacks from files app about the *files_sharing* status
action, in general not sure why this hack was there instead of being in
the correct app - but it broke the grid view.

So now the sharing information is also available in grid view.

Moreover the icon is fixed in size to not overflow the actions menu.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-19 22:51:32 +01:00
Ferdinand Thiessen
985764152f
fix(files): also show file list headers on empty views
It is needed, e.g. for the note-to-recipient, that the headers
are also shown when there is no content (yet).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-17 19:41:41 +01:00
Joas Schilling
7abb5726ca
fix(l10n): Fix leading spaces and unicode single quotes
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-03-05 16:49:35 +01:00
Louis Chemineau
5e49e75a15 fix(test): Add missing data-cy attribute for file actions
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2025-03-05 12:12:51 +00:00
Ferdinand Thiessen
bd280f759b
fix(files_trashbin): disable bulk download for trashbin
The backend does not allow bulk download within the trashbin,
so we need to disable this also on the frontend.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-03 17:36:18 +01:00
Valdnet
32d6ba0129
fix(l10n): use do not instead of don't
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2025-03-02 12:47:10 +01:00
Joas Schilling
a5e6f46eb0
fix(l10n): Improve english source strings
- No leading/trailing whitespace
- Use asci single quote

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-26 15:06:47 +01:00
skjnldsv
e5c55bf562 fix(files): handle failed node properly
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-21 14:07:13 +01:00
skjnldsv
145d3fd1a7 fix(files): properly show file not found error
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

[skip ci]
2025-02-19 10:13:55 +01:00
skjnldsv
137ff37cf8 fix(files): properly forward open params from short urls
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-19 10:13:55 +01:00
Ferdinand Thiessen
d693dc9a00
fix(files): Properly reset all file list filters on view change
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-18 12:34:11 +01:00
Julien Veyssier
741c0f3cda
fix(transferownership): allow searching by email, display user.shareWithDisplayNameUnique in item subline, adjust style
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2025-02-17 12:51:22 +01:00
Ferdinand Thiessen
03e15b9297
fix(files): Do not download files with openfile query flag
Instead of downloading files, if there is no other default action,
we should just open the details tab.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-13 16:00:03 +01:00
Elizabeth Danzberger
181586123b
fix(template-filler): Hide template fields with unknown labels
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2025-02-13 10:32:21 +01:00
Ferdinand Thiessen
5251b25f4e
fix(files): Correctly scroll selected file into view
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 00:08:47 +01:00
Christopher Ng
2159fb04f4
feat(files): Display meaningful error message on move failure
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-02-05 09:09:03 +01:00
Ferdinand Thiessen
8d6139f17c
fix(files): Ensure favorites set in sidebar work
When marking a file as favorite from within the sidebar make sure it
really works, this fixes two issues:
1. The source needs to be the plain source not URL encoded, as otherwise
   the source of the node would be encoded twice (and show with encoding
   in the navigation)
2. The store should also listen for the update events as the sidebar has
   no access to the real node to update it, instead the store should -
   as long as we only have the legacy sidebar - update the node when
   added or removed as favorite.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-04 21:14:40 +01:00
skjnldsv
bdc4b770ae fix(files): ensure valid mtime and fallback to crtime if defined
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-04 13:46:36 +00:00
nfebe
3324b10307 fix: Use searchFrom property for client side plugins
The client-side plugin `in-folder` uses the `files` provider, this makes it

overlap with the main files provider itself.

This change follows eecda06f1a after it was discovered

that some apps/providers like `dav` use providers from another app like `contacts`

Signed-off-by: nfebe <fenn25.fn@gmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2025-01-31 12:01:28 +00:00
provokateurin
8a34e0552c
fix(files): Allow opening the same file repeatedly
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-31 08:10:39 +01:00
nfebe
a6a100ee64 fix(unified-search): Prevent multiple file picker triggers in in-folder search
Signed-off-by: nfebe <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2025-01-29 15:57:33 +00:00
nfebe
c680e74a82 fix(unified-search): Use appId for searching
Each provider may search from a particular app so we should use that for searching.

Before this commit, we used `provider.id` instead of `provider.appId` the problem with the previous
approach is that it forces the provider id to be a valid search provider (an app that supports search)
limiting the developers ability to use unique IDs to identify the different providers (especially plugin providers)
inside the places filter.

For example the Files search plugin "In folder" (search in folder plugin) was required to have id as `files` while the
files provider itself already has id as `files`.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-01-29 16:47:21 +01:00
Ferdinand Thiessen
910495de1f
fix(files): File type filter UI sync with filter state
When changing the folder the filter will be re-mounted by the file list,
so we need to pass the current state of the filter to the filter UI.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 20:25:55 +01:00
Richard Steinmetz
3efb46ca56
fix(files): sort not working after changing views
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-26 14:09:13 +01:00
skjnldsv
62809b5d7e fix(files): rename actions submenu back entry
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-22 08:23:33 +00:00
skjnldsv
71e6fbed6e fix(files): close submenu on main actions state change
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-22 08:23:33 +00:00
Maksim Sukharev
03200b9679 fix(files): hide move dialog action if destination has no CREATE permission
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2025-01-17 14:53:08 +01:00
Ferdinand Thiessen
be25f51f40
fix(files): Make injected actions reactive
Provided values are not reactive by default and by design,
we must need computed to make them reactive.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-13 11:06:55 +01:00
provokateurin
eea37f13d6 fix(files): Only register preview service worker once when the instance is hosted at the root path
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-12-18 16:28:01 +00:00
skjnldsv
9cd52975d2 fix(files): failsafe when executing actions methods
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-12 20:32:40 +01:00
skjnldsv
0d5cda8aa4 fix(files): cancel renaming on enter if no file name changes
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-12 18:25:03 +01:00
skjnldsv
3250aeb427 fix(files): virtual scroller item size computation
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-12 12:58:16 +00:00
skjnldsv
9205f373fc fix(files): throttle favorite with max 5 simultaneous requests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-12 12:35:41 +00:00
skjnldsv
f1fe382aca fix(files): dav Node type declaration
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-12 13:12:47 +01:00
skjnldsv
e09956787a fix(files): properly update paths and folder children on node move
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-12 13:10:03 +01:00
Kostiantyn Miakshyn
48f88e5942 fix: Fix ServiceWorker scope when Nextcloud installed in subfolder
Signed-off-by: Kostiantyn Miakshyn <molodchick@gmail.com>
2024-12-11 09:27:31 +00:00
Ferdinand Thiessen
2fed7bcf82 fix(files): Restore page title (folder - view - product)
* Folder: Current folder if not root
* View: Name of current view
* Product: Nextcloud

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-21 14:31:43 +00:00
nextcloud-command
3aab8bd8c4 chore(assets): Recompile assets + lint fix
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-11-20 09:08:34 +00:00
Ferdinand Thiessen
39e34fd9d9 fix(files): Allow downloading multiple nodes not from same base
When downloading files in e.g. the *favorites* or *recent* view,
then the nodes are not always share the same parent folder
and we can not use the current directory as it is probably just a
virtual one.

So we calculate the longest common base and use that as the directory
for the download endpoint.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-20 09:06:11 +00:00
Richard Steinmetz
b93bab42c5
fix(files): improve delete display name when trashbin is disabled
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-11-19 11:57:08 +01:00
skjnldsv
490716176e fix(files): check that node is in user root folder for view-in-folder action
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-12 22:39:38 +00:00
skjnldsv
606241cf76 fix(files): open sidebar on sharing tab by default for files
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-09 11:42:08 +01:00
skjnldsv
17bed7c3df fix(files): edit locally buttons
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-11-08 18:20:32 +01:00
skjnldsv
f5f59a8414 chore(files): add selection cypress tests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-07 23:13:57 +01:00
skjnldsv
d81e6ebdaf fix(files): multiselect and filters store declaration
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-07 19:13:46 +00:00
fenn-cs
2e31d35134 fix(Federation): Show some icon for federated users on shares
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-10-30 15:16:00 +01:00
Louis Chemineau
592cdd9603 fix(files): Do not jump to top when fileId is set to currentFolder
Fix https://github.com/nextcloud/server/issues/48545

Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-10-29 14:38:10 +00:00
Grigorii K. Shartsev
eba431074a fix(files): add title for files list table header button
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-10-25 20:52:12 +00:00
Grigorii K. Shartsev
73d0a04241 refactor(files): migrate to @nextcloud/sharing
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-10-25 15:12:39 +02:00
Grigorii K. Shartsev
9563f19651 fix(files): handle empty view with error
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-10-25 12:28:16 +00:00