Commit graph

46 commits

Author SHA1 Message Date
Daniel Calviño Sánchez
8a25e2dbcb Fix HTML entities not decoded in comment just added
The XML data received from the comments endpoint has an inconsistent
encoding; some entities are encoded once and others are encoded twice.
When the comment list is loaded the comments are fetched using
GetComments, which handles all that, and therefore shows the messages
and author names as expected.

However, when a new comment is posted the list is not got again; instead
the new comment is loaded from the comment data returned after posting
it. This is done in NewComment, which did not decode the messages nor
the author names, and therefore showed, for example, "&" instead of
"&".

To solve that now the same decoding logic used in GetComments is applied
too in NewComment.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-11-24 01:19:05 +00:00
Daniel Calviño Sánchez
4b6b40b5b1 Extract "decodeHtmlEntities" function to its own file
This will make possible to use it from files other than
"GetComments.js".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-11-24 01:19:05 +00:00
Louis Chemineau
19042c4d91 Fix mentions rendering in comment editor
NcRichContentEditable needs an index of users to properly display them. This commit adds a caching logic and provides it to NcRichContentEditable.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-11-23 13:47:24 +01:00
Richard Steinmetz
98977247da Fix empty content regressions in comments app
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-10-26 21:50:48 +00:00
luz paz
9d26671f05 Fix typos in apps/ subdirectory
Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`

Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-09-05 12:59:54 +00:00
Vincent Petry
d0473214cd
Add Nc prefix to Nc vue component names
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-25 08:38:00 +02:00
Vincent Petry
7080187958
Bump @nextcloud/vue to 6.0.0-beta.3 and related
Update @nextcloud/vue to 6.0.0-beta.3
Update vue and vue-template-compiler to 2.7.8
Update calendar-availability-vue to 0.5.0-beta.1 to fix conflicts.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-25 08:37:46 +02:00
Christopher Ng
2f6ab45302 Buttonify comment posting
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-07-19 18:04:00 +00:00
Louis Chemineau
e101882b92
Auto fix warnings
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-21 13:13:52 +01:00
Louis Chemineau
14e57bf70a Replace license information to SPDX expression
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:26:40 +01:00
Louis Chemineau
37e5050d69 Import type from packages
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:13:08 +01:00
Louis Chemineau
9fc6cc9634 Add generic type and description when its missing
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:13:04 +01:00
John Molakvoæ (skjnldsv)
74b9803108
Eslint fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2022-01-08 10:14:05 +01:00
Louis Chemineau
b312db382d
Use new div method in scss
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-08 10:11:58 +01:00
Christopher Ng
e5873a2f8d
Fix HTML entity rendering in file comments sidebar
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2021-11-08 22:21:13 +01:00
Julien Veyssier
5914c5e59c fix comments file action sidebar opening
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-27 08:50:04 +00:00
dependabot[bot]
6e5191b702 Bump @nextcloud/router from 1.2.0 to 2.0.0
Bumps [@nextcloud/router](https://github.com/nextcloud/nextcloud-router) from 1.2.0 to 2.0.0.
- [Release notes](https://github.com/nextcloud/nextcloud-router/releases)
- [Changelog](https://github.com/nextcloud/nextcloud-router/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/nextcloud-router/compare/v1.2.0...v2.0.0)

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-23 15:56:28 +02:00
dependabot[bot]
da0704d056
Bump webdav from 3.6.2 to 4.6.0
Bumps [webdav](https://github.com/perry-mitchell/webdav-client) from 3.6.2 to 4.6.0.
- [Release notes](https://github.com/perry-mitchell/webdav-client/releases)
- [Changelog](https://github.com/perry-mitchell/webdav-client/blob/master/CHANGELOG.md)
- [Commits](https://github.com/perry-mitchell/webdav-client/compare/v3.6.2...v4.6.0)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-29 08:58:26 +02:00
John Molakvoæ (skjnldsv)
cd3b3a6fdf
Fix comments maxAutoCompleteResults initial state
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-04-06 12:22:30 +02:00
John Molakvoæ (skjnldsv)
3e624dc399
Bump js licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-31 12:17:18 +02:00
Roeland Jago Douma
8988406789 Move comments to initial state
* Do not extend the jssettings
* Just use the proper intial state
* Use it in the js code as well

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-22 20:31:56 +00:00
John Molakvoæ (skjnldsv)
87d39375d8
Fix comments filesplugin
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-17 14:45:29 +01:00
John Molakvoæ (skjnldsv)
5d9bb5e247
Lint fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-17 13:03:38 +01:00
Vincent Petry
a60127acc8
Fix comments field value update
Fixes issue where the comment field value was not properly read out of
the rich content field.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-11 15:39:33 +01:00
Roeland Jago Douma
24d8473641 Only include moments once in comments
Shaves off a decent amount of the code size. Let alone the parsing.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-01-22 16:19:40 +01:00
John Molakvoæ (skjnldsv)
72aeb8ef05
Add mentions data
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-28 10:26:08 +01:00
John Molakvoæ (skjnldsv)
a57473f820
Hide long messages
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-28 10:26:08 +01:00
John Molakvoæ (skjnldsv)
cf43b70db6
Fix white-space display
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-28 10:26:08 +01:00
John Molakvoæ (skjnldsv)
a20f598049
Prevent submitting empty messages
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-28 10:26:08 +01:00
John Molakvoæ (skjnldsv)
6cd7549509
Bump @nextcloud/vue to 3.0.0
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-20 18:02:45 +02:00
John Molakvoæ (skjnldsv)
3e1916080a
Add ICommentsManager::load method
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-20 14:39:28 +02:00
John Molakvoæ (skjnldsv)
afa7376522
Cleanup old comments tab
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-20 13:58:07 +02:00
John Molakvoæ (skjnldsv)
e7f5516b4d
Init vue comments tab
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-20 13:58:06 +02:00
John Molakvoæ (skjnldsv)
6eced42b7a
Remove outdated legacy search scripts
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-04 20:56:22 +02:00
John Molakvoæ (skjnldsv)
a384b4a97a
Bump @nextcloud/eslint-config and peers
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-07-31 09:35:55 +02:00
John Molakvoæ (skjnldsv)
0f8aca9d87
Bump compiled files
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-07-31 09:26:43 +02:00
Roeland Jago Douma
b9e7fd2418 Remove the escape-html global
Already announced for 19 that it would go. So now it realy does go.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-05-29 08:34:10 +00:00
Roeland Jago Douma
b45dda4ac9
Fix some js linter warnings in comments
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-05-10 20:23:44 +02:00
John Molakvoæ (skjnldsv)
05821ab243 Clear comment on successful post
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-04-08 06:29:38 +00:00
dependabot-preview[bot]
ec01e0a790
Bump eslint-config-nextcloud from 0.0.6 to 0.1.0
Bumps [eslint-config-nextcloud](https://github.com/nextcloud/eslint-config-nextcloud) from 0.0.6 to 0.1.0.
- [Release notes](https://github.com/nextcloud/eslint-config-nextcloud/releases)
- [Commits](https://github.com/nextcloud/eslint-config-nextcloud/compare/v0.0.6...v0.1.0)

Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-19 11:55:33 +01:00
Joas Schilling
06f97c0fd0
Fix autocomplete suggestions with numeric user ids
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-11-26 09:19:49 +01:00
John Molakvoæ (skjnldsv)
fd90af50d9 Add OCA.Files.Sidebar
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-29 12:56:00 +01:00
John Molakvoæ (skjnldsv)
b9bc2417e7
Comply to eslint
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-01 17:16:09 +02:00
Christoph Wurst
278c281cc9
Deprecate oc_current_user, fix usage and move currentUser to the bundle
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-05-08 09:44:51 +02:00
John Molakvoæ (skjnldsv)
b38445b17a
Show comments and restore in popover menu
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-04-02 12:24:48 +02:00
Roeland Jago Douma
41ef3d860c
Move comments to webpack
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-02-26 09:10:23 +01:00