Côme Chilliet
a32875d402
fix(files_sharing): Use session id as part of cache key to avoid concurrency issues
...
If several people are watching and seeking the same video file we do not
want the cache key to be the same or it would flood activity again.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 15:43:09 +01:00
Côme Chilliet
ec5ac0957a
fix(files_sharing): Set higher priority for listeners that may abort the request
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 15:43:09 +01:00
Côme Chilliet
a3c531c31e
fix: Avoid triggering several activities for Range request on the same file
...
Avoids flooding activities when someone browse a video in the web player.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 15:43:09 +01:00
Côme Chilliet
a39bee57d9
fix: Fix download activity for folders
...
Remove duplicate activity publishing from share controller download,
listen to BeforeZipCreatedEvent to publish activity for folders, and
cache folders activity to avoid sending activity for each file in the
folder.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 15:43:09 +01:00
Côme Chilliet
12ce8c0ef0
fix(sharing): Publish activity for download by public link
...
Even if dav endpoint is now used.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-25 15:43:09 +01:00
Marcel Klehr
b464469bc1
perf(sharing): Use oc_share.{item_type, share_type} IN instead of OR equals
...
to improve performance by using the db index
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-03-25 09:42:06 +01:00
Luka Trovic
d7f885b1cb
fix(files_sharing): skip expiration notify for invalid share record
...
Signed-off-by: Luka Trovic <luka@nextcloud.com>
2025-03-17 12:59:06 +01:00
Ferdinand Thiessen
00d08a4f69
fix(lookup-server): disable lookup server for non-global scale setups
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 14:26:47 +01:00
Ferdinand Thiessen
34251c4375
fix(lookup-server): do not query data by default
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 14:26:47 +01:00
Ferdinand Thiessen
7e6608d119
fix(files_sharing): Also list deleted team shares
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-20 14:32:22 +01:00
Ferdinand Thiessen
c19ce403f3
fix(files_sharing): block downloading if needed
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-18 11:58:12 +01:00
solonovamax
9b9ea77035
feat(files_sharing): Add opengraph meta tags for multimedia, change opengraph type to website
...
- Adds the following opengraph tags
- images:
- `og:image:type`: the mimetype of the image file
- audio:
- `og:audio`: a direct link to the audio file
- `og:audio:type`: the mimetype of the audio file
- video:
- `og:video`: a direct link to the video file
- `og:video:type`: the mimetype of the video file
- Changes th `og:type` meta tag from `object` (which is not valid) to `website`
Signed-off-by: solonovamax <solonovamax@12oclockpoint.com>
2025-02-17 12:52:08 +01:00
solonovamax
6bcacff339
feat(files_sharing): Add twitter meta tags
...
Adds the following twitter meta tags
- `twitter:card`: `summary_large_image` if the shared file is an image & it has a preview, otherwise `summary`
- `twitter:title`: same as `og:title`
- `twitter:description`: same as `og:description`
- `twitter:image`: same as `og:image`
Fixes nextcloud/server#49871
Signed-off-by: solonovamax <solonovamax@12oclockpoint.com>
2025-02-17 12:52:08 +01:00
Christoph Wurst
228ac86fa2
Merge pull request #50769 from nextcloud/checkStorageIdSetCache
...
fix(SharedStorage): Check if storage ID is set on cache
2025-02-14 14:17:00 +01:00
Côme Chilliet
64863c9d46
chore: Apply new rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 11:46:42 +01:00
Côme Chilliet
ed5b7ae161
chore: re-apply current rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 11:45:33 +01:00
Côme Chilliet
a3685551f7
fix: Replace isInstalled calls with isEnabledForAnyone or isEnabledForUser
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:19 +01:00
Git'Fellow
bc3be77a69
fix(SharedStorage): Check if storage ID is set on cache
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-02-13 08:29:20 +01:00
Robin Appelman
2786ca579a
fix: don't use cached root info from shared cache if the watcher has detected an update
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-06 19:41:43 +01:00
nfebe
8178797eb5
refactor: Remove some deprecated containers and exceptions
...
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-02-06 12:15:31 +01:00
Ferdinand Thiessen
73dc0f0f19
fix(sharing): Ensure download restrictions are not dropped
...
When a user receives a share with share-permissions but also with
download restrictions (hide download or the modern download permission attribute),
then re-shares of that share must always also include those restrictions.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-04 15:39:14 +01:00
Ferdinand Thiessen
b48ee2e924
fix: Harden files scanner for invalid null access
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 20:08:46 +01:00
Ferdinand Thiessen
253f4345f1
fix(files_sharing): Respect permissions passed when creating link shares
...
Given:
User creates a link or email share with permissions=4 (create only = file drop).
Problem:
Currently the permissions are automatically extended to permissions = 5
(READ + CREATE). Work around was to create the share and directly update
it.
Solution:
Respect what the user is requesting, create a file drop share.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 16:40:50 +01:00
Ferdinand Thiessen
305e1bb260
fix: Ensure label is always a string
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-26 20:41:31 +01:00
Anna
d9a7124592
Merge pull request #49898 from nextcloud/fix/noid/no-emails-for-user-shares
...
fix(sharing): send share emails for internal users too
2025-01-16 18:50:30 +01:00
Christopher Ng
0eb39d7b9c
feat(sharing): Respect admin custom tokens setting
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:50:43 -08:00
Christopher Ng
4d78de497f
feat(sharing): Add custom_tokens capability
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:50:43 -08:00
Christopher Ng
beffb26266
feat(sharing): Fetch a unique generated token
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:49:19 -08:00
Christopher Ng
f92875cf6a
feat(sharing): Allow updating share token
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:49:19 -08:00
provokateurin
90c608bdc7
fix(files_sharing): Fix sharee search result types
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-13 15:21:21 +01:00
provokateurin
9f59204148
fix(files_sharing): Gracefully handle fetching non-existent share
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-13 15:21:20 +01:00
provokateurin
4dfa02c29d
fix(files_sharing): Handle null userId
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-13 15:19:54 +01:00
Anna Larch
236e084fbb
fix(sharing): send share emails for internal users too
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2025-01-13 14:13:02 +01:00
skjnldsv
5c359e424f
feat(federatedfilesharing): auto-accept shares from trusted servers
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-01-09 12:54:51 +01:00
provokateurin
085d4c9364
refactor(OpenAPI): Adjust scopes to match previous behavior
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-06 14:30:40 +01:00
skjnldsv
bc0ad5efbf
fix(federatedfilesharing): get share by token fallback
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-28 09:27:30 +01:00
skjnldsv
8089de5fcf
fix(activity): make emails for link share uploads true by default
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-06 12:34:52 +01:00
Maxence Lange
4591430c9c
feat(ocm): signing ocm requests
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-12-04 09:30:55 -01:00
Stephan Orbaugh
e87ed9b5fb
Merge pull request #49569 from nextcloud/shared-watcher-perf
...
perf: improve performance of SharedStorage::getWatcher
2024-12-03 09:57:56 +01:00
Robin Appelman
bc53a8ab87
perf: improve performance of SharedStorage::getWatcher
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-11-29 18:10:30 +01:00
Benjamin Gaussorgues
5581f0c7bf
chore: remove legacy action to test remote endpoint
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-11-29 11:14:37 +01:00
Benjamin Gaussorgues
ae1c3b372e
chore: stricter access to testremote endpoint
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-11-28 11:22:15 +01:00
Côme Chilliet
ae7f9cb3c1
Merge pull request #43025 from nextcloud/bugfix/error-on-reshare-after-transfer-ownership
...
fix: update re-share if shared-by user has been revoked
2024-11-25 18:20:29 +01:00
provokateurin
715e7143f0
fix(files_sharing,files): Do not validate shares before adjusting the owner
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +01:00
provokateurin
beea8854ca
feat(files_sharing): Allow users with share permission to manage shares on IShareOwnerlessMount
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +01:00
provokateurin
b658ab7a86
fix(files_sharing): Remove duplicate link/email edit share logic
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +01:00
Côme Chilliet
f44a192613
fix(files_sharing): Fix error messages from password policy
...
Exceptions thrown from password_policy may bubble up in share creation
or update when a password is used. Their message is meant to be shown
to the user. This always the case for HintException so we catch that
instead of the subclass GenericShareException.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-11-19 09:40:26 +01:00
Luka Trovic
2ca51919db
fix(sharing): add command to fix broken shares after ownership transferring
...
Signed-off-by: Luka Trovic <luka@nextcloud.com>
2024-11-18 21:24:23 +01:00
skjnldsv
4d9d617c84
feat(files_sharing): use share node or label as page title
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-08 14:20:58 +01:00
provokateurin
77114fb327
fix(OpenAPI): Adjust array syntax to avoid ambiguities
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-05 09:58:11 +01:00