Commit graph

689 commits

Author SHA1 Message Date
Christopher Ng
ff76f4ad59 perf(settings): Remove computation of all groups
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-04-01 10:17:32 +00:00
Côme Chilliet
3d33ac2d34
chore: Move magic number into a documented const
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-31 15:39:40 +02:00
Côme Chilliet
d3bc8b771c
fix: Correctly count disabled users for SAML groups subadmins
If too many users return -1 as for LDAP so that link is shown

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-03-31 15:39:05 +02:00
Andy Scherzinger
6596946df9
Merge pull request #51401 from nextcloud/backport/51379/stable30
[stable30] fix(AppDiscover): Strip double-quotes from folder name
2025-03-12 08:58:05 +01:00
Ferdinand Thiessen
c0003fbd9c
fix(lookup-server): disable lookup server for non-global scale setups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 21:52:07 +01:00
Ferdinand Thiessen
045f1d210a
fix(lookup-server): do not upload data by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 21:46:20 +01:00
Git'Fellow
659cdda841 fix(AppDiscover): Ensure created cache folder is safe-chars only
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-03-11 17:30:16 +00:00
Joas Schilling
a5e6f46eb0
fix(l10n): Improve english source strings
- No leading/trailing whitespace
- Use asci single quote

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-26 15:06:47 +01:00
Josh
431c6d0609
fix(Mailer): Fix sendmail binary fallback
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-02-12 13:23:11 +01:00
Joas Schilling
37948c5127 fix(setupcheck): Update setup check for PHP version to be more accurate
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-10 18:46:56 +00:00
Ferdinand Thiessen
422655bf1e
fix(provisioning_api): Correct limit for editUser
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-07 12:42:23 +01:00
Andy Scherzinger
ebcdf9f5aa
Merge pull request #50440 from nextcloud/backport/49440/stable30
[stable30] fix(SetupChecks): Pass webfinger if the handler returns 400 too
2025-01-26 17:58:32 +01:00
Josh
0ea6c5bb9d fix(SetupChecks): Pass webfinger if a handler is there
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-01-26 14:40:35 +00:00
Josh
acb7ac5c37 fix(settings): show the correct initial locale in Personal info
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-01-26 12:32:15 +01:00
Joas Schilling
22a8bf12da
fix(security): Update .well-known/security.txt expiration date
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-01-23 09:46:23 +01:00
Git'Fellow
c38d308aa2 fix(setupchecks): Binary data can have problems with serialize
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-01-10 08:02:37 +00:00
provokateurin
6eb843cc57 fix(settings): Fix log file download return type
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-08 10:14:11 +00:00
rakekniven
5423c3f01d chore(i18n): Fixed grammar
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-12-30 12:40:44 +01:00
Joas Schilling
3228a5cdb3
Merge pull request #49594 from nextcloud/backport/49588/stable30
[stable30] fix(setupcheck): Make the Memcache setupcheck use the cache
2024-12-20 11:15:49 +01:00
Joas Schilling
f12b81534a
fix(setupcheck): Make the Memcache setupcheck use the cache
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-12-19 15:35:04 +01:00
Joas Schilling
4ee7105f1c fix(setupcheck): Disable PhpMaxFileSize setupcheck for now
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-12-04 08:06:10 +00:00
Joas Schilling
916e050bb5 fix(activity): Fix activity object type warnings
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-11-27 12:17:49 +00:00
Git'Fellow
09ad3951e3
Merge pull request #49373 from nextcloud/backportArrayKeySetupCheks
fix(SetupChecks): Make sure array key is set
2024-11-21 13:08:14 +01:00
skjnldsv
79bf1abb98 fix(settings): psalm PhpMaxFileSize setup check warning
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-19 19:05:35 +01:00
skjnldsv
e22f8a8fa2 feat(settings): add big file upload setup checks
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-19 16:24:57 +00:00
Git'Fellow
50d071e7d2 fix(SetupChecks): Make sure array key is set
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-11-19 14:11:20 +01:00
SebastianKrupinski
1260ec5f21 feat: mail provider settings
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-11-14 20:26:22 -05:00
Claudio Cambra
a4e2a7bb7b fix(appsmanagement): Fix exception on generating preview url for screenshots
Some installed apps meant for older server versions might unexpectedly
offer up screenshot values in a non-string format (e.g. health). Avoid
an exception by checking first if the first app screenshot is indeed a
string and otherwise we take the value of the parameter

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-01 14:48:33 +00:00
Andrey Borysenko
824aa30057
fix: add missing import after backport
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-10-30 20:36:59 +02:00
Andrey Borysenko
cac5be5341
fix(ci): psalm, suppress undefined for viewApps
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-10-30 20:36:57 +02:00
Andrey Borysenko
c53f5c43b4
WIP: address review comments, small fixes
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-10-30 20:36:56 +02:00
Andrey Borysenko
fb4150ec86
fix(ci): suppress UndefinedClass for AppAPI related classes since it's bundled
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-10-30 20:36:56 +02:00
Andrey Borysenko
3a51374ff3
feat(app_api): add initial state data for AppAPI UI part
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>

# Conflicts:
#	apps/settings/lib/Controller/AppSettingsController.php

# Conflicts:
#	apps/settings/lib/Controller/AppSettingsController.php
2024-10-30 20:36:50 +02:00
Benjamin Gaussorgues
51d8dc76c5 fix(users): use correct active user count
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-30 09:09:44 +00:00
Benjamin Gaussorgues
1c474fc30e
Merge pull request #48624 from nextcloud/backport/48619/stable30 2024-10-30 09:45:20 +01:00
Kate
7bd791f327
Merge pull request #48571 from nextcloud/backport/48532/stable30 2024-10-29 10:26:18 +01:00
Ferdinand Thiessen
7b2a614ca5
Merge pull request #48866 from nextcloud/backport/48853/stable30
[stable30] fix(app-store): Ensure the `groups` property is always an array
2024-10-23 19:08:38 +02:00
Ferdinand Thiessen
2198fe16c9 fix(app-store): Also proxy images of locally installed apps
Before this only app store apps got their screenshots proxied,
but this will cause locally installed apps to not be correctly shown on the app-store.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-23 15:19:24 +00:00
Ferdinand Thiessen
35a1d4b224 fix(app-store): Ensure the groups property is always an array
If the value was a string, like a single group, then `json_decode` will also yield only a string.
So in this case we ensure the property is always an array with that value.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-23 15:05:23 +00:00
Marcel Müller
2023f3cce3 fix(appstore): Hide last modified information for shipped apps
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2024-10-18 12:02:07 +02:00
Christopher Ng
f582aba86e fix: Fix empty sections appearing in search results
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-10-09 08:59:46 +00:00
Maksim Sukharev
6c73ba339a fix: do not reduce count for subadmins if they are members of group
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2024-10-04 18:22:16 +00:00
Maksim Sukharev
962a971643 fix: correctly count disabled users for subadmins
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2024-09-30 10:10:22 +00:00
Ferdinand Thiessen
dbe88caec5 fix: Ensure app discover section is returned as list
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-24 11:37:41 +00:00
Ferdinand Thiessen
77321bc6cf
Merge pull request #47944 from nextcloud/backport/47883/stable30
[stable30] fix(setup-checks): Ensure URL with webroot works
2024-09-19 00:19:19 +02:00
Joas Schilling
9371d93249 fix(a11y): Add OTF font loading check
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-16 09:26:59 +00:00
Ferdinand Thiessen
71d870d1bd
refactor(settings): CheckServerResponseTrait always expect absolute path
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-15 21:40:27 +02:00
Ferdinand Thiessen
27300ac6ce
fix(setup-checks): Ensure URL with webroot works
We basically mock the way `URLGenerator::getAbsoluteURL` works,
so we must make sure that the URL might already contain the webroot.
Because `baseURL` and `cliURL` also contain the webroot we need to remove
the webroot from the URL first.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-15 21:40:27 +02:00
Côme Chilliet
6830b250b4 fix(setupchecks): Test overwrite.cli url first, then generated one, and
trusted domains as last fallback.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 15:54:56 +00:00
Daniel Kesselberg
ed8759eab8 fix: add option to remove the webroot for setup checks and don't check trusted_domains.
1) The checks for well-known urls should always run against the root domain and therefore the option to remove the webroot.

2) For trusted domains, the available protocol is unknown, and thus some guesswork would be needed to make that work. I've decided for now to not consider them anymore to reduce false-positives.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-05 15:54:56 +00:00