Commit graph

219 commits

Author SHA1 Message Date
Joas Schilling
3879c2eb1e Limit more contact searches
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-13 14:23:04 +00:00
Vincent Petry
33b01187cd
Replace ILogger with LoggerInterface in remote share manager
Signed-off-by: Vincent Petry <vincent@nextcloud.com>

Co-authored-by: Carl Schwan <carl@carlschwan.eu>
2021-08-10 13:27:59 +02:00
Vincent Petry
4d0f0095ea
Add logging to external shares manager
Instead of just returning false, also log the exception to make
debugging database issues easier.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-08-10 13:27:58 +02:00
Louis Chemineau
ebf35fb38a Correctly check the reception of a remote feedback
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-06-09 15:37:18 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +02:00
Roeland Jago Douma
3854e7f8f0 Respect default share permissions for federated reshares
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-05-17 09:48:31 +02:00
Roeland Jago Douma
50517a2622 Throttle MountPublicLinkController when share is not found
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-05-12 16:26:31 +02:00
Christoph Wurst
99f2fa73d1
Fix usage of rename executeUpdate
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-05-05 10:35:25 +02:00
Roeland Jago Douma
70f12e7332 Improve federated permission handling
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-26 16:10:44 +02:00
Morris Jobke
a67f0b0c47
Merge pull request #26615 from nextcloud/enh/ffs/require_read
Require read permissions for federated shares
2021-04-19 21:50:48 +02:00
Roeland Jago Douma
5c42c303e4 Require read permissions for federated shares
Else they end up as weird shares that can't be properly utilized by
other parties anyway.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 12:53:49 +02:00
Roeland Jago Douma
241dfab33f Do not allow adding file drop shares to your own cloud
There is no reason for this and you can't create such shares normally
anyway.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 12:17:58 +02:00
Roeland Jago Douma
0593b039fc Move over notification to new registration
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-16 13:56:28 +02:00
Vincent Petry
8680bafc5c
Implement expiration date for federated shares
Add expiration date field in UI.
Save expiration date when creating or updating federated share.
Read expiration date from DB in federated share provider.
Applies to both federated user and group shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:00 +02:00
Valdnet
6da17a6fab l10n: Add word user in FederatedShareProvider.php
Standardizing text strings with other Nextcloud applications.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-11 13:52:54 +02:00
Morris Jobke
1eb084cfd3
Merge pull request #25498 from Worteks/feat-federatedfilesharing-logging
feat(federatedfilesharing): log errors, as suggested by @maxbes
2021-03-22 21:21:53 +01:00
Roeland Jago Douma
f421fd25ba Move requesthandler controller to LoggerInterface
* LoggerInterface
* executeUpdate
* log exception when there is one (just so we ahve the trace)

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-10 08:50:38 +01:00
Roeland Jago Douma
69b26c73f3 Fix some redundant casts
Happier psalm

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 08:51:08 +01:00
Roeland Jago Douma
4f37e0ce55 Remove redundant casts
For #25839

In short with the connection adapter we now have the function is typed
to int (and casts itself). So it is not needed anymore.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 16:32:13 +01:00
dependabot-preview[bot]
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +01:00
Samuel
dca4e4d528 fix(no_unused_imports)
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-09 09:46:52 +01:00
Samuel
d441da2a80 fix(php-cs)
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-09 09:41:07 +01:00
Samuel
9b600a5365 fix(misc)
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-09 08:35:16 +01:00
Samuel
6e4cd33d12 fix(php-cs)
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-09 08:18:16 +01:00
Samuel
e7ea31dcaa fix(logger): use logger from constructor arguments
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-09 07:49:01 +01:00
Samuel
28214f73f3 fix(pebkac): missing use OC
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-08 10:18:02 +01:00
Samuel
77825e6961 fix(logger): set logger in constructor
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-08 10:11:00 +01:00
Samuel
2c59e59023 fix(php-cs): indentation / elseif, maybe braces?
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 12:16:01 +01:00
Samuel
e41afea739 feat(federatedfilesharing): log errors, as suggested by @maxbes
Signed-off-by: Samuel <faust64@gmail.com>
2021-02-05 11:55:56 +01:00
Christoph Wurst
c1d4f8161b
Migrate internal classes to the OCP db col types
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-12 14:09:13 +01:00
Morris Jobke
24d436cb60
Remove unneeded casts that were found by Psalm
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521)

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-11 13:14:41 +01:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +01:00
Joas Schilling
11c1ce6974
Fix PHP CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-15 11:31:28 +01:00
Joas Schilling
96253c7c1b
Add missing parent::__construct() calls to Jobs
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-14 16:35:12 +01:00
Julius Härtl
aefe826202
Adjust default
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-08 16:06:10 +01:00
Julius Härtl
8f6c2ec357
Move columns to bigint
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-08 16:05:53 +01:00
Julius Härtl
bb21e87d23
Migrate files_sharing to migrations and move remote_id to a string in share_external
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-08 16:05:52 +01:00
Julius Härtl
f68f67f354
Move remoteId of remote reshares to string
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-08 16:03:24 +01:00
Roeland Jago Douma
6166e1a157
Use proper OCP\BackgroundJobs\Job
And typehunt the IJobList

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-25 15:03:06 +01:00
Joas Schilling
d5df033ede
Create primary keys on all tables and add a command to create the afterwards
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:36:27 +01:00
Joas Schilling
8027dcbc6f
Don't leave cursors open when tests fail
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-09 12:28:17 +01:00
Christoph Wurst
d9015a8c94
Format code to a single space around binary operators
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +02:00
Christoph Wurst
2a054e6c04
Update the license headers for Nextcloud 20
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +02:00
Joas Schilling
79027c8eff
Fix missing placeholders in translations
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-03 11:23:53 +02:00
Arthur Schiwon
ac3d8d1e43
effectively revert 17fae47bdb fixing i10n
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-08-03 11:05:45 +02:00
Arthur Schiwon
04521c6afc
coding style fixes
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-07-30 21:18:20 +02:00
Arthur Schiwon
b79e34c57b
fix check for Cloud ID, missing return statements, wrong param use
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-07-30 21:10:54 +02:00
Morris Jobke
0763a17332
Move federated_share_added into a typed event
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-23 08:33:17 +02:00
Morris Jobke
7870ca0663
Use the proper IAppContainer and IServerContainer type hints to know which code runs with which container
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-21 20:44:05 +02:00
Christoph Wurst
91e7f12088
Adjust apps' code to use the ContainerInterface
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-21 20:43:18 +02:00