Commit graph

514 commits

Author SHA1 Message Date
Julius Härtl
6ec9f85ed9 fix: Always create user directory when transfering files to new users
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-11 06:17:25 +00:00
Michiel de Jong
57611db80a Add SHARE_TYPE_SCIENCEMESH
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
2023-03-22 15:25:42 +01:00
EWouters
66ccaa4771 [Fix]: scan-app-data conversion
Adapted from sugestions by @Hiyoal in #34283 and @st3iny in #35935.

See https://github.com/nextcloud/server/issues/34283#issuecomment-1288075064
and https://github.com/nextcloud/server/pull/35935#discussion_r1059905594.

Closes #34283.

Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: EWouters <6179932+EWouters@users.noreply.github.com>
2023-01-23 16:53:13 +00:00
Markus Zeller
cffa3673f1 Cast to int #32837
Signed-off-by: Markus Zeller <git@markuszeller.com>
2022-11-08 10:08:23 +00:00
Carl Schwan
7b001abd08 Allow scanning for metadata with occ scan:file --generate-metadata
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-10-20 11:56:02 +00:00
Joas Schilling
be005877ff Also throttle on expiration
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-12 17:52:13 +00:00
Joas Schilling
c48b15fb70 Fix psalm error on migration
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-12 17:52:13 +00:00
Joas Schilling
ec230f9290 Add a background job to delete expired tokens
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-12 17:52:13 +00:00
Joas Schilling
1db6d96e94 Also remove token when we successfully validated
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-12 17:52:13 +00:00
Joas Schilling
1d02efdd8b Require a token for "Edit locally"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-10-12 17:52:13 +00:00
Anna Larch
a2d8bd4c11 Url encode the web dav url for copying
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-10-02 12:32:25 +00:00
luz paz
9d26671f05 Fix typos in apps/ subdirectory
Found via `codespell -q 3 -S l10n,./apps/files_external/3rdparty -L adn,ba,boxs,keypair,jus,optionel,ressource,tabel ./apps/`

Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-09-05 12:59:54 +00:00
Carl Schwan
b888c61463
Merge pull request #33047 from nextcloud/fix/ijob-logger-deprecated
Deprecated ILogger from IJob
2022-08-23 16:55:42 +02:00
Joas Schilling
7e11778190
Use user name cache in activity providers
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-19 10:48:32 +02:00
Vincent Petry
fbc48db507
Remove redundant events
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-08-15 19:20:42 +02:00
Daniel Calviño Sánchez
4c837dadf2 Show usage percenteage in the tooltip
The tooltip of the initial quota display showed the usage percenteage
and the total available space. However, the total available space was
redundant, as it was shown just below. The tooltip of the updated quota
display showed the usage percenteage, but based on the quota rather than
the total available space, so there was a mismatch between the tooltip
and the bar below. Now the tooltip of the initial and the updated quota
display both show just the usage percenteage based on the total
available space.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-08-10 11:23:27 +02:00
Daniel Calviño Sánchez
f6bdaac88e Use total available space rather than quota when updating the display
The initial quota display uses the total available space rather than the
quota. Moreover, the relative usage is based on the total space rather
than the quota. Due to this now the total available space is also used
when updating the quota display.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2022-08-10 11:22:50 +02:00
Carl Schwan
48d9c4d2b0
Port existing server code to new interface
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-08 17:03:19 +02:00
Simon L
de82d4f67c
Merge pull request #32874 from bill-mcgonigle/patch-1
Mention missing files subdir
2022-06-17 12:12:25 +02:00
Côme Chilliet
c54fb5f9e6
Use {$var} instead of ${var} for PHP 8.2 compatibility
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-14 15:12:28 +02:00
Bill McGonigle
ad60b3b479
Mention missing files subdir
Many users are getting confused by the inaccurate error message "Home storage for user $user not writable" because the storage *is* writable.  The actual issue is a missing files/ subdirectory.  cf. https://help.nextcloud.com/t/home-storage-for-user-not-writable/10831/7
By mentioning the possible cause in the error message, users are going to be able to rapidly solve their problem rather than bang their heads against the screen, Google, and eventually forums to find out that the error message is wrong in their case.
Yes, it would be better to detect and precisely describe the fault, or fix the problem automatically, but until then, be kind to the users for the next however many years.
2022-06-14 07:10:29 -04:00
Vincent Petry
e6e1862000
Merge pull request #32059 from cld4h/patch-1
Fix issue #31692 of occ files:scan
2022-06-10 16:20:00 +02:00
Julius Härtl
61056587c9
Only load direct editing capabilities when required
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-06-03 07:15:17 +02:00
John Molakvoæ
18f2340a40
Merge pull request #32149 from nextcloud/fix-transferring-groupfolders 2022-05-11 08:40:28 +02:00
Carl Schwan
f945c0cbc6 Add a public replacement for OC::$server->get
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-10 18:51:12 +02:00
Vanessa Pertsch
c714c3380a fix for transferring ownership of groupfolders
Signed-off-by: Vanessa Pertsch <vanessa.pertsch@nextcloud.com>
2022-05-10 16:54:22 +02:00
cld4h
553239c083 Fix issue #31692 of occ files:scan
occ files:scan reports error "Implicit conversion from float XXX to int loses precision"

Signed-off-by: cld4h <20869428+cld4h@users.noreply.github.com>
2022-04-26 14:22:41 +08:00
Robin Appelman
7eca0a2553
don't force a full setup for getting storage stats
the auto-setup is good enough

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-06 13:13:37 +02:00
Côme Chilliet
ea23523c70
Adapt more code to migration to LoggerInterface
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-24 16:21:25 +01:00
Carl Schwan
028ca0935c Don't redirect when loading files index page
Currently we are redirecting from ?dir=/&fileid=2 to ?dir=/. This is an
issue because we then need to load two pages with full file system setup
and authentification instead of one and the assets won't start loading
until the second page is delivered to the user.

Additionally when loading ?dir=/, we then change the url back to
?dir=/&fileid=2 (without reload) so that the next time we load the page
again we do the same thing again.

Depending on the speed of the server and internet connection we can save
100ms to 400ms, improving the user experience.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-02-17 17:06:33 +01:00
Vincent Petry
62d47100ec
Merge pull request #30953 from nextcloud/feat/init-storage-when-transferring-ownership
Init user's file system if not existing on ownership transfer
2022-02-10 18:13:43 +01:00
Vincent Petry
1a9e6f1571
Merge pull request #31097 from nextcloud/bugfix/31096/fix-shares-transfer-guest-to-nonguest
Fix path handling when transferring incoming shares
2022-02-10 17:47:41 +01:00
Vincent Petry
7858fee5b5
Fix path handling when transferring incoming shares
When transferring incoming shares from a guest user without specifying a
path, the $path is empty.
The fix properly handles that situation to avoid looking for shares in a
path with doubled slashes which failed to find shares to transfer.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-02-10 09:50:21 +01:00
Joas Schilling
5f5142ff58
Don't provide favorite activity settings
Since mails and notifications are only available for actions of other users
it does not make sense to allow changing this.
It also prevents the common misunderstanding with
"file was changed inside a favorited folder"

Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-09 10:49:32 +01:00
Carl Schwan
02da4ce1b0 Init user's file system if not existing on ownership transfer
This makes it a bit easier to transfer ownership when the new user
hasn't already logged in. This still doesn't support encrypted
storages because the keys are not generated yet.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-02-01 13:26:41 +01:00
Julien Veyssier
b67b4b160b
[files] new internal link GET param to avoid setting 'openfile' on redirect
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-01-14 10:50:13 +01:00
John Molakvoæ
2c1eac665a
Merge pull request #30530 from nextcloud/fix/search-url 2022-01-14 09:18:44 +01:00
John Molakvoæ
8d3a4856cb
Fix wrong unified search link to folder
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-01-13 18:26:07 +01:00
John Molakvoæ (skjnldsv)
87d0904b6f
Split common vendor chunk
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2022-01-08 10:14:50 +01:00
John Molakvoæ (skjnldsv)
b664aad7ab
Move bundles to /dist
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2022-01-08 10:11:58 +01:00
Joas Schilling
d49ad7ea47
Limit more contact searches
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-08 18:58:54 +01:00
Robin Appelman
e95745c074
fix tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-12-02 17:43:16 +01:00
Robin Appelman
89bc9f1b77
stop background scan early if a users still has unscanned files after background scan
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-12-02 17:35:07 +01:00
Robin Appelman
38921ab498
find users for background scan one by one
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-12-02 17:35:02 +01:00
John Molakvoæ (skjnldsv)
a325141545
Remove isIE and associated legacy scripts
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-11-30 13:03:08 +01:00
Vincent Petry
67ebe75d0e
Move storage encoding compatibility warning logic
The encoding check for file names is now happening the Scanner, and an
event will be emitted only if the storage doesn't contain the encoding
compatibility wrapper.

The event is listened to by the occ scan command to be able to display a
warning in case of file name mismatches when they have NFD encoding.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-11-17 09:24:13 +01:00
Julius Härtl
9c937a63bf
Move to combined files entrypoint
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-10-25 16:51:37 +02:00
Vincent Petry
fa23a9f720
Do not transfer shares for deleted users
Whenever a user was deleted but is still recipient of share entries,
delete these entries upon transfer.

Usually such entries would disappear after running cleanup background
jobs.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-10-04 11:04:04 +02:00
Vincent Petry
ab09f1e00e
Merge pull request #28853 from nextcloud/bugfix/27547/dont-allow-changing-settings-that-dont-work
Don't allow to change activity settings that don't work
2021-09-27 08:16:33 +02:00
Joas Schilling
ad9cad1ae5
Don't allow to change activity settings that don't work
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-09-15 17:27:01 +02:00