upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-03-16 23:53:28 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions 33
66022 commits 769 branches 1186 tags 6.7 GiB
Commit graph

12775 commits

Author SHA1 Message Date
Joas Schilling
bf623072d1 fix(comments): Use provided offset in best effort when loading comments 
When we didn't find the "$lastKnownComment" the whole condition was ignored.
Now we still use the ID as an offset.
This is required as a fall-back for expired messages in Talk
and deleted comments in other apps.

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-09-19 14:25:54 +00:00
Julius Härtl
8ddcebe3bd
fix: Only read unencrypted_size when file is actually encrypted 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-09-12 15:07:15 +02:00
Julius Härtl
19cf570aac
fix: Only store unencrypted_size if path should be encrypted 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-09-12 15:07:15 +02:00
Côme Chilliet
66c6bc01b6 fix(logging): user log condition feature 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2023-09-07 10:35:56 +02:00
Joas Schilling
c2d7e9b21e fix(ratelimit): Only use memory cache backend for redis 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2023-09-06 16:12:15 +00:00
Arthur Schiwon
41e0fcf80c
Merge pull request #40261 from nextcloud/backport/40234/stable25 
[stable25] enh: skip processing for empty response
 2023-09-05 18:54:53 +02:00
Arthur Schiwon
cb607b5b8d
Merge pull request #40233 from nextcloud/fix/fix-video-seeking-public-link 
[stable25] Detect aborted connection in OC\Files\View and stop writing data to the output buffer
 2023-09-05 18:54:31 +02:00
Arthur Schiwon
4299e1517d
Merge pull request #40188 from nextcloud/backport/39017/stable25 
[stable25] fix(s3): fix handling verify_bucket_exists parameter
 2023-09-05 17:46:40 +02:00
Arthur Schiwon
e004f8099a
Merge pull request #39731 from nextcloud/backport/39698/stable25 
[stable25] Catch more invalid cache source storage paths
 2023-09-05 17:45:25 +02:00
Côme Chilliet
6b2580d49a
Apply suggestions from code review in View.php 
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-09-05 14:36:23 +02:00
Daniel Kesselberg
07ab666d84
enh: skip processing for empty response 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2023-09-05 09:57:25 +02:00
Côme Chilliet
168b07d038
Lower log to debug for connections aborted by the client 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-09-04 16:45:14 +02:00
Côme Chilliet
cb2a6d688f
Detect aborted connection in OC\Files\View and stop writing data to the 
output buffer

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-09-04 14:58:30 +02:00
Thomas Citharel
fe37e5590b fix(s3): fix handling verify_bucket_exists parameter 
If 'verify_bucket_exists' is set to false in the config.php s3 configuration, it's supposed to avoid
verifying that the bucket exists. However empty(falsy) will  always return true, so this condition
would not work.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2023-08-31 21:45:44 +00:00
Anna Larch
681da56912 fix(CalDAV): check voject exists before attempting any operation 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2023-08-29 15:37:53 +02:00
Robin Appelman
2f1c599810
Merge pull request #39703 from nextcloud/cache-imcomplete-id-first-25 
[stable25] Select the fileid first when looking for incomplete files
 2023-08-28 14:18:48 +02:00
Robin Appelman
c8cf2ebf17
select the fileid first when looking for incomplete files 
this seems to improve mariadbs index selection

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-08-28 13:30:01 +02:00
Anna Larch
1e957b5c87
fix: don't emit Hooks when hookpaths are empty 
Signed-off-by: Anna Larch <anna@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
 2023-08-28 11:45:01 +02:00
John Molakvoæ
3330403031 fix: simplify sourceData check 
Co-authored-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2023-08-06 08:46:08 +00:00
Josh Richards
cc801d7c2f Catch more invalid cache source storage paths 
OC\Files\Cache\Cache::get can return string|false|null, not just string|false.

- nextcloud/server#26270 added handling of false, but null is needed too.
- Well, or we change the default $resullt to false, but I'm not sure if that has other ramifications and the real need here is to simply catch situations where the cache source storage path is not valid for whatever reason

Related: nextcloud/server#19009

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2023-08-06 08:46:07 +00:00
Arthur Schiwon
a54fc0a8ff
Merge pull request #39438 from nextcloud/backport/39309/stable25 
[stable25] fix(profile): fix getUID on nullable user variable
 2023-08-02 21:28:54 +02:00
Arthur Schiwon
43fd7ea94e
Merge pull request #39598 from nextcloud/backport/38667/stable25 
[stable25] fix(SystemTagManager): Use truncated tagName in getTag and updateTag
 2023-08-02 21:28:28 +02:00
Arthur Schiwon
2e2aeaa8d1
Merge pull request #39451 from nextcloud/backport/38907/stable25 
[stable25] Fix: ContactManager search with fullmatch
 2023-08-02 21:27:49 +02:00
Arthur Schiwon
237ed855dc
Merge pull request #39371 from nextcloud/backport/39339/stable25 
[stable25] fix(node): non-existing folder is not searchable
 2023-08-02 21:27:20 +02:00
Marcel Klehr
55a39eb726 fix(SystemTagManager): Use truncated tagName in getTag and updateTag 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2023-07-27 17:24:38 +00:00
Benjamin Gaussorgues
44b443e289
Add instance category while checking new updates 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-07-25 12:06:55 +02:00
Joas Schilling
a55662b3c5
fix(apps): Fix loading info.xml file 
Ref: https://bugs.php.net/bug.php?id=62577

Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-20 10:49:43 +02:00
Johannes Merkel
4910c617d1 fix(mail): ContactManager search with fullmatch 
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
 2023-07-18 09:16:36 +00:00
Thomas Citharel
e640bb3583 fix(profile): fix getUID on nullable user variable 
As per method signature, $visitingUser is nullable, so we can't be sure calling getUid() on it will
work.

Closes #35766

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
 2023-07-17 13:43:31 +00:00
Arthur Schiwon
e6438c3967 fix(node): non-existing folder is not searchable 
the previosuly introduced searchBySystemTag was not overwritten in
NonExistingFolder and could run the inherited method.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-13 15:05:25 +00:00
Arthur Schiwon
6715bbade1
Merge pull request #39101 from nextcloud/backport/39093/stable25 
[stable25] Silent `imagecreatefromstring()` errors
 2023-07-12 00:44:59 +02:00
Arthur Schiwon
59466b3424
Merge pull request #39233 from nextcloud/backport/39202/stable25 
[stable25] use more efficient tag retrieval on DAV report request
 2023-07-11 14:22:44 +02:00
Joas Schilling
cdc51554b2
Merge pull request #39253 from nextcloud/backport/38046/stable25 
[stable25] fix(dav): Abort requests with 429 instead of waiting
 2023-07-10 20:53:15 +02:00
Arthur Schiwon
6b79c81b34
Merge pull request #39032 from nextcloud/backport/38917/stable25 
[stable25] fix(l10n): Fix plural issue with different locale and language
 2023-07-10 17:27:46 +02:00
Daniel Kesselberg
ae691e0986
chore: fix codestyle for \OC\Files\Node\Folder 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2023-07-10 14:54:02 +02:00
Daniel Kesselberg
b2776bf586
fix: use handleLoginFailed for invalid email address 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2023-07-10 14:28:19 +02:00
Arthur Schiwon
2ca8c7102b
fix: PHP 7.4 compatibility 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-10 12:42:30 +02:00
Joas Schilling
446ebd35a9
fix(dav): Abort requests with 429 instead of waiting 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2023-07-10 06:35:25 +02:00
Arthur Schiwon
5121ccaa3a
style: satisfy code style checker 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-07 18:30:17 +02:00
Arthur Schiwon
33b9ba5cd9
refactor: adjust to unexposed searchBySystemTag 
- in this backport we have to drop the breaking addition in
  \OCP\Files\Folder
- this requires adjustments in check for the existance of the method but
  also in testing
- another change in \OCP\SystemTag\ISystemTagManager can be applied as
  this interface is not implemented elsewhere

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-07 17:56:54 +02:00
Arthur Schiwon
1ffae9d110
fix: cominbation of small fixes 
- possible null return
- parameter name mismatch in implementation
- incomplete unit test

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-07 17:55:50 +02:00
Arthur Schiwon
d21b251a85
fix: include invisible tags for admins 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-07 17:55:45 +02:00
Arthur Schiwon
837fd9f8da
fix: favorites view and universal search against tags 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-07 17:43:46 +02:00
Arthur Schiwon
5086dff563
fix: change if with conditionless else to switch; and a parameter value 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-07 17:43:40 +02:00
Arthur Schiwon
7e2ad76505
use efficient tag retrieval on DAV report request 
- uses DAV search approach against valid files joined by systemtag selector
- reduced table join for tag/systemtag search
- supports pagination
- no changes to the output formats or similar

Example request body:

<?xml version="1.0"?>
<oc:filter-files xmlns:d="DAV:" xmlns:oc="http://owncloud.org/ns" xmlns:nc="http://nextcloud.org/ns" xmlns:ocs="http://open-collaboration-services.org/ns">
  <d:prop>
    <d:getcontentlength/>
    <d:getcontenttype/>
    <d:getetag/>
    <d:getlastmodified/>
    <d:resourcetype/>
    <nc:face-detections/>
    <nc:file-metadata-size/>
    <nc:has-preview/>
    <nc:realpath/>
    <oc:favorite/>
    <oc:fileid/>
    <oc:permissions/>
    <nc:nbItems/>
  </d:prop>
  <oc:filter-rules>
    <oc:systemtag>32</oc:systemtag>
  </oc:filter-rules>
  <d:limit>
    <d:nresults>50</d:nresults>
    <nc:firstresult>0</nc:firstresult>
  </d:limit>
</oc:filter-files>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-07 17:43:34 +02:00
Arthur Schiwon
eba105b9a8
Merge pull request #39153 from nextcloud/backport/39115/stable25 
[stable25] fix(sse): don't update uncached files
 2023-07-06 18:43:25 +02:00
Arthur Schiwon
48a7a20ab6
Merge pull request #39154 from nextcloud/backport/38625/stable25 
[stable25] fix: expect interface, not a specific implementation
 2023-07-06 13:36:58 +02:00
Arthur Schiwon
1eb9f1874d
fix: adjust to PHP level and codebase 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-04 23:36:06 +02:00
Arthur Schiwon
2930f890d6
ci: adjust return annotation to older psalm version 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-04 23:14:56 +02:00
Arthur Schiwon
c2fdee7f6e
ci: pro forma check of existence of internal method 
createNode() is protected and used by Folder, but being an internal-only
method it shall not be exposed in the Folder or IRootFolder interface.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2023-07-04 23:12:58 +02:00