upstream/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-28 04:20:37 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 9
81241 commits 706 branches 1186 tags 7 GiB
Commit graph

452 commits

Author SHA1 Message Date
Joas Schilling
a425a1affc
test: Add a hint message on boolean comparison 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-06-06 14:36:33 +02:00
Louis
f4cb78b905
Merge pull request #52242 from nextcloud/artonge/fix/copy_subfolders_s3 2025-06-02 11:55:54 +02:00
Robin Appelman
be3cfefc75
Merge pull request #52816 from nextcloud/primary-object-store-settings 
feat: move primary object store configuration to a single place
 2025-05-28 17:40:53 +02:00
Robin Appelman
e21ce793a5 test: add test that object store folder copy preserves folder size 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-05-28 15:52:00 +02:00
Robin Appelman
7599162c7b feat: move primary object store configuration to a single place 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-05-28 15:32:31 +02:00
Ferdinand Thiessen
9422b6d6d0
test: adjust library tests for PHPunit deprecations 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-05-28 11:20:15 +02:00
Côme Chilliet
9560e00cf3 chore: Remove useless legacy autoloader for tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-05-27 16:15:58 +02:00
provokateurin
6818aa9b12
feat(UserMountCache): Emit events for added, removed and updated mounts 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2025-05-19 13:54:51 +02:00
Kate
6b4f5c567c
Merge pull request #52848 from nextcloud/fix/cleanup-servercontainer 2025-05-19 07:02:11 +02:00
Ferdinand Thiessen
494a079321
test: replace OC_Helper:rmdirr with OCP\Files::rmdirr 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-05-16 23:09:37 +02:00
Côme Chilliet
70ef0a8db7
fix: Remove calls to legacy callers in tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-05-16 11:47:38 +02:00
Côme Chilliet
0243d23b8c
fix(tests): Remove calls to removed getMountProviderCollection from tests 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-05-16 10:49:03 +02:00
Joas Schilling
5f9117b939
test: Fix coding standards 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-05-15 08:48:13 +02:00
Joas Schilling
3e7db013c1
test: Fix non-static data providers 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-05-15 08:25:01 +02:00
Joas Schilling
9621e451ba
test: Fix tests/lib/Files 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-05-15 08:25:00 +02:00
Joas Schilling
5283e9a5e2
test: Cleanup tests/lib/Files/* 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-05-15 08:21:22 +02:00
Côme Chilliet
2cd491f491
Merge pull request #48560 from nextcloud/fix/migrate-encryption-away-from-hooks 
feat(encryption): Migrate from hooks to events
 2025-05-14 19:25:51 +02:00
Andy Scherzinger
14f79829f3
Merge pull request #52775 from nextcloud/nested-jail-root 
fix unjailedroot of nested jails if there are other wrappers in between
 2025-05-14 17:36:55 +02:00
Côme Chilliet
a79b5dea7c fix(encryption): Improve Update class and event listenening 
to avoid back&forth between path and Node object

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-05-13 23:37:52 +02:00
Côme Chilliet
e35a8ed063 fix(tests): Disable encryption wrapper when it makes sense 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-05-13 23:37:52 +02:00
Côme Chilliet
21233b7e17 fix(tests): Remove Encryption disabling in ViewTest to avoid side effects 
Adapt tests a bit to make them pass with Encryption wrapper registered

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-05-13 23:37:52 +02:00
Côme Chilliet
38f341c179 fix(tests): Unregister encryption modules in ViewTest to avoid side effects 
It was clearing the hooks with the same results before

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-05-13 23:37:52 +02:00
Robin Appelman
0001c22668 test: add test for nested cache jail unjailedroot 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-05-13 18:29:00 +02:00
Ferdinand Thiessen
6cf1870322
feat(FilenameValidator): allow to sanitize filenames 
Share the filename sanitizing with the OCP filename validator.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-05-13 14:14:17 +02:00
Joas Schilling
c24f5fb256
test: Finish migrating tests/Core/ to PHPUnit 10 compatible code 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2025-05-02 16:47:42 +02:00
Louis
f8391e60ce
Merge pull request #51020 from nextcloud/artonge/fix/transfer_ownership 2025-04-14 16:14:45 +02:00
Côme Chilliet
0cf4f3cc71
fix: Replace all usages of OC_User backend method calls by IUserManager 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2025-04-10 11:29:21 +02:00
Louis Chemineau
8fdf2a7eae fix: Transfer ownership with S3 as primary 
When using S3 as primary storage, transferring ownership with the `--move` option fail with the following error:

`SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '8-45b963397aa40d4a0063e0d85e4fe7a1' for key 'fs_storage_path_hash'`

The `--move` option moves the entire home folder from one account to another.
The error means that the move failed because the destination folder already exist in `oc_filecache`.

- With S3 as primary storage, folders only exists as entries in `oc_filecache`.
- With S3 as primary storage, `moveFromStorage(...)` only moves the cache entry, as nothing needs to be moved on disk. This cache move does not delete potentially pre-existing destination folder.
- With Local storage, `moveFromStorage(...)` calls `rename(...)` which delete pre-existing folder.

- `transfer(...)`: 687a4d9ac7/apps/files/lib/Service/OwnershipTransferService.php (L112)
- `oneTimeUserSetup(...)`: 687a4d9ac7/lib/private/Files/SetupManager.php (L261-L262)
- `mkdir(...)`: 687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L91-L135)
- `moveFromStorage(...)`: 687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L635-L636)

Delete pre-existing folder in `moveFromStorage(...)`

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-04-01 13:53:56 +02:00
Ferdinand Thiessen
254dd85664
fix(IFilenameValidator): correctly handle case insensitivity 
- forbidden names and forbidden base names are case **insensitive**
  so we need to check all lowercase here.
- add test that config value is also read case insensitive.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-03-21 01:00:58 +01:00
skjnldsv
6baafd82b6 fix: make sure we process mime extensions as string 
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
 2025-02-05 12:35:41 +01:00
Ferdinand Thiessen
b48ee2e924
fix: Harden files scanner for invalid null access 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2025-01-28 20:08:46 +01:00
Louis Chemineau
a635710117
fix: Metadata field search 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2025-01-20 14:41:55 +01:00
Robin Appelman
7b2cb2e3bc
test: update test for mountpoint numeric storage id 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-01-13 18:09:29 +01:00
Robin Appelman
16d0363937
fix: improve checks for moving shares/storages into other mounts 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2025-01-03 15:36:32 +01:00
Robin Appelman
37199779de
fix: fix mimetype not being updated when changing file extention on object store 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-12-05 18:05:13 +01:00
Louis Chemineau
425e0c3660
test(View): Copy preserves content 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-12-03 18:29:32 +01:00
Louis Chemineau
199b0bd4d9
fix(files): Correctly copy the cache information on copy operations 
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-12-03 17:04:44 +01:00
Louis Chemineau
f9cda54cbf
fix: Wrap partial cache entry in CacheEntry 
Because it is returned here: 7b7d07c575/lib/private/Files/Cache/Cache.php (L136-L137)

And some implementation got stricter: df95bf6ba8/lib/Mount/RootEntryCache.php (L23-L28)

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-11-21 17:13:24 +01:00
John Molakvoæ
e3e22e28c0
Merge pull request #47847 from nextcloud/fix-copying-or-moving-from-shared-groupfolders 2024-10-29 11:33:12 +01:00
provokateurin
0de4843b73 refactor(Storage): Align all Storage constructors 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-23 13:24:18 +02:00
Robin Appelman
7cb07bf306 test: add test for nested jail cross-storage move 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-10-10 15:16:12 +02:00
provokateurin
f28e74b7a8
refactor(Storage): Make all parameter types strong types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-07 15:00:05 +02:00
provokateurin
4412b2b8a8
refactor(Wrapper\Encryption): Migrate to strong types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-07 14:11:56 +02:00
provokateurin
d1977b8d25
refactor(Stream\Encryption): Migrate to strong types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-07 14:02:27 +02:00
provokateurin
256a8d8903
test: Fix IStorage return types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-26 17:29:48 +02:00
Côme Chilliet
4adf5fd5b0
fix(tests): Pause trashbin for lock tests in ViewTest using rmdir and unlink 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-24 10:37:38 +02:00
Côme Chilliet
40b404c566
Merge pull request #48111 from nextcloud/fix/move-storage-constructor-to-specific-interface 
fix: Move storage constructor to specific interface
 2024-09-23 15:57:38 +02:00
Côme Chilliet
b8ab560bdd
fix(tests): Fix test to remove call to non-existing constructor 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-23 14:50:43 +02:00
Louis Chemineau
22d5d29c01 fix(users): Don't crash if disabled user is missing in the database 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-09-23 10:40:38 +02:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-19 14:21:20 +02:00